Skip to contentSkip to conversation

sdp4430: fix mux configuration for SYS_NIRQ2

PATCH New Peter Ujfalusi 2 participants 5 messages May 17, 2012 – May 18, 2012

lore
Share & tools
lore

Peter Ujfalusi

author
#0 lore raw

PATCH 1/1 sdp4430: fix mux configuration for SYS_NIRQ2

SYS_NIRQ2 is servicing the interrupt from twl6040. Configure the SYS_NIRQ2 so we can actually receive the interrupts.

Signed-off-by Peter Ujfalusi <[email protected]>
---
 board/ti/sdp4430/sdp4430_mux_data.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
board/ti/sdp4430/sdp4430_mux_data.h +1 -1
index 0a20968..beb7c7a 100644
@@ -216,7 +216,7 @@ const struct pad_conf_entry core_padconf_array_non_essential[] = {
 	{FREF_CLK1_OUT, (M0)},						/* fref_clk1_out */
 	{FREF_CLK2_OUT, (M0)},						/* fref_clk2_out */
 	{SYS_NIRQ1, (PTU | IEN | M0)},					/* sys_nirq1 */
-	{SYS_NIRQ2, (M7)},						/* sys_nirq2 */
+	{SYS_NIRQ2, (PTU | IEN | M0)},					/* sys_nirq2 */
 	{SYS_BOOT0, (PTU | IEN | M3)},					/* gpio_184 */
 	{SYS_BOOT1, (M3)},						/* gpio_185 */
 	{SYS_BOOT2, (PTD | IEN | M3)},					/* gpio_186 */
Signature · 1 line
1.7.8.6
#1 lore raw

PATCH 1/1 sdp4430: fix mux configuration for SYS_NIRQ2

Hi Peter,

Quoted 8 lines

?board/ti/sdp4430/sdp4430_mux_data.h | ? ?2 +-
?1 files changed, 1 insertions(+), 1 deletions(-)

board/ti/sdp4430/sdp4430_mux_data.h +0 -0
index 0a20968..beb7c7a 100644
@@ -216,7 +216,7 @@ const struct pad_conf_entry core_padconf_array_non_essential[] = {
Quoted 5 lines

? ? ? ?{FREF_CLK1_OUT, (M0)}, ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?/* fref_clk1_out */ ? ? ? ?{FREF_CLK2_OUT, (M0)}, ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?/* fref_clk2_out */ ? ? ? ?{SYS_NIRQ1, (PTU | IEN | M0)}, ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?/* sys_nirq1 */
- ? ? ? {SYS_NIRQ2, (M7)}, ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?/* sys_nirq2 */
+ ? ? ? {SYS_NIRQ2, (PTU | IEN | M0)}, ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?/* sys_nirq2 */

Looks fine. But how about doing this in the kernel using mux framework?

Thanks,
Sricharan

author
#2 lore raw

PATCH 1/1 sdp4430: fix mux configuration for SYS_NIRQ2

Hi Sricharan,

Quoted 4 lines · Sricharan
Quoted 4 lines
board/ti/sdp4430/sdp4430_mux_data.h +0 -0
index 0a20968..beb7c7a 100644
Quoted 8 lines

board/ti/sdp4430/sdp4430_mux_data.h const struct pad_conf_entry core_padconf_array_non_essential[] = { · line 219

Quoted 6 lines
board/ti/sdp4430/sdp4430_mux_data.h +1 -1
@@ -216,7 +216,7 @@ const struct pad_conf_entry core_padconf_array_non_essential[] = {
       {FREF_CLK1_OUT, (M0)},                                          /* fref_clk1_out */
       {FREF_CLK2_OUT, (M0)},                                          /* fref_clk2_out */
       {SYS_NIRQ1, (PTU | IEN | M0)},                                  /* sys_nirq1 */
-       {SYS_NIRQ2, (M7)},                                              /* sys_nirq2 */
+       {SYS_NIRQ2, (PTU | IEN | M0)},                                  /* sys_nirq2 */

Looks fine. But how about doing this in the kernel using mux framework?

The SYS_NIRQ2 has been configured correctly in case of PandaBoard in u-boot. Looking at the kernel: neither of the sdp4430 or PandaBoard board files are configuring SYS_NIRQ1/2, all relies on the bootloader to set this up. I can as well send patches for sdp4430 and PandaBoard board files to configure the SYS_NIRQ2 explicitly, but IMHO the bootloader can do this for us with ease as well.
I think if we can we should set up things in a bootloader and let the kernel to deal with smaller differences (like things differs between board revisions and stuff).

Regards,
P?ter

#3 lore raw

PATCH 1/1 sdp4430: fix mux configuration for SYS_NIRQ2

Hi peter,

Quoted 9 lines
Quoted 8 lines
Quoted 6 lines
(quoted diff) +0 -0
@@ -216,7 +216,7 @@ const struct pad_conf_entry core_padconf_array_non_essential[] = {

? ? ? ?{FREF_CLK1_OUT, (M0)}, ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?/* fref_clk1_out */ ? ? ? ?{FREF_CLK2_OUT, (M0)}, ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?/* fref_clk2_out */ ? ? ? ?{SYS_NIRQ1, (PTU | IEN | M0)}, ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?/* sys_nirq1 */
- ? ? ? {SYS_NIRQ2, (M7)}, ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?/* sys_nirq2 */
+ ? ? ? {SYS_NIRQ2, (PTU | IEN | M0)}, ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?/* sys_nirq2 */

? ?Looks fine. But how about doing this in the kernel using mux framework?

Quoted 9 lines

The SYS_NIRQ2 has been configured correctly in case of PandaBoard in u-boot. Looking at the kernel: neither of the sdp4430 or PandaBoard board files are configuring SYS_NIRQ1/2, all relies on the bootloader to set this up. I can as well send patches for sdp4430 and PandaBoard board files to configure the SYS_NIRQ2 explicitly, but IMHO the bootloader can do this for us with ease as well.
I think if we can we should set up things in a bootloader and let the kernel to deal with smaller differences (like things differs between board revisions and stuff).

The issue here is we want to remove the way, kernel is dependent on
bootloader for these settings. The bootloader should only the minimum required for boot. In fact we should get rid of this entire
core_padconf_array_non_essential
itself. We have already seen that certain pins when set in bootloader
and not used
in kernel creates problem during power transitions etc. The only
solution is to
remove all these in the bootloader..

Thanks,
Sricharan

#4 lore raw

PATCH 1/1 sdp4430: fix mux configuration for SYS_NIRQ2

Hi Sricharan,

Quoted 9 lines · Sricharan

?The issue here is we want to remove the way, kernel is dependent on ?bootloader for these settings. The bootloader should only the minimum required ?for boot. In fact we should get rid of this entire core_padconf_array_non_essential
?itself. We have already seen that certain pins when set in bootloader and not used
?in kernel creates problem during power transitions etc. ?The only solution is to
?remove all these in the bootloader..

Fair enough. I will send the patch for the kernel after my holiday.

Signature · 1 line
P?ter