Skip to contentSkip to conversation

davinci: Fix Ethernet driver interface warning

PATCH New Joe Hershberger 3 participants 4 messages May 21, 2012 Network drivers

lore
Share & tools
lore

Joe Hershberger

author
#0 lore raw

PATCH 1/1 davinci: Fix Ethernet driver interface warning

Fixes:
davinci_emac.c: In function 'davinci_emac_initialize':
davinci_emac.c:796:12: warning: assignment from incompatible pointer type [enabled by default]

Tested on da850_am18xxevm

Signed-off-by Joe Hershberger <[email protected]>
Cc Joe Hershberger <[email protected]>
---
 drivers/net/davinci_emac.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/davinci_emac.c +1 -1
index fbd0f1b..e471d2c 100644
@@ -637,7 +637,7 @@ static int tx_send_loop = 0;
  * positive number (number of bytes transmitted) or negative for error
  */
 static int davinci_eth_send_packet (struct eth_device *dev,
-					volatile void *packet, int length)
+					void *packet, int length)
 {
 	int ret_status = -1;
 	int index;
Signature · 1 line
1.6.0.2
#1 lore raw

PATCH 1/1 davinci: Fix Ethernet driver interface warning

Hi Tom,

Quoted 8 lines · Joe Hershberger

Fixes:
davinci_emac.c: In function 'davinci_emac_initialize':
davinci_emac.c:796:12: warning: assignment from incompatible pointer type [enabled by default]

Tested on da850_am18xxevm

Signed-off-by Joe Hershberger <[email protected]>
Cc Joe Hershberger <[email protected]>

I'll apply this through the net branch.

Thanks,
-Joe

#2 lore raw

PATCH 1/1 davinci: Fix Ethernet driver interface warning

Quoted 8 lines · Joe Hershberger

Hi Tom,

Quoted 4 lines · Joe Hershberger

Fixes:
davinci_emac.c: In function 'davinci_emac_initialize':
davinci_emac.c:796:12: warning: assignment from incompatible pointer type [enabled by default]

Quoted 6 lines
Quoted 4 lines

Tested on da850_am18xxevm

Signed-off-by Joe Hershberger<[email protected]>
Cc Joe Hershberger<[email protected]>

I'll apply this through the net branch.

OK, thanks. Please take it from me in patchwork too :)

Signature · 1 line
Tom
Applied
#3 lore raw

PATCH 1/1 davinci: Fix Ethernet driver interface warning

Quoted 14 lines · Tom Rini
Quoted 13 lines · Joe Hershberger

Hi Tom,

Quoted 8 lines · On Mon, May 21, 2012 at 10:54 AM, Joe Hershberger <[email protected]>…

Fixes:
davinci_emac.c: In function 'davinci_emac_initialize':
davinci_emac.c:796:12: warning: assignment from incompatible pointer type [enabled by default]

Tested on da850_am18xxevm

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Signed-off-by Joe Hershberger<[email protected]>
Cc Joe Hershberger<[email protected]>

I'll apply this through the net branch.

OK, thanks. ?Please take it from me in patchwork too :)

Applied, thanks.

-Joe