Skip to contentSkip to conversation

Could btrfs-restore be extended to also restore file dates?

DISCUSSION Henry Bakker 2 participants 3 messages May 22, 2012 – May 23, 2012 Btrfs file system

lore
Share & tools
lore
#0 lore raw

Any possibility of getting btrfs-restore to also restore the files timestamp?

I'm doing a restore right now as I had one btrfs partition blow up and I'm noting that the timestamps are marking all the restored files as new. It would be nice to be able to do a quick compare of file dates to determine any changed files that may be newer on the restore vs the backup. (I can save full file compares for when the server is not being actively used.)

I do realize it is possible that there could be other issues, but for quickly determining potential issues this could be useful.

I do realize that there may be technical reasons for the current behavior, so at the very least this is suggestion for future functionality even if it doesn't help me.

#1 lore raw
Quoted 2 lines · Henry Bakker

Any possibility of getting btrfs-restore to also restore the files timestamp?

Quick look, yes it is possible and quite straightforward. The function restore.c:copy_file has direct access to the found on-disk inode item and can access the time fileds, then simply setting them for the file. Maybe it could restore more, like uid, gid or mode.

david

#2 lore raw

I'm sure restoring all those fields would be functionality that most server admins would want. If anyone on this list can add it, then you have my thanks.

Quoted 13 lines · David Sterba
Quoted 2 lines · Henry Bakker

Any possibility of getting btrfs-restore to also restore the files timestamp?

Quick look, yes it is possible and quite straightforward. The function restore.c:copy_file has direct access to the found on-disk inode item and can access the time fileds, then simply setting them for the file. Maybe it could restore more, like uid, gid or mode.

david