Skip to contentSkip to conversation

utils.bbclass: remove the unused oe_system

PATCH Applied Robert Yang 2 participants 3 messages May 24, 2012 – May 25, 2012

lore
Share & tools
lore
#0 lore raw

cover utils.bbclass: remove the unused oe_system

The following changes since commit 6558abda67956e4fab1304b0cdf03c65f18fabd5:

qemu: disable vnc-jpeg compression (2012-05-24 08:53:57 +0100)

are available in the git repository at:
git://git.pokylinux.org/poky-contrib robert/oe_system
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/oe_system

Robert Yang (1):
utils.bbclass: remove the unused oe_system

 meta/classes/utils.bbclass |   26 --------------------------
 1 files changed, 0 insertions(+), 26 deletions(-)
#1 lore raw

PATCH 1/1 utils.bbclass: remove the unused oe_system

The following functions in meta/classes/utils.bbclass were not used by anyone, and they didn't work when I tried to use them:

def oe_popen_env(d):
def oe_run(d, cmd, **kwargs):
def oe_popen(d, cmd, **kwargs):
def oe_system(d, cmd, **kwargs):

There error was:
AttributeError: type object 'str' has no attribute 'getVar'

We have bitbake/lib/bb/process.py to instead, so remove them.

[YOCTO #2489]

---
 meta/classes/utils.bbclass |   26 --------------------------
 1 files changed, 0 insertions(+), 26 deletions(-)
meta/classes/utils.bbclass +0 -26
index fde8f44..f8b09b4 100644
@@ -58,32 +58,6 @@ def is_machine_specific(d):
             if any(fetcher.localpath(url).startswith(mp + "/") for mp in machinepaths):
                 return True
 
-def oe_popen_env(d):
-    env = d.getVar("__oe_popen_env", False)
-    if env is None:
-        env = {}
-        for v in d.keys():
-            if d.getVarFlag(v, "export"):
-                env[v] = d.getVar(v, True) or ""
-        d.setVar("__oe_popen_env", env)
-    return env
-
-def oe_run(d, cmd, **kwargs):
-    import oe.process
-    kwargs["env"] = oe_popen_env(d)
-    return oe.process.run(cmd, **kwargs)
-
-def oe_popen(d, cmd, **kwargs):
-    import oe.process
-    kwargs["env"] = oe_popen_env(d)
-    return oe.process.Popen(cmd, **kwargs)
-
-def oe_system(d, cmd, **kwargs):
-    """ Popen based version of os.system. """
-    if not "shell" in kwargs:
-        kwargs["shell"] = True
-    return oe_popen(d, cmd, **kwargs).wait()
-
 oe_soinstall() {
 	# Purpose: Install shared library file and
 	#          create the necessary links
Signature · 1 line
1.7.1
Applied
#2 lore raw
In reply to Robert Yang
Quoted 11 lines · Robert Yang

The following changes since commit 6558abda67956e4fab1304b0cdf03c65f18fabd5:

   qemu: disable vnc-jpeg compression (2012-05-24 08:53:57 +0100)

are available in the git repository at:
git://git.pokylinux.org/poky-contrib robert/oe_system
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/oe_system

Robert Yang (1):
utils.bbclass: remove the unused oe_system

Quoted 9 lines
  meta/classes/utils.bbclass |   26 --------------------------
  1 files changed, 0 insertions(+), 26 deletions(-)

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Merged into OE-Core

Thanks
Sau!