Skip to contentSkip to conversation

quota: fix checkpatch.pl warnning by replacing <asm/uaccess.h> with <linux/uaccess.h>

PATCH In review Jeff Liu 2 participants 2 messages May 28, 2012 – May 29, 2012

Subsystems (2)
lore
Share & tools
lore

Jeff Liu

author
#0 lore raw

PATCH 1/1 quota: fix checkpatch.pl warnning by replacing <asm/uaccess.h> with <linux/uaccess.h>

Hello,

checkpatch.pl raise warnning info when I checking a patch for quota stuff which was shown as following:

"WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>"

Below patch can fix it, thanks.

---
 fs/quota/dquot.c |    2 +-
 fs/quota/quota.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
fs/quota/dquot.c +1 -1
index 10cbe84..0c541dc 100644
@@ -78,7 +78,7 @@
 #include <linux/quotaops.h>
 #include "../internal.h" /* ugh */
 
-#include <asm/uaccess.h>
+#include <linux/uaccess.h>
 
 /*
  * There are three quota SMP locks. dq_list_lock protects all lists with quotas
fs/quota/quota.c +1 -1
index 40f381e..6943e1d 100644
@@ -9,7 +9,7 @@
 #include <linux/namei.h>
 #include <linux/slab.h>
 #include <asm/current.h>
-#include <asm/uaccess.h>
+#include <linux/uaccess.h>
 #include <linux/kernel.h>
 #include <linux/security.h>
 #include <linux/syscalls.h>
Signature · 1 line
1.7.9
reviewer
#1 lore raw
Quoted 7 lines · Jeff Liu

Hello,

checkpatch.pl raise warnning info when I checking a patch for quota stuff which was shown as following:

"WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>"

Below patch can fix it, thanks.

Thanks. Merged into my tree.

Honza

Quoted 36 lines
---
 fs/quota/dquot.c |    2 +-
 fs/quota/quota.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
fs/quota/dquot.c +1 -1
index 10cbe84..0c541dc 100644
@@ -78,7 +78,7 @@
 #include <linux/quotaops.h>
 #include "../internal.h" /* ugh */
 
-#include <asm/uaccess.h>
+#include <linux/uaccess.h>
 
 /*
  * There are three quota SMP locks. dq_list_lock protects all lists with quotas
fs/quota/quota.c +1 -1
index 40f381e..6943e1d 100644
@@ -9,7 +9,7 @@
 #include <linux/namei.h>
 #include <linux/slab.h>
 #include <asm/current.h>
-#include <asm/uaccess.h>
+#include <linux/uaccess.h>
 #include <linux/kernel.h>
 #include <linux/security.h>
 #include <linux/syscalls.h>
Signature · 1 line
1.7.9