Skip to contentSkip to conversation

mfd: Remove config AB8500_I2C_CORE Kconfig entry

PATCH In review Axel Lin 3 participants 10 messages May 29, 2012 Multifunction devices (MFD)

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 mfd: Remove config AB8500_I2C_CORE Kconfig entry

config AB8500_I2C_CORE is not used after commit d28f1db "mfd: Remove confusing ab8500-i2c file and merge into ab8500-core". Thus remove it.

---
 drivers/mfd/Kconfig |   10 ----------
 1 file changed, 10 deletions(-)
drivers/mfd/Kconfig +0 -10
index e129c82..170072e 100644
@@ -703,16 +703,6 @@ config AB8500_CORE
 	  the irq_chip parts for handling the Mixed Signal chip events.
 	  This chip embeds various other multimedia funtionalities as well.
 
-config AB8500_I2C_CORE
-	bool "AB8500 register access via PRCMU I2C"
-	depends on AB8500_CORE && MFD_DB8500_PRCMU
-	default y
-	help
-	  This enables register access to the AB8500 chip via PRCMU I2C.
-	  The AB8500 chip can be accessed via SPI or I2C. On DB8500 hardware
-	  the I2C bus is connected to the Power Reset
-	  and Mangagement Unit, PRCMU.
-
 config AB8500_DEBUG
        bool "Enable debug info via debugfs"
        depends on AB8500_CORE && DEBUG_FS
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 5 lines · Axel Lin

config AB8500_I2C_CORE is not used after commit d28f1db "mfd: Remove confusing ab8500-i2c file and merge into ab8500-core". Thus remove it.

I have this patch embedded into a patch-set I'm going to send to ARM-SoC for inclusion into -rc1 this afternoon. Would you mind leaving this one?

Signature · 5 lines
Lee Jones
Linaro ST-Ericsson Landing Team Lead
M: +44 77 88 633 515
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
author
#2 lore raw

2012/5/29 Lee Jones <[email protected]>:

Quoted 11 lines · Axel Lin
Quoted 6 lines

config AB8500_I2C_CORE is not used after commit d28f1db "mfd: Remove confusing ab8500-i2c file and merge into ab8500-core". Thus remove it.

I have this patch embedded into a patch-set I'm going to send to ARM-SoC for inclusion into -rc1 this afternoon. Would you mind leaving this one?

I don't mind.
But AFAIK, commit d28f1db is in mfd tree.
Any reason you want to send the patch to ARM-SoC instead of mfd tree.

Regards,
Axel

#3 lore raw
Quoted 10 lines · Axel Lin

2012/5/29 Lee Jones<[email protected]>:

Quoted 9 lines · Axel Lin
Quoted 6 lines

config AB8500_I2C_CORE is not used after commit d28f1db "mfd: Remove confusing ab8500-i2c file and merge into ab8500-core". Thus remove it.

Quoted 6 lines
Quoted 2 lines

I have this patch embedded into a patch-set I'm going to send to ARM-SoC for inclusion into -rc1 this afternoon. Would you mind leaving this one?

I don't mind.
But AFAIK, commit d28f1db is in mfd tree.
Any reason you want to send the patch to ARM-SoC instead of mfd tree.

I don't actually have a preference as to which tree it goes into, so long as it's sent to Mainline on or before -rc1. This patch isn't too important, but the others in the patch-set are and I'd like to keep them together if possible. Unless of course Sam or Mark have any issues with that. In which case I will bow down to them and do as they wish.

Kind regards,
Lee

Signature · 5 lines
Lee Jones
Linaro ST-Ericsson Landing Team Lead
M: +44 77 88 633 515
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#4 lore raw

Hi Lee,

Quoted 14 lines · Lee Jones
Quoted 13 lines · Axel Lin

2012/5/29 Lee Jones<[email protected]>:

Quoted 11 lines · Axel Lin
Quoted 6 lines

config AB8500_I2C_CORE is not used after commit d28f1db "mfd: Remove confusing ab8500-i2c file and merge into ab8500-core". Thus remove it.

I have this patch embedded into a patch-set I'm going to send to ARM-SoC for inclusion into -rc1 this afternoon. Would you mind leaving this one?

Quoted 6 lines
Quoted 3 lines

I don't mind.
But AFAIK, commit d28f1db is in mfd tree.
Any reason you want to send the patch to ARM-SoC instead of mfd tree.

I don't actually have a preference as to which tree it goes into, so long as it's sent to Mainline on or before -rc1.

I sent a pull request to Linus yesterday, including this commit.

Cheers,
Samuel.

Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/
#5 lore raw

Hi Sam,

Quoted 15 lines · Lee Jones
Quoted 14 lines · Axel Lin
Quoted 13 lines

2012/5/29 Lee Jones<[email protected]>:

Quoted 11 lines · Axel Lin
Quoted 6 lines

config AB8500_I2C_CORE is not used after commit d28f1db "mfd: Remove confusing ab8500-i2c file and merge into ab8500-core". Thus remove it.

I have this patch embedded into a patch-set I'm going to send to ARM-SoC for inclusion into -rc1 this afternoon. Would you mind leaving this one?

Quoted 7 lines
Quoted 6 lines
Quoted 3 lines

I don't mind.
But AFAIK, commit d28f1db is in mfd tree.
Any reason you want to send the patch to ARM-SoC instead of mfd tree.

I don't actually have a preference as to which tree it goes into, so long as it's sent to Mainline on or before -rc1.

I sent a pull request to Linus yesterday, including this commit.

This is something different and wasn't part of the pull-request.

Kind regards,
Lee

Signature · 5 lines
Lee Jones
Linaro ST-Ericsson Landing Team Lead
M: +44 77 88 633 515
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#6 lore raw

Hi Lee,

Quoted 21 lines · Lee Jones

Hi Sam,

Quoted 19 lines · Lee Jones
Quoted 18 lines · Axel Lin
Quoted 16 lines

2012/5/29 Lee Jones<[email protected]>:

Quoted 11 lines · Axel Lin
Quoted 6 lines

config AB8500_I2C_CORE is not used after commit d28f1db "mfd: Remove confusing ab8500-i2c file and merge into ab8500-core". Thus remove it.

I have this patch embedded into a patch-set I'm going to send to ARM-SoC for inclusion into -rc1 this afternoon. Would you mind leaving this one?

I don't mind.
But AFAIK, commit d28f1db is in mfd tree.
Any reason you want to send the patch to ARM-SoC instead of mfd tree.

Quoted 5 lines
Quoted 3 lines
Quoted 2 lines

I don't actually have a preference as to which tree it goes into, so long as it's sent to Mainline on or before -rc1.

I sent a pull request to Linus yesterday, including this commit.

This is something different and wasn't part of the pull-request.

d28f1d was part of the pull request.

Cheers,
Samuel.

Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/
#7 lore raw
Quoted 24 lines · Samuel Ortiz

Hi Lee,

Quoted 21 lines · Lee Jones

Hi Sam,

Quoted 19 lines · Lee Jones
Quoted 18 lines · Axel Lin
Quoted 16 lines

2012/5/29 Lee Jones<[email protected]>:

Quoted 11 lines · Axel Lin
Quoted 6 lines

config AB8500_I2C_CORE is not used after commit d28f1db "mfd: Remove confusing ab8500-i2c file and merge into ab8500-core". Thus remove it.

I have this patch embedded into a patch-set I'm going to send to ARM-SoC for inclusion into -rc1 this afternoon. Would you mind leaving this one?

I don't mind.
But AFAIK, commit d28f1db is in mfd tree.
Any reason you want to send the patch to ARM-SoC instead of mfd tree.

Quoted 6 lines
Quoted 5 lines
Quoted 3 lines
Quoted 2 lines

I don't actually have a preference as to which tree it goes into, so long as it's sent to Mainline on or before -rc1.

I sent a pull request to Linus yesterday, including this commit.

This is something different and wasn't part of the pull-request.

d28f1d was part of the pull request.

Right. But this is not the same thing. The patch I (and Axel) wrote removes remnant cruft from d28f1d. I didn't see that on moving AB8500_I2C_CORE to AB8500_CORE I left a Kconfig entry behind which is no longer used by anything. This patch removes that cruft.

Kind regards,
Lee

Signature · 5 lines
Lee Jones
Linaro ST-Ericsson Landing Team Lead
M: +44 77 88 633 515
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#8 lore raw

Hi Lee,

Quoted 29 lines · Lee Jones
Quoted 28 lines · Samuel Ortiz

Hi Lee,

Quoted 25 lines · Lee Jones

Hi Sam,

Quoted 22 lines · Lee Jones
Quoted 14 lines · Axel Lin
Quoted 13 lines

2012/5/29 Lee Jones<[email protected]>:

Quoted 11 lines · Axel Lin
Quoted 6 lines

config AB8500_I2C_CORE is not used after commit d28f1db "mfd: Remove confusing ab8500-i2c file and merge into ab8500-core". Thus remove it.

I have this patch embedded into a patch-set I'm going to send to ARM-SoC for inclusion into -rc1 this afternoon. Would you mind leaving this one?

Quoted 6 lines
Quoted 3 lines

I don't mind.
But AFAIK, commit d28f1db is in mfd tree.
Any reason you want to send the patch to ARM-SoC instead of mfd tree.

I don't actually have a preference as to which tree it goes into, so long as it's sent to Mainline on or before -rc1.

I sent a pull request to Linus yesterday, including this commit.

Quoted 7 lines
Quoted 2 lines
Quoted 1 line

This is something different and wasn't part of the pull-request.

d28f1d was part of the pull request.

Right. But this is not the same thing. The patch I (and Axel) wrote removes remnant cruft from d28f1d. I didn't see that on moving AB8500_I2C_CORE to AB8500_CORE I left a Kconfig entry behind which is no longer used by anything. This patch removes that cruft.

Yes, I saw the patch. I though you were saying that d28f1d was not part of the pull request and that you were going to push it through arm-soc. Anyway, I think the Kconfig cleanup patch should go through my tree unless you already sent it for arm-soc inclusion.

Cheers,
Samuel.

Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/
#9 lore raw
Quoted 35 lines · Samuel Ortiz

Hi Lee,

Quoted 32 lines · Lee Jones
Quoted 30 lines · Samuel Ortiz

Hi Lee,

Quoted 21 lines · Lee Jones

Hi Sam,

Quoted 19 lines · Lee Jones
Quoted 18 lines · Axel Lin
Quoted 16 lines

2012/5/29 Lee Jones<[email protected]>:

Quoted 11 lines · Axel Lin
Quoted 6 lines

config AB8500_I2C_CORE is not used after commit d28f1db "mfd: Remove confusing ab8500-i2c file and merge into ab8500-core". Thus remove it.

I have this patch embedded into a patch-set I'm going to send to ARM-SoC for inclusion into -rc1 this afternoon. Would you mind leaving this one?

I don't mind.
But AFAIK, commit d28f1db is in mfd tree.
Any reason you want to send the patch to ARM-SoC instead of mfd tree.

Quoted 5 lines
Quoted 3 lines
Quoted 2 lines

I don't actually have a preference as to which tree it goes into, so long as it's sent to Mainline on or before -rc1.

I sent a pull request to Linus yesterday, including this commit.

This is something different and wasn't part of the pull-request.

d28f1d was part of the pull request.

Quoted 8 lines
Quoted 4 lines

Right. But this is not the same thing. The patch I (and Axel) wrote removes remnant cruft from d28f1d. I didn't see that on moving AB8500_I2C_CORE to AB8500_CORE I left a Kconfig entry behind which is no longer used by anything. This patch removes that cruft.

Yes, I saw the patch. I though you were saying that d28f1d was not part of the pull request and that you were going to push it through arm-soc. Anyway, I think the Kconfig cleanup patch should go through my tree unless you already sent it for arm-soc inclusion.

I haven't. I sent the entire patch-set to Arnd for first review today. After he's okay:ed it, I'll send it to the MLs sometime tomorrow. I will ensure you are CC'ed. I don't have any issues with the patch going through your tree.

Thanks Sam.

Kind regards,
Lee

Signature · 5 lines
Lee Jones
Linaro ST-Ericsson Landing Team Lead
M: +44 77 88 633 515
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog