mtip32xx: Change HDIO_GET_IDENTITY to return stored data

PATCH In review Asai Thambi S P 1 participant 1 message May 30, 2012 Block layer

Share & tools

Asai Thambi S P

author

2012-05-30 01:41 UTC #0 lore raw

PATCH 3/11 mtip32xx: Change HDIO_GET_IDENTITY to return stored data

For the ioctl command HDIO_GET_IDENTITY, return the stored copy of IDENTIFY DATA instead of sending the command to the device - similar to libata.

Signed-off-by Asai Thambi S P <[email protected]>

---
 drivers/block/mtip32xx/mtip32xx.c |   11 +++++------
 1 files changed, 5 insertions(+), 6 deletions(-)

drivers/block/mtip32xx/mtip32xx.c +5 -6

index bbbdaf9..8b7f82b 100644
@@ -2295,13 +2295,12 @@ static int mtip_hw_ioctl(struct driver_data *dd, unsigned int cmd,
 {
 	switch (cmd) {
 	case HDIO_GET_IDENTITY:
-		if (mtip_get_identify(dd->port, (void __user *) arg) < 0) {
-			dev_warn(&dd->pdev->dev,
-				"Unable to read identity\n");
-			return -EIO;
-		}
-
+	{
+		if (copy_to_user((void __user *)arg, dd->port->identify,
+						sizeof(u16) * ATA_ID_WORDS))
+			return -EFAULT;
 		break;
+	}
 	case HDIO_DRIVE_CMD:
 	{
 		u8 drive_command[4];

Signature · 1 line

1.7.1