xfstest: Cleanup test permission and gitignore state.
PATCH 1/1 xfstest: Cleanup test permission and gitignore state.
The new test 284/285/286 do not have execute permission set so set them. Also test 285 and 286 create 2 executable that are not in .gitignore so add then to the list.
.gitignore +2 -0
@@ -88,6 +88,8 @@ src/aio-dio-regress/aio-dio-subblock-eof-read src/aio-dio-regress/aio-free-ring-with-bogus-nr-pages src/aio-dio-regress/aio-io-setup-with-nonwritable-context-pointer src/aio-dio-regress/aiodio_sparse2 +src/seek_copy_test +src/seek_sanity_test dmapi/src/common/cmd/read_invis dmapi/src/common/cmd/set_region
284 +0 -0
285 +0 -0
286 +0 -0
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 6 lines · Alain Renaud
The new test 284/285/286 do not have execute permission set so set them. Also test 285 and 286 create 2 executable that are not in .gitignore so add then to the list.
Signed-off-by Alain Renaud <[email protected]>
Looks good to me,
I wonder if we can embed something in the ./check script to check executable state and fail if not set - we check things in w/o execute perms all the time and we're constantly having to fix things up.
It's just tidiness really, but a bit of a pain....
-Eric
Quoted 23 lines
.gitignore +2
-0@@ -88,6 +88,8 @@ src/aio-dio-regress/aio-dio-subblock-eof-read src/aio-dio-regress/aio-free-ring-with-bogus-nr-pages src/aio-dio-regress/aio-io-setup-with-nonwritable-context-pointer src/aio-dio-regress/aiodio_sparse2 +src/seek_copy_test +src/seek_sanity_test dmapi/src/common/cmd/read_invis dmapi/src/common/cmd/set_region284 +0
-0285 +0
-0286 +0
-0
Quoted 4 lines
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Thanks Eric,
I just also notice that the 284.full 285.full and 286.full should be remove as we do not maintain those file in tree... I do like the idea of the check script I will look into it.
Thanks.
Quoted 47 lines · Eric Sandeen
Quoted 5 lines · Alain Renaud
The new test 284/285/286 do not have execute permission set so set them. Also test 285 and 286 create 2 executable that are not in .gitignore so add then to the list.
Signed-off-by Alain Renaud<[email protected]>Looks good to me,
Reviewed-by Eric Sandeen<[email protected]>I wonder if we can embed something in the ./check script to check executable state and fail if not set - we check things in w/o execute perms all the time and we're constantly having to fix things up.
It's just tidiness really, but a bit of a pain....
-Eric
Quoted 23 lines
.gitignore +2
-0@@ -88,6 +88,8 @@ src/aio-dio-regress/aio-dio-subblock-eof-read src/aio-dio-regress/aio-free-ring-with-bogus-nr-pages src/aio-dio-regress/aio-io-setup-with-nonwritable-context-pointer src/aio-dio-regress/aiodio_sparse2 +src/seek_copy_test +src/seek_sanity_test dmapi/src/common/cmd/read_invis dmapi/src/common/cmd/set_region284 +0
-0285 +0
-0286 +0
-0Quoted 4 lines
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Signature · 9 lines
=============================================== Alain Renaud - Cluster File System Engineer [email protected] - SGI =============================================== _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
Re: [PATCH] xfstest: Cleanup test permission and gitignore state. V2
Here is version 2 of the patch.
The new test 284/285/286 do not have execute permission set so set
them. Test 285 and 286 create 2 executable that are not in .gitignore so add then to the list. Finally 285.full and 286.full should be remove.
--- .gitignore | 2 + 285.full | 116 ------------------------------------------------------------ 286.full | 70 ------------------------------------ 3 files changed, 2 insertions(+), 186 deletions(-) mode change 100644 => 100755 284 mode change 100644 => 100755 285 delete mode 100644 285.full mode change 100644 => 100755 286 delete mode 100644 286.full
.gitignore +2 -0
@@ -63,6 +63,8 @@ src/rename src/resvtest src/runas src/stale_handle +src/seek_copy_test +src/seek_sanity_test src/t_access_root src/t_dir_offset src/t_dir_offset2
284 +0 -0
285 +0 -0
285.full deleted +0 -116
116 lines not on this page · raw message
286 +0 -0
286.full deleted +0 -70
70 lines not on this page · raw message
Signature · 6 lines
1.6.0.2 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs