---
 arch/avr32/lib/board.c |    1 -
 arch/m68k/lib/board.c  |    1 -
 arch/mips/lib/board.c  |    1 -
 arch/nds32/lib/board.c |    2 --
 arch/sparc/lib/board.c |    1 -
 include/malloc.h       |    1 +
 6 files changed, 1 insertion(+), 6 deletions(-)

arch/avr32/lib/board.c +0 -1

index b390a6c..676f358 100644
@@ -250,7 +250,6 @@ void board_init_f(ulong board_type)
 
 void board_init_r(gd_t *new_gd, ulong dest_addr)
 {
-	extern void malloc_bin_reloc (void);
 #ifndef CONFIG_ENV_IS_NOWHERE
 	extern char * env_name_spec;
 #endif

arch/m68k/lib/board.c +0 -1

index 65a8595..2add630 100644
@@ -389,7 +389,6 @@ void board_init_r (gd_t *id, ulong dest_addr)
 {
 	char *s;
 	bd_t *bd;
-	extern void malloc_bin_reloc (void);
 
 #ifndef CONFIG_ENV_IS_NOWHERE
 	extern char * env_name_spec;

arch/mips/lib/board.c +0 -1

index 59a8001..6a71a6b 100644
@@ -255,7 +255,6 @@ void board_init_r(gd_t *id, ulong dest_addr)
 #ifndef CONFIG_SYS_NO_FLASH
 	ulong size;
 #endif
-	extern void malloc_bin_reloc(void);
 #ifndef CONFIG_ENV_IS_NOWHERE
 	extern char *env_name_spec;
 #endif

arch/nds32/lib/board.c +0 -2

index 7121313..d834975 100644
@@ -305,8 +305,6 @@ void board_init_r(gd_t *id, ulong dest_addr)
 	bd_t *bd;
 	ulong malloc_start;
 
-	extern void malloc_bin_reloc(void);
-
 	gd = id;
 	bd = gd->bd;

arch/sparc/lib/board.c +0 -1

index 7e48775..b836cf5 100644
@@ -62,7 +62,6 @@ DECLARE_GLOBAL_DATA_PTR;
 */
 
 extern void timer_interrupt_init(void);
-extern void malloc_bin_reloc(void);
 extern int do_ambapp_print(cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[]);
 extern int prom_init(void);

include/malloc.h +1 -0

index ecf3c67..6543f4a 100644
@@ -937,6 +937,7 @@ extern ulong mem_malloc_end;
 extern ulong mem_malloc_brk;
 
 void mem_malloc_init(ulong start, ulong size);
+void malloc_bin_reloc(void);
 
 #ifdef __cplusplus
 };  /* end of extern "C" */

Signature · 1 line

1.7.10

Andreas Bießmann

2012-06-04 07:07 UTC #1 lore raw

PATCH 1/1 malloc: remove extern declarations of malloc_bin_reloc() in board.c files

Dear Daniel Schwierzeck,

Quoted 6 lines · Daniel Schwierzeck

Declare malloc_bin_reloc() in malloc.h and remove all extern declarations in various board.c files to get rid of one checkpatch.pl warning.
Signed-off-by Daniel Schwierzeck <[email protected]>
Cc Wolfgang Denk <[email protected]>
Cc Andreas Bie?mann <[email protected]>

Acked-by Andreas Bie?mann <[email protected]>

Quoted 11 lines

Cc Jason Jin <[email protected]>

Cc Macpaul Lin <[email protected]>

Cc Daniel Hellstrom <[email protected]>

---
 arch/avr32/lib/board.c |    1 -
 arch/m68k/lib/board.c  |    1 -
 arch/mips/lib/board.c  |    1 -
 arch/nds32/lib/board.c |    2 --
 arch/sparc/lib/board.c |    1 -
 include/malloc.h       |    1 +
 6 files changed, 1 insertion(+), 6 deletions(-)

Tom Rini

2012-09-27 16:21 UTC #2 lore raw

In reply to Daniel Schwierzeck

Quoted 10 lines · Daniel Schwierzeck

Declare malloc_bin_reloc() in malloc.h and remove all extern declarations in various board.c files to get rid of one checkpatch.pl warning.
Signed-off-by Daniel Schwierzeck <[email protected]>
Cc Wolfgang Denk <[email protected]>
Cc Andreas Bie?mann <[email protected]>
Cc Jason Jin <[email protected]>
Cc Macpaul Lin <[email protected]>
Cc Daniel Hellstrom <[email protected]>
Acked-by Andreas Bie?mann <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120927/7b7ec0ef/attachment.pgp>