Skip to contentSkip to conversation

iio: frequency: adf4350: fix an initialization

PATCH In review Dan Carpenter 2 participants 2 messages Jun 8, 2012

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 2/2 iio: frequency: adf4350: fix an initialization

Sparse complains about this:
drivers/iio/frequency/adf4350.c:58:29: warning: Initializer entry defined twice
drivers/iio/frequency/adf4350.c:59:10: also defined here

It looks like '|' was intended here instead of ','.

---
Guess work on my part.

drivers/iio/frequency/adf4350.c +1 -1
index 4729bba..59fbb3ae 100644
@@ -54,7 +54,7 @@ struct adf4350_state {
 static struct adf4350_platform_data default_pdata = {
 	.clkin = 122880000,
 	.channel_spacing = 10000,
-	.r2_user_settings = ADF4350_REG2_PD_POLARITY_POS,
+	.r2_user_settings = ADF4350_REG2_PD_POLARITY_POS |
 			    ADF4350_REG2_CHARGE_PUMP_CURR_uA(2500),
 	.r3_user_settings = ADF4350_REG3_12BIT_CLKDIV_MODE(0),
 	.r4_user_settings = ADF4350_REG4_OUTPUT_PWR(3) |
maintainer Acked-by on v1 2/2
#1 lore raw
Quoted 7 lines · Dan Carpenter

Sparse complains about this:
drivers/iio/frequency/adf4350.c:58:29: warning: Initializer entry defined twice
drivers/iio/frequency/adf4350.c:59:10: also defined here

It looks like '|' was intended here instead of ','.

Quoted 17 lines

---
Guess work on my part.

drivers/iio/frequency/adf4350.c +1 -1
index 4729bba..59fbb3ae 100644
@@ -54,7 +54,7 @@ struct adf4350_state {
  static struct adf4350_platform_data default_pdata = {
  	.clkin = 122880000,
  	.channel_spacing = 10000,
-	.r2_user_settings = ADF4350_REG2_PD_POLARITY_POS,
+	.r2_user_settings = ADF4350_REG2_PD_POLARITY_POS |
  			    ADF4350_REG2_CHARGE_PUMP_CURR_uA(2500),
  	.r3_user_settings = ADF4350_REG3_12BIT_CLKDIV_MODE(0),
  	.r4_user_settings = ADF4350_REG4_OUTPUT_PWR(3) |
Signature · 8 lines
Greetings,
Michael

--
Analog Devices GmbH      Wilhelm-Wagenfeld-Str. 6      80807 Muenchen
Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368;
Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin,
Margaret Seif