Skip to contentSkip to conversation

xfs: use INIT_WORK_ONSTACK in xfs_alloc_vextent()

PATCH In review Eric Sandeen 3 participants 4 messages Jun 8, 2012 XFS filesystem

lore
Share & tools
lore

Eric Sandeen

author
#0 lore raw

PATCH 1/1 xfs: use INIT_WORK_ONSTACK in xfs_alloc_vextent()

w/o this change I was getting:

[  742.376495] ODEBUG: object is on stack, but not annotated
[  742.377007] ------------[ cut here ]------------
[  742.377007] WARNING: at lib/debugobjects.c:302 __debug_object_init+0x1c0/0x3d0()
...
[  742.377007] Call Trace:
[  742.377007]  [<ffffffff81060dbf>] warn_slowpath_common+0x7f/0xc0
[  742.377007]  [<ffffffff81060e1a>] warn_slowpath_null+0x1a/0x20
[  742.377007]  [<ffffffff81336640>] __debug_object_init+0x1c0/0x3d0
[  742.377007]  [<ffffffff8133689f>] debug_object_init+0x1f/0x30
[  742.377007]  [<ffffffff81081cd9>] __init_work+0x19/0x30
[  742.377007]  [<ffffffffa0299f81>] xfs_alloc_vextent+0x101/0x190 [xfs]

on a debug 3.4 kernel.

Signed-off-by Eric Sandeen <[email protected]>

---

I think it's right? :)

fs/xfs/xfs_alloc.c +1 -1
index 0f0df27..0be396d 100644
@@ -2443,7 +2443,7 @@ xfs_alloc_vextent(
 	DECLARE_COMPLETION_ONSTACK(done);
 
 	args->done = &done;
-	INIT_WORK(&args->work, xfs_alloc_vextent_worker);
+	INIT_WORK_ONSTACK(&args->work, xfs_alloc_vextent_worker);
 	queue_work(xfs_alloc_wq, &args->work);
 	wait_for_completion(&done);
 	return args->result;

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Reviewed-by on v1 1/1
#1 lore raw
Quoted 14 lines · Eric Sandeen

w/o this change I was getting:

[  742.376495] ODEBUG: object is on stack, but not annotated
[  742.377007] ------------[ cut here ]------------
[  742.377007] WARNING: at lib/debugobjects.c:302 __debug_object_init+0x1c0/0x3d0()
...
[  742.377007] Call Trace:
[  742.377007]  [<ffffffff81060dbf>] warn_slowpath_common+0x7f/0xc0
[  742.377007]  [<ffffffff81060e1a>] warn_slowpath_null+0x1a/0x20
[  742.377007]  [<ffffffff81336640>] __debug_object_init+0x1c0/0x3d0
[  742.377007]  [<ffffffff8133689f>] debug_object_init+0x1f/0x30
[  742.377007]  [<ffffffff81081cd9>] __init_work+0x19/0x30
[  742.377007]  [<ffffffffa0299f81>] xfs_alloc_vextent+0x101/0x190 [xfs]
Quoted 3 lines

on a debug 3.4 kernel.

Signed-off-by Eric Sandeen <[email protected]>

Looks pretty good. ;)

Reviewed-by Ben Myers <[email protected]>

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#2 lore raw
In reply to Eric Sandeen
Quoted 14 lines · Eric Sandeen

w/o this change I was getting:

[  742.376495] ODEBUG: object is on stack, but not annotated
[  742.377007] ------------[ cut here ]------------
[  742.377007] WARNING: at lib/debugobjects.c:302 __debug_object_init+0x1c0/0x3d0()
...
[  742.377007] Call Trace:
[  742.377007]  [<ffffffff81060dbf>] warn_slowpath_common+0x7f/0xc0
[  742.377007]  [<ffffffff81060e1a>] warn_slowpath_null+0x1a/0x20
[  742.377007]  [<ffffffff81336640>] __debug_object_init+0x1c0/0x3d0
[  742.377007]  [<ffffffff8133689f>] debug_object_init+0x1f/0x30
[  742.377007]  [<ffffffff81081cd9>] __init_work+0x19/0x30
[  742.377007]  [<ffffffffa0299f81>] xfs_alloc_vextent+0x101/0x190 [xfs]
Quoted 3 lines

on a debug 3.4 kernel.

Signed-off-by Eric Sandeen <[email protected]>

Already posted by Jeff twice - I picked this up and started testing it a couple of days ago:

http://marc.info/?l=linux-fsdevel&m=133877118608852&w=2
http://oss.sgi.com/archives/xfs/2012-06/msg00081.html

Sorry to burst you bubble, Eric, but I think Jeff gets this one. ;)

Cheers,

Dave.

Signature · 7 lines
Dave Chinner
[email protected]

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
author
#3 lore raw
Quoted 19 lines · Dave Chinner
Quoted 14 lines · Eric Sandeen

w/o this change I was getting:

[  742.376495] ODEBUG: object is on stack, but not annotated
[  742.377007] ------------[ cut here ]------------
[  742.377007] WARNING: at lib/debugobjects.c:302 __debug_object_init+0x1c0/0x3d0()
...
[  742.377007] Call Trace:
[  742.377007]  [<ffffffff81060dbf>] warn_slowpath_common+0x7f/0xc0
[  742.377007]  [<ffffffff81060e1a>] warn_slowpath_null+0x1a/0x20
[  742.377007]  [<ffffffff81336640>] __debug_object_init+0x1c0/0x3d0
[  742.377007]  [<ffffffff8133689f>] debug_object_init+0x1f/0x30
[  742.377007]  [<ffffffff81081cd9>] __init_work+0x19/0x30
[  742.377007]  [<ffffffffa0299f81>] xfs_alloc_vextent+0x101/0x190 [xfs]
Quoted 3 lines

on a debug 3.4 kernel.

Signed-off-by Eric Sandeen <[email protected]>
Quoted 7 lines

Already posted by Jeff twice - I picked this up and started testing it a couple of days ago:

http://marc.info/?l=linux-fsdevel&m=133877118608852&w=2
http://oss.sgi.com/archives/xfs/2012-06/msg00081.html

Sorry to burst you bubble, Eric, but I think Jeff gets this one. ;)

sigh. Can't keep up. But I try!

-Eric

Quoted 3 lines

Cheers,

Dave.

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs