synergy: Remove -Werror from CXXFLAGS

---
 package/synergy/synergy-1.3.1-remove-werror.patch |   29 +++++++++++++++++++++
 1 files changed, 29 insertions(+), 0 deletions(-)
 create mode 100644 package/synergy/synergy-1.3.1-remove-werror.patch

new file mode 100644
index 0000000..fe55778
@@ -0,0 +1,29 @@
+Remove -Werror from CXXFLAGS
+
+Signed-off-by: Markos Chandras <[email protected]>
+
+Index: synergy-1.3.1/configure
+===================================================================
+--- synergy-1.3.1.orig/configure
++++ synergy-1.3.1/configure
+@@ -10835,20 +10835,6 @@ echo $ECHO_N "checking for C++ compiler 
+ echo "${ECHO_T}$acx_cxx_warnings" >&6
+ 
+ 
+-	echo "$as_me:$LINENO: checking for C++ compiler warning are errors flags" >&5
+-echo $ECHO_N "checking for C++ compiler warning are errors flags... $ECHO_C" >&6
+-	if test "$GXX" = "yes"; then
+-		acx_cxx_warnings_are_errors="-Werror"
+-	fi
+-	if test -n "$acx_cxx_warnings_are_errors"; then
+-		CXXFLAGS="$CXXFLAGS $acx_cxx_warnings_are_errors"
+-	else
+-		acx_cxx_warnings_are_errors="unknown"
+-	fi
+-	echo "$as_me:$LINENO: result: $acx_cxx_warnings_are_errors" >&5
+-echo "${ECHO_T}$acx_cxx_warnings_are_errors" >&6
+-
+-
+ CXXFLAGS="$CXXFLAGS $SYNERGY_CXXFLAGS $ARCH_CFLAGS"
+ OBJCXXFLAGS="$OBJCXXFLAGS $CXXFLAGS $ARCH_CFLAGS"
+ LIBS="$NANOSLEEP_LIBS $INET_ATON_LIBS $ARCH_LIBS $LIBS"

1.7.1

Markos> Signed-off-by: Markos Chandras <[email protected]> Markos> ---

 Markos>  package/synergy/synergy-1.3.1-remove-werror.patch |   29 +++++++++++++++++++++

Markos> 1 files changed, 29 insertions(+), 0 deletions(-) Markos> create mode 100644 package/synergy/synergy-1.3.1-remove-werror.patch

Markos> diff --git a/package/synergy/synergy-1.3.1-remove-werror.patch b/package/synergy/synergy-1.3.1-remove-werror.patch Markos> new file mode 100644
Markos> index 0000000..fe55778
Markos> --- /dev/null
Markos> +++ b/package/synergy/synergy-1.3.1-remove-werror.patch
Markos> @@ -0,0 +1,29 @@
Markos> +Remove -Werror from CXXFLAGS
Markos> +
Markos> +Signed-off-by: Markos Chandras <[email protected]>
Markos> +
Markos> +Index: synergy-1.3.1/configure
Markos> +===================================================================
Markos> +--- synergy-1.3.1.orig/configure
Markos> ++++ synergy-1.3.1/configure

Please patch configure.ac (and ass SYNERGY_AUTORECONF = YES in synergy.mk) instead of the generated configure script.

Out of interest, on what configs do you see warnings? I haven't noticed any build errors on the autobuilder.

Bye, Peter Korsgaard

Hi Peter,

There is no configure.ac in the sources and this is why I patched the generated configure file.

As for the errors, I guess it depends on the toolchain and gcc version that is being used. I am seeing something like this:

cc1plus: warnings being treated as errors
CTCPSocket.cpp: In member function 'virtual void CTCPSocket::write(const void*, UInt32)':
CTCPSocket.cpp:143: warning: 'wasEmpty' may be used uninitialized in this function

markos

Hi,

Markos> There is no configure.ac in the sources and this is why I patched the Markos> generated configure file.

True, but there's configure.in (the old name for configure.ac).

Markos> As for the errors, I guess it depends on the toolchain and gcc Markos> version that is being used. I am seeing something like this:

Markos> cc1plus: warnings being treated as errors CTCPSocket.cpp: In Markos> member function 'virtual void CTCPSocket::write(const void*, Markos> UInt32)': CTCPSocket.cpp:143: warning: 'wasEmpty' may be used Markos> uninitialized in this function

Ok, thanks.

Bye, Peter Korsgaard

Hi Peter,

Ok I will prepare a new patch

markos

Le Mon, 11 Jun 2012 09:08:04 +0100,
Markos Chandras <[email protected]> a ?crit :

The file is named configure.in. This is the one that should be modified, and the package marked SYNERGY_AUTORECONF = YES. The configure shell script is generated by autoconf from configure.in (or sometimes configure.ac), and therefore should preferably not be modified directly.

And precisely which toolchain and gcc version are you using? If it appears that it generates some errors we haven't seen, then we might include it in our automated build tests, to extend their coverage.

Regards,

Thomas

Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com