remove snb rc6 patches from v3.4 kernel repository
cover remove snb rc6 patches from v3.4 kernel repository
From: Nitin A Kamble <[email protected]>
These patches are already part of v3.4 kernel sources. So there is no need to maintain them in the yocto linux 3.4 repository.
Thanks,
Nitin
The following changes since commit 3fd089debe624c642d7b4d9363f853021d1675b2:
checkpoint dir: meta (2012-06-06 16:24:42 -0400)
are available in the git repository at:
git://git.yoctoproject.org/linux-yocto-2.6.37-contrib nitin/meta
http://git.yoctoproject.org/cgit.cgi/linux-yocto-2.6.37-contrib/log/?h=nitin/meta
Nitin A Kamble (1):
rc6: remove rc6 patches for snb
.../features/tmp/rc6/rc6-kernel-params.patch | 81 -------------------- meta/cfg/kernel-cache/features/tmp/rc6/rc6.scc | 5 - .../tmp/rc6/snb-disable-rc6p-fix-precedence.patch | 26 ------ .../features/tmp/rc6/snb-disable-rc6p.patch | 39 ---------- .../features/tmp/rc6/snb-enable-rc6.patch | 54 ------------- 5 files changed, 0 insertions(+), 205 deletions(-) delete mode 100644 meta/cfg/kernel-cache/features/tmp/rc6/rc6-kernel-params.patch delete mode 100644 meta/cfg/kernel-cache/features/tmp/rc6/rc6.scc delete mode 100644 meta/cfg/kernel-cache/features/tmp/rc6/snb-disable-rc6p-fix-precedence.patch delete mode 100644 meta/cfg/kernel-cache/features/tmp/rc6/snb-disable-rc6p.patch delete mode 100644 meta/cfg/kernel-cache/features/tmp/rc6/snb-enable-rc6.patch
Signature · 1 line
1.7.3.4
PATCH 1/1 rc6: remove rc6 patches for snb
From: Nitin A Kamble <[email protected]>
The sandybridge rc6 patches are part of the released v3.4 kernel. Hence there is no need to keep these patches in the 3.4 linux yocto kernel repository.
--- .../features/tmp/rc6/rc6-kernel-params.patch | 81 -------------------- meta/cfg/kernel-cache/features/tmp/rc6/rc6.scc | 5 - .../tmp/rc6/snb-disable-rc6p-fix-precedence.patch | 26 ------ .../features/tmp/rc6/snb-disable-rc6p.patch | 39 ---------- .../features/tmp/rc6/snb-enable-rc6.patch | 54 ------------- 5 files changed, 0 insertions(+), 205 deletions(-) delete mode 100644 meta/cfg/kernel-cache/features/tmp/rc6/rc6-kernel-params.patch delete mode 100644 meta/cfg/kernel-cache/features/tmp/rc6/rc6.scc delete mode 100644 meta/cfg/kernel-cache/features/tmp/rc6/snb-disable-rc6p-fix-precedence.patch delete mode 100644 meta/cfg/kernel-cache/features/tmp/rc6/snb-disable-rc6p.patch delete mode 100644 meta/cfg/kernel-cache/features/tmp/rc6/snb-enable-rc6.patch
meta/cfg/kernel-cache/features/tmp/rc6/rc6-kernel-params.patch deleted +0 -81
@@ -1,81 +0,0 @@ -From 83b7f9ac9126f0532ca34c14e4f0582c565c6b0d Mon Sep 17 00:00:00 2001 -From: Eugeni Dodonov <[email protected]> -Date: Fri, 23 Mar 2012 11:57:18 -0300 -Subject: [PATCH] drm/i915: allow to select rc6 modes via kernel parameter - -This allows to select which rc6 modes are to be used via kernel parameter, -via a bitmask parameter. E.g.: - -- to enable rc6, i915_enable_rc6=1 -- to enable rc6 and deep rc6, i915_enable_rc6=3 -- to enable rc6 and deepest rc6, use i915_enable_rc6=5 -- to enable rc6, deep and deepest rc6, use i915_enable_rc6=7 - -Please keep in mind that the deepest RC6 state really should NOT be used -by default, as it could potentially worsen the issues with deep RC6. So do -enable it only when you know what you are doing. However, having it around -could help solving possible future rc6-related issues and their debugging -on user machines. - -Note that this changes behavior - previously, value of 1 would enable both -RC6 and deep RC6. Now it should only enable RC6 and deep/deepest RC6 -stages must be enabled manually. - -v2: address Chris Wilson comments and clean up the code. - -References: https://bugs.freedesktop.org/show_bug.cgi?id=42579 -Reviewed-by: Chris Wilson <[email protected]> -Reviewed-by: Ben Widawsky <[email protected]> -Signed-off-by: Eugeni Dodonov <[email protected]> -Signed-off-by: Daniel Vetter <[email protected]> -Integrated-by: Tom Zanussi <[email protected]> - -Index: linux/drivers/gpu/drm/i915/i915_drv.c -=================================================================== ---- linux.orig/drivers/gpu/drm/i915/i915_drv.c 2012-05-24 15:21:16.216263416 -0500 -+++ linux/drivers/gpu/drm/i915/i915_drv.c 2012-05-24 15:21:42.386496572 -0500 -@@ -66,7 +66,11 @@ - int i915_enable_rc6 __read_mostly = -1; - module_param_named(i915_enable_rc6, i915_enable_rc6, int, 0600); - MODULE_PARM_DESC(i915_enable_rc6, -- "Enable power-saving render C-state 6 (default: -1 (use per-chip default)"); -+ "Enable power-saving render C-state 6. " -+ "Different stages can be selected via bitmask values " -+ "(0 = disable; 1 = enable rc6; 2 = enable deep rc6; 4 = enable deepest rc6). " -+ "For example, 3 would enable rc6 and deep rc6, and 7 would enable everything. " -+ "default: -1 (use per-chip default)"); - - int i915_enable_fbc __read_mostly = -1; - module_param_named(i915_enable_fbc, i915_enable_fbc, int, 0600); -Index: linux/drivers/gpu/drm/i915/i915_drv.h -=================================================================== ---- linux.orig/drivers/gpu/drm/i915/i915_drv.h 2012-05-24 15:21:23.926268189 -0500 -+++ linux/drivers/gpu/drm/i915/i915_drv.h 2012-05-24 15:21:42.396308725 -0500 -@@ -1003,6 +1003,27 @@ - - #include "i915_trace.h" - -+/** -+ * RC6 is a special power stage which allows the GPU to enter an very -+ * low-voltage mode when idle, using down to 0V while at this stage. This -+ * stage is entered automatically when the GPU is idle when RC6 support is -+ * enabled, and as soon as new workload arises GPU wakes up automatically as well. -+ * -+ * There are different RC6 modes available in Intel GPU, which differentiate -+ * among each other with the latency required to enter and leave RC6 and -+ * voltage consumed by the GPU in different states. -+ * -+ * The combination of the following flags define which states GPU is allowed -+ * to enter, while RC6 is the normal RC6 state, RC6p is the deep RC6, and -+ * RC6pp is deepest RC6. Their support by hardware varies according to the -+ * GPU, BIOS, chipset and platform. RC6 is usually the safest one and the one -+ * which brings the most power savings; deeper states save more power, but -+ * require higher latency to switch to and wake up. -+ */ -+#define INTEL_RC6_ENABLE (1<<0) -+#define INTEL_RC6p_ENABLE (1<<1) -+#define INTEL_RC6pp_ENABLE (1<<2) -+ - extern struct drm_ioctl_desc i915_ioctls[]; - extern int i915_max_ioctl; - extern unsigned int i915_fbpercrtc __always_unused;
meta/cfg/kernel-cache/features/tmp/rc6/rc6.scc deleted +0 -5
@@ -1,5 +0,0 @@ -patch snb-disable-rc6p.patch -patch snb-disable-rc6p-fix-precedence.patch -patch rc6-kernel-params.patch -patch snb-enable-rc6.patch -
meta/cfg/kernel-cache/features/tmp/rc6/snb-disable-rc6p-fix-precedence.patch deleted +0 -26
@@ -1,26 +0,0 @@ -From c0e2ee1bc0cf82eec89e26b7afe7e4db0561b7d9 Mon Sep 17 00:00:00 2001 -From: Eugeni Dodonov <[email protected]> -Date: Thu, 23 Feb 2012 23:57:06 -0200 -Subject: [PATCH] drm/i915: fix operator precedence when enabling RC6p - -As noticed by Torsten Kaiser, the operator precedence can play tricks with -us here. - -CC: Dave Airlie <[email protected]> -Signed-off-by: Eugeni Dodonov <[email protected]> -Signed-off-by: Jesse Barnes <[email protected]> -Integrated-by: Tom Zanussi <[email protected]> - -Index: linux/drivers/gpu/drm/i915/intel_display.c -=================================================================== ---- linux.orig/drivers/gpu/drm/i915/intel_display.c 2012-05-24 15:20:19.456911719 -0500 -+++ linux/drivers/gpu/drm/i915/intel_display.c 2012-05-24 15:20:27.786724609 -0500 -@@ -7970,7 +7970,7 @@ - - if (intel_enable_rc6(dev_priv->dev)) - rc6_mask = GEN6_RC_CTL_RC6_ENABLE | -- (IS_GEN7(dev_priv->dev)) ? GEN6_RC_CTL_RC6p_ENABLE : 0; -+ ((IS_GEN7(dev_priv->dev)) ? GEN6_RC_CTL_RC6p_ENABLE : 0); - - I915_WRITE(GEN6_RC_CONTROL, - rc6_mask |
meta/cfg/kernel-cache/features/tmp/rc6/snb-disable-rc6p.patch deleted +0 -39
@@ -1,39 +0,0 @@ -From 1c8ecf80fdee4e7b23a9e7da7ff9bd59ba2dcf96 Mon Sep 17 00:00:00 2001 -From: Eugeni Dodonov <[email protected]> -Date: Tue, 14 Feb 2012 11:44:48 -0200 -Subject: [PATCH] drm/i915: do not enable RC6p on Sandy Bridge - -With base on latest findings, RC6p seems to be respondible for RC6-related -issues on Sandy Bridge platform. To work-around those issues, the previous -solution was to completely disable RC6 on Sandy Bridge for the past few -releases, even if plain RC6 was not giving any issues. - -What this patch does is preventing RC6p from being enabled on Sandy Bridge -even if users enable RC6 via a kernel parameter. So it won't change the -defaults in any way, but will ensure that if users do enable RC6 manually -it won't break their machines by enabling this extra state. - -Proper fix for this (enabling specific RC6 states according to the GPU -generation) were proposed for the -next kernel, but we are too late in the -release process now to pick such changes. - -Acked-by: Keith Packard <[email protected]> -Signed-off-by: Eugeni Dodonov <[email protected]> -Signed-off-by: Jesse Barnes <[email protected]> -Integrated-by: Tom Zanussi <[email protected]> - -Index: linux/drivers/gpu/drm/i915/intel_display.c -=================================================================== ---- linux.orig/drivers/gpu/drm/i915/intel_display.c 2012-05-24 14:35:19.446261789 -0500 -+++ linux/drivers/gpu/drm/i915/intel_display.c 2012-05-24 14:35:44.906278169 -0500 -@@ -7969,8 +7969,8 @@ - I915_WRITE(GEN6_RC6pp_THRESHOLD, 64000); /* unused */ - - if (intel_enable_rc6(dev_priv->dev)) -- rc6_mask = GEN6_RC_CTL_RC6p_ENABLE | -- GEN6_RC_CTL_RC6_ENABLE; -+ rc6_mask = GEN6_RC_CTL_RC6_ENABLE | -+ (IS_GEN7(dev_priv->dev)) ? GEN6_RC_CTL_RC6p_ENABLE : 0; - - I915_WRITE(GEN6_RC_CONTROL, - rc6_mask |
meta/cfg/kernel-cache/features/tmp/rc6/snb-enable-rc6.patch deleted +0 -54
54 lines not on this page · raw message
Signature · 1 line
1.7.3.4
Quoted 4 lines · On 12-06-11 03:38 PM, [email protected] wrote:
From: Nitin A Kamble<[email protected]>
These patches are already part of v3.4 kernel sources. So there is no need to maintain them in the yocto linux 3.4 repository.
dropped. They obviously weren't reference anyway.
I assume you'll be doing an associated meta-intel commit to remove the reference in:
./meta-sugarbay/recipes-kernel/linux/linux-yocto_3.2.bbappend
Cheers,
Bruce
Quoted 27 lines
Thanks,
NitinThe following changes since commit
3fd089debe624c642d7b4d9363f853021d1675b2:checkpoint dir: meta (2012-06-06 16:24:42 -0400)are available in the git repository at:
git://git.yoctoproject.org/linux-yocto-2.6.37-contrib nitin/meta http://git.yoctoproject.org/cgit.cgi/linux-yocto-2.6.37-contrib/log/?h=nitin/metaNitin A Kamble (1):
rc6: remove rc6 patches for snb.../features/tmp/rc6/rc6-kernel-params.patch | 81 -------------------- meta/cfg/kernel-cache/features/tmp/rc6/rc6.scc | 5 - .../tmp/rc6/snb-disable-rc6p-fix-precedence.patch | 26 ------ .../features/tmp/rc6/snb-disable-rc6p.patch | 39 ---------- .../features/tmp/rc6/snb-enable-rc6.patch | 54 ------------- 5 files changed, 0 insertions(+), 205 deletions(-)delete mode 100644
meta/cfg/kernel-cache/features/tmp/rc6/rc6-kernel-params.patchdelete mode 100644 meta/cfg/kernel-cache/features/tmp/rc6/rc6.scc
delete mode 100644meta/cfg/kernel-cache/features/tmp/rc6/snb-disable-rc6p-fix-precedence.patchdelete mode 100644meta/cfg/kernel-cache/features/tmp/rc6/snb-disable-rc6p.patchdelete mode 100644meta/cfg/kernel-cache/features/tmp/rc6/snb-enable-rc6.patch
Quoted 16 lines
-----Original Message-----
From: Bruce Ashfield [mailto:[email protected]]
Sent: Monday, June 11, 2012 1:20 PM
To: Kamble, Nitin A
Cc: [email protected]
Subject: Re: [yocto] [PATCH 0/1] remove snb rc6 patches from v3.4 kernel repositoryQuoted 4 lines · On 12-06-11 03:38 PM, [email protected] wrote:
From: Nitin A Kamble<[email protected]>
These patches are already part of v3.4 kernel sources. So there is no need to maintain them in the yocto linux 3.4 repository.
Quoted 7 lines
dropped. They obviously weren't reference anyway.
I assume you'll be doing an associated meta-intel commit to remove the reference in:
./meta-sugarbay/recipes-kernel/linux/linux-yocto_3.2.bbappend
Bruce,
I think these rc6 patches are still needed for linux-yocto_3.2.bbappend. And they are referenced in the sugarbay bsp 3.2 Yocto kernel as you note above. The commit I sent is for for v3.4 yocto kernel tree. Are you saying about dropping rc6 patches from the 3.2 kernel tree as well?
Nitin
Quoted 38 lines
Cheers,
Bruce
Quoted 5 lines
Thanks,
NitinThe following changes since commit
3fd089debe624c642d7b4d9363f853021d1675b2:Quoted 12 lines
checkpoint dir: meta (2012-06-06 16:24:42 -0400)are available in the git repository at:
git://git.yoctoproject.org/linux-yocto-2.6.37-contribnitin/metahttp://git.yoctoproject.org/cgit.cgi/linux-yocto-2.6.37-contrib/log/?h
=nitin/metaNitin A Kamble (1):
rc6: remove rc6 patches for snbQuoted 7 lines
.../features/tmp/rc6/rc6-kernel-params.patch | 81 -------------------- meta/cfg/kernel-cache/features/tmp/rc6/rc6.scc | 5 - .../tmp/rc6/snb-disable-rc6p-fix-precedence.patch | 26 ------ .../features/tmp/rc6/snb-disable-rc6p.patch | 39 ---------- .../features/tmp/rc6/snb-enable-rc6.patch | 54 ------------- 5 files changed, 0 insertions(+), 205 deletions(-)delete mode 100644 meta/cfg/kernel-cache/features/tmp/rc6/rc6-
kernel-params.patch
Quoted 2 lines
delete mode 100644 meta/cfg/kernel-cache/features/tmp/rc6/rc6.scc delete mode 100644 meta/cfg/kernel-cache/features/tmp/rc6/snb-
disable-rc6p-fix-precedence.patch
Quoted 1 line
delete mode 100644 meta/cfg/kernel-cache/features/tmp/rc6/snb-
disable-rc6p.patch
Quoted 3 lines
delete mode 100644
meta/cfg/kernel-cache/features/tmp/rc6/snb-enable-rc6.patch
Quoted 18 lines · Nitin A
Quoted 18 lines
-----Original Message-----
From: Bruce Ashfield [mailto:[email protected]]
Sent: Monday, June 11, 2012 1:20 PM
To: Kamble, Nitin A
Cc: [email protected]
Subject: Re: [yocto] [PATCH 0/1] remove snb rc6 patches from v3.4 kernel repositoryQuoted 4 lines · On 12-06-11 03:38 PM, [email protected] wrote:
From: Nitin A Kamble<[email protected]>
These patches are already part of v3.4 kernel sources. So there is no need to maintain them in the yocto linux 3.4 repository.
dropped. They obviously weren't reference anyway.
Quoted 8 lines
Quoted 5 lines
I assume you'll be doing an associated meta-intel commit to remove the reference in:
./meta-sugarbay/recipes-kernel/linux/linux-yocto_3.2.bbappend
Bruce,
I think these rc6 patches are still needed for linux-yocto_3.2.bbappend. And they are referenced in the sugarbay bsp 3.2 Yocto kernel as you note above. The commit I sent is for for v3.4 yocto kernel tree.
Yes, of course it's for 3.4 .. that's where I merged it :)
http://git.yoctoproject.org/cgit/cgit.cgi/linux-yocto-3.4/log/?h=meta
Quoted 1 line
Are you saying about dropping rc6 patches from the 3.2 kernel tree as well?
I was more reminding for any updates to the BSP to 3.4 .. i.e. don't forget to drop
it from the recipes when updating, sine it will thrown an error during patching.
Cheers,
Bruce
Quoted 46 lines
Nitin
Quoted 29 lines
Cheers,
Bruce
Quoted 5 lines
Thanks,
NitinThe following changes since commit
3fd089debe624c642d7b4d9363f853021d1675b2:Quoted 12 lines
checkpoint dir: meta (2012-06-06 16:24:42 -0400)
are available in the git repository at:
git://git.yoctoproject.org/linux-yocto-2.6.37-contrib nitin/metahttp://git.yoctoproject.org/cgit.cgi/linux-yocto-2.6.37-contrib/log/?h
=nitin/metaNitin A Kamble (1):
rc6: remove rc6 patches for snbQuoted 7 lines
.../features/tmp/rc6/rc6-kernel-params.patch| 81 -------------------- meta/cfg/kernel-cache/features/tmp/rc6/rc6.scc | 5 -.../tmp/rc6/snb-disable-rc6p-fix-precedence.patch| 26 ------.../features/tmp/rc6/snb-disable-rc6p.patch| 39 ----------.../features/tmp/rc6/snb-enable-rc6.patch| 54 -------------5 files changed, 0 insertions(+), 205 deletions(-)delete mode 100644 meta/cfg/kernel-cache/features/tmp/rc6/rc6-
Quoted 9 lines
kernel-params.patch
Quoted 2 lines
delete mode 100644 meta/cfg/kernel-cache/features/tmp/rc6/rc6.scc delete mode 100644 meta/cfg/kernel-cache/features/tmp/rc6/snb-
disable-rc6p-fix-precedence.patch
Quoted 1 line
delete mode 100644 meta/cfg/kernel-cache/features/tmp/rc6/snb-
disable-rc6p.patch
Quoted 3 lines
delete mode 100644
meta/cfg/kernel-cache/features/tmp/rc6/snb-enable-rc6.patch_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto
Signature · 2 lines
"Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end"
Quoted 11 lines
Quoted 2 lines
Bruce,
I think these rc6 patches are still needed for linux-yocto_3.2.bbappend.And they are referenced in the sugarbay bsp 3.2 Yocto kernel as you note above. The commit I sent is for for v3.4 yocto kernel tree.
Yes, of course it's for 3.4 .. that's where I merged it :)
http://git.yoctoproject.org/cgit/cgit.cgi/linux-yocto-3.4/log/?h=meta
Quoted 1 line
Are you saying about dropping rc6 patches from the 3.2 kernel tree as well?
Quoted 7 lines
I was more reminding for any updates to the BSP to 3.4 .. i.e. don't forget to drop it from the recipes when updating, sine it will thrown an error during patching.
Cheers,
Bruce
I see your point now. I have dropped them from 3.4 kernel recipe 1st to avoid patch application errors. Then we realized that these patches are not needed in the v3.4 kernel repository.
Nitin