: Remove redundant #ifdef CONFIG_SPARC64 check
Subsystems (2)
PATCH 1/1 : Remove redundant #ifdef CONFIG_SPARC64 check
From: Sarah Nadi<[email protected]>
Summary: Unnecessary #ifdef check in arch/sparc/kernel/jump_label.c
Problem description: The #ifdef CONFIG_SPARC64 is unnecessary since the file is only compiled when CONFIG_SPARC64 is selected. Leaving it in makes the #ifdef block always selected while the #else block is never selected. Suggested patch to remove unneccesary check below.
Patch:
arch/sparc/kernel/jump_label.c 2012-06-11 16:54:39.000000000 -0400 renamed from arch/sparc/kernel/jump_label.c 2012-06-11 16:51:15.000000000 -0400 +1 -5
@@ -17,13 +17,9 @@ if (type = JUMP_LABEL_ENABLE) { s32 off = (s32)entry->target - (s32)entry->code; -#ifdef CONFIG_SPARC64 /* ba,pt %xcc, . + (off << 2) */ val = 0x10680000 | ((u32) off >> 2); -#else - /* ba . + (off << 2) */ - val = 0x10800000 | ((u32) off >> 2); -#endif + } else { val = 0x01000000; }
David Miller
maintainerFrom: Sarah Nadi <[email protected]>
Date: Mon, 11 Jun 2012 17:12:31 -0400
Quoted 9 lines
From: Sarah Nadi<[email protected]>
Summary: Unnecessary #ifdef check in
arch/sparc/kernel/jump_label.cProblem description: The #ifdef
CONFIG_SPARC64is unnecessary since the file is only compiled whenCONFIG_SPARC64is selected. Leaving it in makes the
#ifdef block always selected while the #else block is never #selected. Suggested patch to remove unneccesary check below.
This is there so that sparc 32-bit support is easy to add for someone so inclined, do not remove this.