Skip to contentSkip to conversation

arm/dts: Add OMAP2420 SDP support

PATCH Superseded Jon Hunter 1 participant 5 messages Jun 13, 2012 Device tree bindings

lore
Share & tools
lore

Jon Hunter

author
#0 lore raw

v3 cover arm/dts: Add OMAP2420 SDP support

This series fixes the OMAP2 interrupt controller binding and adds support for the OMAP2420H4 board. I have verified that the kernel boots with device-tree on this board.

This series is based upon the linux-omap master branch (3.5-rc1).

V3: Rename OMAP2420 SDP to OMAP2420H4
V2: Correct typo in copyright date

Jon Hunter (2):
arm/dts: OMAP2: Add support for OMAP2420H4 Board arm/dts: OMAP2: Fix interrupt controller binding

 arch/arm/boot/dts/omap2.dtsi       |    2 ++
 arch/arm/boot/dts/omap2420-sdp.dts |   20 ++++++++++++++++++++
 2 files changed, 22 insertions(+)
 create mode 100644 arch/arm/boot/dts/omap2420-sdp.dts
Signature · 1 line
1.7.9.5
author
#1 lore raw

PATCH v3 1/2 arm/dts: OMAP2: Add support for OMAP2420H4 Board

Simple DTS file for OMAP2420H4 board adding memory information to allow device-tree testing on an OMAP2420. OMAP2420H4 board has 64MB of RAM.

Verified that kernel boots with DT using a simple RAMDISK file-system on OMAP2420H4.

---
 arch/arm/boot/dts/omap2420-sdp.dts |   20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 arch/arm/boot/dts/omap2420-sdp.dts
arch/arm/boot/dts/omap2420-sdp.dts new file +20 -0
new file mode 100644
index 0000000..2c292c9
@@ -0,0 +1,20 @@
+/*
+ * Copyright (C) 2012 Texas Instruments Incorporated - http://www.ti.com/
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+/dts-v1/;
+
+/include/ "omap2.dtsi"
+
+/ {
+	model = "TI OMAP2420 SDP board";
+	compatible = "ti,omap2-sdp", "ti,omap2420", "ti,omap2";
+
+	memory {
+		device_type = "memory";
+		reg = <0x80000000 0x84000000>; /* 64 MB */
+	};
+};
Signature · 1 line
1.7.9.5
author
#2 lore raw

PATCH v3 2/2 arm/dts: OMAP2: Fix interrupt controller binding

In reply to Jon Hunter

When booting with device-tree on an OMAP2420H4, the kernel is hanging when initialising the interrupts and following kernel dumps is seen ...

[    0.000000] ------------[ cut here ]------------
[    0.000000] WARNING: at arch/arm/mach-omap2/irq.c:271 omap_intc_of_init+0x50/0xb4()
[    0.000000] unable to get intc registers
[    0.000000] Modules linked in:
[    0.000000] [<c001befc>] (unwind_backtrace+0x0/0xf4) from [<c0040c34>] (warn_slowpath_common+0x4c/0x64)
[    0.000000] [<c0040c34>] (warn_slowpath_common+0x4c/0x64) from [<c0040ce0>] (warn_slowpath_fmt+0x30/0x40)
[    0.000000] [<c0040ce0>] (warn_slowpath_fmt+0x30/0x40) from [<c066b8a4>] (omap_intc_of_init+0x50/0xb4)
[    0.000000] [<c066b8a4>] (omap_intc_of_init+0x50/0xb4) from [<c0688b70>] (of_irq_init+0x144/0x288)
[    0.000000] [<c0688b70>] (of_irq_init+0x144/0x288) from [<c0663294>] (init_IRQ+0x14/0x1c)
[    0.000000] [<c0663294>] (init_IRQ+0x14/0x1c) from [<c06607fc>] (start_kernel+0x198/0x304)
[    0.000000] [<c06607fc>] (start_kernel+0x198/0x304) from [<80008044>] (0x80008044)
[    0.000000] ---[ end trace 1b75b31a2719ed1c ]---
[    0.000000] of_irq_init: children remain, but no parents

The OMAP2 interrupt controller binding is missing the number of interrupts and interrupt controller register address. Adding these fixes the problem.

This is based upon latest linux-omap master (3.5-rc1) git tree.

---
 arch/arm/boot/dts/omap2.dtsi |    2 ++
 1 file changed, 2 insertions(+)
arch/arm/boot/dts/omap2.dtsi +2 -0
index f2ab4ea..581cb08 100644
@@ -44,6 +44,8 @@
 			compatible = "ti,omap2-intc";
 			interrupt-controller;
 			#interrupt-cells = <1>;
+			ti,intc-size = <96>;
+			reg = <0x480FE000 0x1000>;
 		};
 
 		uart1: serial at 4806a000 {
Signature · 1 line
1.7.9.5
author
#3 lore raw

v3 cover arm/dts: Add OMAP2420 SDP support

In reply to Jon Hunter
Quoted 3 lines · Jon Hunter

This series fixes the OMAP2 interrupt controller binding and adds support for the OMAP2420H4 board. I have verified that the kernel boots with device-tree on this board.

Oops! Forgot to change SDP to H4 in the $SUBJECT. However, should be correct elsewhere.

Jon

Quoted 14 lines

This series is based upon the linux-omap master branch (3.5-rc1).

V3: Rename OMAP2420 SDP to OMAP2420H4
V2: Correct typo in copyright date

Jon Hunter (2):
arm/dts: OMAP2: Add support for OMAP2420H4 Board arm/dts: OMAP2: Fix interrupt controller binding

 arch/arm/boot/dts/omap2.dtsi       |    2 ++
 arch/arm/boot/dts/omap2420-sdp.dts |   20 ++++++++++++++++++++
 2 files changed, 22 insertions(+)
 create mode 100644 arch/arm/boot/dts/omap2420-sdp.dts
author
#4 lore raw

v3 cover arm/dts: Add OMAP2420 SDP support

Quoted 8 lines · Jon Hunter
Quoted 3 lines · Jon Hunter

This series fixes the OMAP2 interrupt controller binding and adds support for the OMAP2420H4 board. I have verified that the kernel boots with device-tree on this board.

Oops! Forgot to change SDP to H4 in the $SUBJECT. However, should be correct elsewhere.

Ok, scratch this version. I have forgotten to change the dts file too. Sorry for all the noise, I shouldn't be trying to cram this in at the end of the day!

Jon

Quoted 14 lines
Quoted 14 lines

This series is based upon the linux-omap master branch (3.5-rc1).

V3: Rename OMAP2420 SDP to OMAP2420H4
V2: Correct typo in copyright date

Jon Hunter (2):
arm/dts: OMAP2: Add support for OMAP2420H4 Board arm/dts: OMAP2: Fix interrupt controller binding

 arch/arm/boot/dts/omap2.dtsi       |    2 ++
 arch/arm/boot/dts/omap2420-sdp.dts |   20 ++++++++++++++++++++
 2 files changed, 22 insertions(+)
 create mode 100644 arch/arm/boot/dts/omap2420-sdp.dts