imx31_phycore: Remove CONFIG_SYS_I2C_SLAVE definition
Fabio Estevam
reviewerPATCH 1/6 imx31_phycore: Remove CONFIG_SYS_I2C_SLAVE definition
From: Fabio Estevam <[email protected]>
According to include/i2c.h:
"/*
* Many boards/controllers/drivers don't support an I2C slave interface so
* provide a default slave address for them for use in common code. A real
* value for CONFIG_SYS_I2C_SLAVE should be defined for any board which does
* support a slave interface.
*/
#ifndef CONFIG_SYS_I2C_SLAVE
#define CONFIG_SYS_I2C_SLAVE 0xfe
#endif
"
As the mxc_i2c driver does not support slave mode, there is no need to define CONFIG_SYS_I2C_SLAVE in i.MX board file.
--- include/configs/imx31_phycore.h | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
include/configs/imx31_phycore.h +0 -1
@@ -56,7 +56,6 @@#define CONFIG_I2C_MXC #define CONFIG_SYS_I2C_MX31_PORT2 #define CONFIG_SYS_I2C_SPEED 100000 -#define CONFIG_SYS_I2C_SLAVE 0xfe#define CONFIG_MXC_UART #define CONFIG_MXC_UART_BASE UART1_BASE
Signature · 1 line
1.7.1
Fabio Estevam
reviewerPATCH 2/6 mx35pdk: Remove CONFIG_SYS_I2C_SLAVE definition
From: Fabio Estevam <[email protected]>
According to include/i2c.h:
"/*
* Many boards/controllers/drivers don't support an I2C slave interface so
* provide a default slave address for them for use in common code. A real
* value for CONFIG_SYS_I2C_SLAVE should be defined for any board which does
* support a slave interface.
*/
#ifndef CONFIG_SYS_I2C_SLAVE
#define CONFIG_SYS_I2C_SLAVE 0xfe
#endif
"
As the mxc_i2c driver does not support slave mode, there is no need to define CONFIG_SYS_I2C_SLAVE in i.MX board file.
--- include/configs/mx35pdk.h | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
include/configs/mx35pdk.h +0 -1
@@ -59,7 +59,6 @@#define CONFIG_I2C_MXC #define CONFIG_SYS_I2C_MX35_PORT1 #define CONFIG_SYS_I2C_SPEED 100000 -#define CONFIG_SYS_I2C_SLAVE 0xfe#define CONFIG_MXC_SPI #define CONFIG_MXC_GPIO
Signature · 1 line
1.7.1
Fabio Estevam
reviewerPATCH 3/6 mx53ard: Remove CONFIG_SYS_I2C_SLAVE definition
In reply to Fabio EstevamAccording to include/i2c.h:
"/*
* Many boards/controllers/drivers don't support an I2C slave interface so
* provide a default slave address for them for use in common code. A real
* value for CONFIG_SYS_I2C_SLAVE should be defined for any board which does
* support a slave interface.
*/
#ifndef CONFIG_SYS_I2C_SLAVE
#define CONFIG_SYS_I2C_SLAVE 0xfe
#endif
"
As the mxc_i2c driver does not support slave mode, there is no need to define CONFIG_SYS_I2C_SLAVE in i.MX board file.
--- include/configs/mx53ard.h | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
include/configs/mx53ard.h +0 -1
@@ -52,7 +52,6 @@#define CONFIG_I2C_MXC #define CONFIG_SYS_I2C_MX53_PORT2 #define CONFIG_SYS_I2C_SPEED 100000 -#define CONFIG_SYS_I2C_SLAVE 0xfe/* MMC Configs */ #define CONFIG_FSL_ESDHC
Signature · 1 line
1.7.1
Fabio Estevam
reviewerPATCH 4/6 mx53evk: Remove CONFIG_SYS_I2C_SLAVE definition
In reply to Fabio EstevamFrom: Fabio Estevam <[email protected]>
According to include/i2c.h:
"/*
* Many boards/controllers/drivers don't support an I2C slave interface so
* provide a default slave address for them for use in common code. A real
* value for CONFIG_SYS_I2C_SLAVE should be defined for any board which does
* support a slave interface.
*/
#ifndef CONFIG_SYS_I2C_SLAVE
#define CONFIG_SYS_I2C_SLAVE 0xfe
#endif
"
As the mxc_i2c driver does not support slave mode, there is no need to define CONFIG_SYS_I2C_SLAVE in i.MX board file.
--- include/configs/mx53evk.h | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
include/configs/mx53evk.h +0 -1
@@ -55,7 +55,6 @@#define CONFIG_I2C_MXC #define CONFIG_SYS_I2C_MX53_PORT2 1#define CONFIG_SYS_I2C_SPEED 100000 -#define CONFIG_SYS_I2C_SLAVE 0xfe/* PMIC Configs */ #define CONFIG_PMIC
Signature · 1 line
1.7.1
Fabio Estevam
reviewerPATCH 5/6 mx53loco: Remove CONFIG_SYS_I2C_SLAVE definition
In reply to Fabio EstevamFrom: Fabio Estevam <[email protected]>
According to include/i2c.h:
"/*
* Many boards/controllers/drivers don't support an I2C slave interface so
* provide a default slave address for them for use in common code. A real
* value for CONFIG_SYS_I2C_SLAVE should be defined for any board which does
* support a slave interface.
*/
#ifndef CONFIG_SYS_I2C_SLAVE
#define CONFIG_SYS_I2C_SLAVE 0xfe
#endif
"
As the mxc_i2c driver does not support slave mode, there is no need to define CONFIG_SYS_I2C_SLAVE in i.MX board file.
--- include/configs/mx53loco.h | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
include/configs/mx53loco.h +0 -1
@@ -92,7 +92,6 @@#define CONFIG_I2C_MXC #define CONFIG_SYS_I2C_MX53_PORT1 #define CONFIG_SYS_I2C_SPEED 100000 -#define CONFIG_SYS_I2C_SLAVE 0xfe/* PMIC Controller */ #define CONFIG_PMIC
Signature · 1 line
1.7.1
Fabio Estevam
reviewerPATCH 6/6 mx53smd: Remove CONFIG_SYS_I2C_SLAVE definition
In reply to Fabio EstevamFrom: Fabio Estevam <[email protected]>
According to include/i2c.h:
"/*
* Many boards/controllers/drivers don't support an I2C slave interface so
* provide a default slave address for them for use in common code. A real
* value for CONFIG_SYS_I2C_SLAVE should be defined for any board which does
* support a slave interface.
*/
#ifndef CONFIG_SYS_I2C_SLAVE
#define CONFIG_SYS_I2C_SLAVE 0xfe
#endif
"
As the mxc_i2c driver does not support slave mode, there is no need to define CONFIG_SYS_I2C_SLAVE in i.MX board file.
--- include/configs/mx53smd.h | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
include/configs/mx53smd.h +0 -1
@@ -52,7 +52,6 @@#define CONFIG_I2C_MXC #define CONFIG_SYS_I2C_MX53_PORT2 #define CONFIG_SYS_I2C_SPEED 100000 -#define CONFIG_SYS_I2C_SLAVE 0xfe/* MMC Configs */ #define CONFIG_FSL_ESDHC
Signature · 1 line
1.7.1
PATCH 1/6 imx31_phycore: Remove CONFIG_SYS_I2C_SLAVE definition
In reply to Fabio EstevamQuoted 4 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
According to
include/i2c.h:
Quoted 9 lines
"/*
* Many boards/controllers/drivers don't support an I2C slave interface so
* provide a default slave address for them for use in common code. A real
* value forCONFIG_SYS_I2C_SLAVEshould be defined for any board which does
* support a slave interface.
*/
#ifndefCONFIG_SYS_I2C_SLAVE
#defineCONFIG_SYS_I2C_SLAVE0xfe
#endif
Whole series applied to u-boot-imx, thanks.
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================