Skip to contentSkip to conversation

tc: prio: Perform more strict check on priomap.

PATCH Applied Li Wei 2 participants 2 messages Jun 18, 2012

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Li Wei

author
#0 lore raw

PATCH 1/1 tc: prio: Perform more strict check on priomap.

Since band number counts from zero thus band must be little than opt.bands.

---
 tc/q_prio.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
tc/q_prio.c +1 -1
index 79b4fd0..bacc702 100644
@@ -67,7 +67,7 @@ static int prio_parse_opt(struct qdisc_util *qu, int argc, char **argv, struct n
 				fprintf(stderr, "Illegal \"priomap\" element\n");
 				return -1;
 			}
-			if (band > opt.bands) {
+			if (band >= opt.bands) {
 				fprintf(stderr, "\"priomap\" element is out of bands\n");
 				return -1;
 			}
Signature · 1 line
1.7.1
Applied
#1 lore raw
Quoted 12 lines · On Mon, 18 Jun 2012 14:33:38 +0800 Li Wei <[email protected]> wrote:

Since band number counts from zero thus band must be little than opt.bands.

---
 tc/q_prio.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
tc/q_prio.c +0 -0
index 79b4fd0..bacc702 100644

tc/q_prio.c static int prio_parse_opt(struct qdisc_util *qu, int argc, char **argv, struct n · line 73

Quoted 8 lines
tc/q_prio.c +1 -1
@@ -67,7 +67,7 @@ static int prio_parse_opt(struct qdisc_util *qu, int argc, char **argv, struct n
 				fprintf(stderr, "Illegal \"priomap\" element\n");
 				return -1;
 			}
-			if (band > opt.bands) {
+			if (band >= opt.bands) {
 				fprintf(stderr, "\"priomap\" element is out of bands\n");
 				return -1;
 			}

Applied