Skip to contentSkip to conversation

Please revert the workload patch

Powertop Magnus Fromreide 3 participants 4 messages Jun 16, 2012 – Jun 18, 2012

lore
Share & tools
lore

Magnus Fromreide

author
#0 lore raw

Hello.

Could you please revert the workload patch (b45a38317777678b94cdf4cc81896e3a66db68bd) as it seems to try to execute some random memory. When powertop is started as

./powertop

I see the following stack trace:

Breakpoint 1, system (line=0x7fffffffd440 "\020\020i") at pt-system.c:29
29 pt-system.c: No such file or directory.
(gdb) where

#0  system (line=0x7fffffffd440 "\020\020i") at pt-system.c:29
#1  0x0000000000456933 in one_measurement (seconds=20, workload=0x7fffffffd440 "\020\020i") at main.cpp:190
#2  0x00000000004572c2 in main (argc=1, argv=0x7fffffffe538) at main.cpp:455

(gdb)

This shows up as a powertop beeing nonresponsive, flashing the display excessively and warning about not managing to run the program.

/MF

#1 lore raw

Hi Magnus,

This patch should fix your problem. I will work with Chris to get it pushed out.

BTW could not find the commit you quoted

--Dirk

src/main.cpp +1 -1
index 880d745..c57c984 100644
@@ -452,7 +452,7 @@ int main(int argc, char **argv)
 
  	while (!leave_powertop) {
  		show_cur_tab();
-		one_measurement(time_out, workload);
+		one_measurement(time_out, NULL);
  		learn_parameters(15, 0);
  	}
  #ifndef DISABLE_NCURSES
Signature · 1 line
1.7.7.6
Quoted 24 lines · Magnus Fromreide

Hello.

Could you please revert the workload patch (b45a38317777678b94cdf4cc81896e3a66db68bd) as it seems to try to execute some random memory. When powertop is started as

./powertop

I see the following stack trace:

Breakpoint 1, system (line=0x7fffffffd440 "\020\020i") at pt-system.c:29
29 pt-system.c: No such file or directory.
(gdb) where

#0  system (line=0x7fffffffd440 "\020\020i") at pt-system.c:29
#1  0x0000000000456933 in one_measurement (seconds=20, workload=0x7fffffffd440 "\020\020i") at main.cpp:190
#2  0x00000000004572c2 in main (argc=1, argv=0x7fffffffe538) at main.cpp:455

(gdb)

This shows up as a powertop beeing nonresponsive, flashing the display excessively and warning about not managing to run the program.

/MF

#2 lore raw

Hi Magnus,
Sorry about that, that patch was lost in the shuffle. All patches
have now been applied upstream, and all should now be well. -Chris

Quoted 22 lines · Dirk Brandewie

Hi Magnus,

This patch should fix your problem. I will work with Chris to get it pushed out.

BTW could not find the commit you quoted

--Dirk

src/main.cpp +1 -1
index 880d745..c57c984 100644
@@ -452,7 +452,7 @@ int main(int argc, char **argv)
 
     while (!leave_powertop) {
         show_cur_tab();
-        one_measurement(time_out, workload);
+        one_measurement(time_out, NULL);
         learn_parameters(15, 0);
     }
 #ifndef DISABLE_NCURSES
author
#3 lore raw
Quoted 4 lines · Chris Ferron

Hi Magnus,
Sorry about that, that patch was lost in the shuffle. All patches
have now been applied upstream, and all should now be well. -Chris

Yes, this is fixed in the current head version.

/MF

Quoted 24 lines · Dirk Brandewie
Quoted 22 lines

Hi Magnus,

This patch should fix your problem. I will work with Chris to get it pushed out.

BTW could not find the commit you quoted

--Dirk

src/main.cpp +1 -1
index 880d745..c57c984 100644
@@ -452,7 +452,7 @@ int main(int argc, char **argv)
 
     while (!leave_powertop) {
         show_cur_tab();
-        one_measurement(time_out, workload);
+        one_measurement(time_out, NULL);
         learn_parameters(15, 0);
     }
 #ifndef DISABLE_NCURSES