Skip to contentSkip to conversation

CAN FD support

PATCH In review Oliver Hartkopp 3 participants 7 messages Jun 18, 2012 – Jun 19, 2012 CAN network drivers

lore
Share & tools
lore
#0 lore raw

cover CAN FD support

Hello Marc,

here's my first real git patch series adding support for CAN with flexible data rate (CAN FD).

As there were no new remarks to my RFC v5 from 2012-05-28

http://comments.gmane.org/gmane.linux.can/1297

and it's tested and running on my machine for a while now it's IMHO time for net-next now.

You can also pull the series ;-)

Git is hard for newbies but i gave my very best ...

Best regards,
Oliver

The following changes since commit 4670fd819e7f47392c7c6fc6168ea2857c66d163:

tcp: Get rid of inetpeer special cases. (2012-06-09 01:25:47 -0700)

are available in the git repository at:

git://gitorious.org/~hartkopp/linux-can/ollis-can-next.git canfd

for you to fetch changes up to d55c45913f93ccbd4378195e2d6ca96b2d14573b:

canfd: update documentation according to CAN FD extensions (2012-06-17 21:23:55 +0200)

----------------------------------------------------------------

Oliver Hartkopp (6):
canfd: add new data structures and constants
canfd: add support for CAN FD in PF_CAN core
canfd: add support for CAN FD in CAN_RAW sockets
candev: add/update helpers for CAN FD
vcan: add CAN FD support
canfd: update documentation according to CAN FD extensions

 Documentation/networking/can.txt |  154 ++++++++++++++++++++++++++++++++++++--
 drivers/net/can/dev.c            |   35 ++++++++-
 drivers/net/can/vcan.c           |   27 +++++--
 include/linux/can.h              |   55 +++++++++++++-
 include/linux/can/core.h         |    4 +-
 include/linux/can/dev.h          |   33 ++++++--
 include/linux/can/raw.h          |    3 +-
 include/linux/if_ether.h         |    3 +-
 net/can/af_can.c                 |  116 +++++++++++++++++++++-------
 net/can/raw.c                    |   50 ++++++++++++-
 10 files changed, 417 insertions(+), 63 deletions(-)
Signature · 1 line
1.7.10.4
#1 lore raw
Quoted 5 lines · Oliver Hartkopp

Hello Marc,

here's my first real git patch series adding support for CAN with flexible data rate (CAN FD).

Quoted 8 lines

As there were no new remarks to my RFC v5 from 2012-05-28

http://comments.gmane.org/gmane.linux.can/1297

and it's tested and running on my machine for a while now it's IMHO time for net-next now.

You can also pull the series ;-)

I can pull, but David want's to have a clean tree. So I have to pull and rebase it on my tree.

Quoted 1 line

Git is hard for newbies but i gave my very best ...

Once you can use it, you don't want to code without it.

Marc

Signature · 4 lines
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |
#2 lore raw
Quoted 10 lines · Marc Kleine-Budde
Quoted 9 lines · Oliver Hartkopp

Hello Marc,

here's my first real git patch series adding support for CAN with flexible data rate (CAN FD).

As there were no new remarks to my RFC v5 from 2012-05-28

http://comments.gmane.org/gmane.linux.can/1297

Quoted 7 lines
Quoted 4 lines

and it's tested and running on my machine for a while now it's IMHO time for net-next now.

You can also pull the series ;-)

I can pull, but David want's to have a clean tree. So I have to pull and rebase it on my tree.

I created a branch 'canfd' on a clone of *your* can-next.

What's not clean there?

You can pull Daves net-next and then pull the canfd branch, right?

Quoted 4 lines
Quoted 2 lines

Git is hard for newbies but i gave my very best ...

Once you can use it, you don't want to code without it.

Yes - it's getting better. Indeed it looks like Thunderbird mangles the mails when editing the draft mails.

Regards,
Oliver

#3 lore raw
Quoted 7 lines · Oliver Hartkopp
Quoted 4 lines
Quoted 1 line

You can also pull the series ;-)

I can pull, but David want's to have a clean tree. So I have to pull and rebase it on my tree.

I created a branch 'canfd' on a clone of *your* can-next.

No need for that. git pull --rebase works.

Quoted 4 lines

What's not clean there?

You can pull Daves net-next and then pull the canfd branch, right?

Yes, but David wants to have a clean linear series of patches, not with merges in it.

Quoted 6 lines
Quoted 3 lines
Quoted 1 line

Git is hard for newbies but i gave my very best ...

Once you can use it, you don't want to code without it.

Yes - it's getting better. Indeed it looks like Thunderbird mangles the mails when editing the draft mails.

Don't do that :)

Marc

Signature · 4 lines
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |
#4 lore raw
Quoted 9 lines · Marc Kleine-Budde
Quoted 7 lines · Oliver Hartkopp
Quoted 4 lines
Quoted 1 line

You can also pull the series ;-)

I can pull, but David want's to have a clean tree. So I have to pull and rebase it on my tree.

I created a branch 'canfd' on a clone of *your* can-next.

Quoted 8 lines

No need for that. git pull --rebase works.

Quoted 4 lines

What's not clean there?

You can pull Daves net-next and then pull the canfd branch, right?

Yes, but David wants to have a clean linear series of patches, not with merges in it.

What can i do now to support this?

Quoted 9 lines
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

Git is hard for newbies but i gave my very best ...

Once you can use it, you don't want to code without it.

Yes - it's getting better. Indeed it looks like Thunderbird mangles the mails when editing the draft mails.

Don't do that :)

Yep. Just learned that %-[

#5 lore raw
Quoted 15 lines · Oliver Hartkopp
Quoted 13 lines · Marc Kleine-Budde
Quoted 7 lines · Oliver Hartkopp
Quoted 4 lines
Quoted 1 line

You can also pull the series ;-)

I can pull, but David want's to have a clean tree. So I have to pull and rebase it on my tree.

I created a branch 'canfd' on a clone of *your* can-next.

No need for that. git pull --rebase works.

Quoted 3 lines

What's not clean there?

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

You can pull Daves net-next and then pull the canfd branch, right?

Yes, but David wants to have a clean linear series of patches, not with merges in it.

What can i do now to support this?

No work on your side needed. I'll just rebase all patches on my tree (and add my S-o-b).

Marc

Signature · 4 lines
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |
#6 lore raw
In reply to Oliver Hartkopp
Quoted 28 lines · Oliver Hartkopp
Quoted 10 lines · Marc Kleine-Budde
Quoted 9 lines · Oliver Hartkopp

Hello Marc,

here's my first real git patch series adding support for CAN with flexible data rate (CAN FD).

As there were no new remarks to my RFC v5 from 2012-05-28

http://comments.gmane.org/gmane.linux.can/1297

Quoted 7 lines
Quoted 4 lines

and it's tested and running on my machine for a while now it's IMHO time for net-next now.

You can also pull the series ;-)

I can pull, but David want's to have a clean tree. So I have to pull and rebase it on my tree.

I created a branch 'canfd' on a clone of *your* can-next.

What's not clean there?

You can pull Daves net-next and then pull the canfd branch, right?

Quoted 1 line
Quoted 7 lines
Quoted 3 lines
Quoted 1 line

Git is hard for newbies but i gave my very best ...

Once you can use it, you don't want to code without it.

Yes - it's getting better. Indeed it looks like Thunderbird mangles the mails when editing the draft mails.

I use the "Toggle Word Wrap" Extension to avoid white space mangling with Thunderbird and sometimes I even use it to send single patches. Anyway, especially for a series of patches, "git send-email" is the better choice.

Wolfgang.