ARM: S3C64XX: Add IRQ mapping for wm0010 on Cragganmore

PATCH New Kukjin Kim 2 participants 4 messages Jun 19, 2012 – Jun 20, 2012 1 message not in the archive Arm Samsung Exynos

lore

Share & tools

lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Kukjin Kim

author

2012-06-19 08:50 UTC #1 lore raw

PATCH 1/1 ARM: S3C64XX: Add IRQ mapping for wm0010 on Cragganmore

Quoted 20 lines · Dimitris Papastamos

Signed-off-by Dimitris Papastamos <[email protected]>
---
 arch/arm/mach-s3c64xx/mach-crag6410-module.c |    1 +
 1 file changed, 1 insertion(+)
arch/arm/mach- renamed from arch/arm/mach-s3c64xx/mach-crag6410-module.c +0 -0
s3c64xx/mach-crag6410-module.c
index f347336..7c8ea3c 100644
arch/arm/mach-s3c64xx/mach-crag6410-module.c +1 -1
@@ -47,6 +47,7 @@ static struct spi_board_info wm1253_devs[] = {
 		.bus_num	= 0,
 		.chip_select	= 0,
 		.mode		= SPI_MODE_0,
+		.irq            = S3C_EINT(5),
 		.controller_data = &wm0010_spi_csinfo,
 		.platform_data = &wm0010_crag_pdata,
 	},
--

Quoted 1 line

1.7.10.4

OK, will apply.
Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

Kukjin Kim

author

2012-06-20 04:28 UTC #2 lore raw

PATCH 1/1 ARM: S3C64XX: Add IRQ mapping for wm0010 on Cragganmore

In reply to a message not in the archive

Quoted 10 lines · Kukjin Kim

Review
Quoted 7 lines · Dimitris Papastamos
Signed-off-by Dimitris Papastamos <[email protected]>
---
 arch/arm/mach-s3c64xx/mach-crag6410-module.c |    1 +
 1 file changed, 1 insertion(+)
(quoted diff) +0 -0
b/arch/arm/mach-

Quoted 9 lines

arch/arm/mach-s3c64xx/mach-crag6410-module.c static struct spi_board_info wm1253_devs[] = { · line 50
Quoted 9 lines
s3c64xx/mach-crag6410-module.c
index f347336..7c8ea3c 100644
arch/arm/mach-s3c64xx/mach-crag6410-module.c +1 -0
@@ -47,6 +47,7 @@ static struct spi_board_info wm1253_devs[] = {
 		.bus_num	= 0,
 		.chip_select	= 0,
 		.mode		= SPI_MODE_0,
+		.irq            = S3C_EINT(5),

                    ^^^^^^^^^^^^

If there is no reason, using tab is better at the mark ^

Quoted 2 lines

arch/arm/mach-s3c64xx/mach-crag6410-module.c static struct spi_board_info wm1253_devs[] = { · line 52
Quoted 2 lines
arch/arm/mach-s3c64xx/mach-crag6410-module.c +0 -0
 		.controller_data = &wm0010_spi_csinfo,
 		.platform_data = &wm0010_crag_pdata,

I can't find platform_data in my tree (just v3.5-rc3), there is another patch?

Now, just applying this patch is ok?

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

Dimitris Papastamos

2012-06-20 16:02 UTC #3 lore raw

PATCH 1/1 ARM: S3C64XX: Add IRQ mapping for wm0010 on Cragganmore

Quoted 21 lines · Kukjin Kim

Quoted 10 lines · Kukjin Kim
Review
Quoted 7 lines · Dimitris Papastamos
Signed-off-by Dimitris Papastamos <[email protected]>
---
 arch/arm/mach-s3c64xx/mach-crag6410-module.c |    1 +
 1 file changed, 1 insertion(+)
(quoted diff) +0 -0
b/arch/arm/mach-
Quoted 9 lines
arch/arm/mach-s3c64xx/mach-crag6410-module.c static struct spi_board_info wm1253_devs[] = { · line 50
Quoted 9 lines
s3c64xx/mach-crag6410-module.c
index f347336..7c8ea3c 100644
arch/arm/mach-s3c64xx/mach-crag6410-module.c +1 -0
@@ -47,6 +47,7 @@ static struct spi_board_info wm1253_devs[] = {
 		.bus_num	= 0,
 		.chip_select	= 0,
 		.mode		= SPI_MODE_0,
+		.irq            = S3C_EINT(5),
                    ^^^^^^^^^^^^

Quoted 1 line

If there is no reason, using tab is better at the mark ^

Oops, yes tabs there, will re-send.

Quoted 7 lines

Quoted 2 lines
arch/arm/mach-s3c64xx/mach-crag6410-module.c static struct spi_board_info wm1253_devs[] = { · line 52
Quoted 2 lines
arch/arm/mach-s3c64xx/mach-crag6410-module.c +0 -0
 		.controller_data = &wm0010_spi_csinfo,
 		.platform_data = &wm0010_crag_pdata,
I can't find platform_data in my tree (just v3.5-rc3), there is another patch?
Now, just applying this patch is ok?

Applying this patch should be fine.

Thanks,
Dimitris

Kukjin Kim

author

2012-06-20 18:28 UTC #4 lore raw

PATCH 1/1 ARM: S3C64XX: Add IRQ mapping for wm0010 on Cragganmore

Quoted 24 lines · Dimitris Papastamos

Quoted 21 lines · Kukjin Kim
Quoted 10 lines · Kukjin Kim
Review
Quoted 7 lines · Dimitris Papastamos
Signed-off-by Dimitris Papastamos<[email protected]>
---
  arch/arm/mach-s3c64xx/mach-crag6410-module.c |    1 +
  1 file changed, 1 insertion(+)
(quoted diff) +0 -0
b/arch/arm/mach-
Quoted 9 lines
arch/arm/mach-s3c64xx/mach-crag6410-module.c static struct spi_board_info wm1253_devs[] = { · line 50
Quoted 9 lines
s3c64xx/mach-crag6410-module.c
index f347336..7c8ea3c 100644
arch/arm/mach-s3c64xx/mach-crag6410-module.c +1 -0
@@ -47,6 +47,7 @@ static struct spi_board_info wm1253_devs[] = {
  		.bus_num	= 0,
  		.chip_select	= 0,
  		.mode		= SPI_MODE_0,
+		.irq            = S3C_EINT(5),
                     ^^^^^^^^^^^^
Quoted 1 line
If there is no reason, using tab is better at the mark ^

Quoted 2 lines

Oops, yes tabs there, will re-send.

OK, you don't need to re-send :)

Quoted 10 lines

Quoted 7 lines
Quoted 2 lines
arch/arm/mach-s3c64xx/mach-crag6410-module.c static struct spi_board_info wm1253_devs[] = { · line 52
Quoted 2 lines
arch/arm/mach-s3c64xx/mach-crag6410-module.c +0 -0
  		.controller_data =&wm0010_spi_csinfo,
  		.platform_data =&wm0010_crag_pdata,
I can't find platform_data in my tree (just v3.5-rc3), there is another patch?
Now, just applying this patch is ok?
Applying this patch should be fine.

OK, will apply.
Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.