pcm_bluetooth: accept BT_A2DP_SBC_SOURCE codec
PATCH 1/1 pcm_bluetooth: accept BT_A2DP_SBC_SOURCE codec
Current implementation of the PCM code is considering capture (source) mode however it ignores codecs of the SBC_SOURCE type while parsing capabilities. With these two lines source codec is accepted, although proper capture mode might require additional changes.
--- audio/pcm_bluetooth.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
audio/pcm_bluetooth.c +3 -1
@@ -1630,8 +1630,10 @@ static int bluetooth_parse_capabilities(struct bluetooth_data *data,return 0 ;while (bytes_left >0 ) { -if ((codec->type ==BT_A2DP_SBC_SINK ) && +if (((codec->type ==BT_A2DP_SBC_SINK ) && !(codec->lock &BT_WRITE_LOCK )) + || ((codec->type ==BT_A2DP_SBC_SOURCE ) && + !(codec->lock &BT_READ_LOCK )))break ; bytes_left -= codec->length;
Luiz Augusto von Dentz
maintainerHi Ruslan,
Quoted 9 lines · Ruslan N. Marchenko
Current implementation of the PCM code is considering capture (source) mode however it ignores codecs of the
SBC_SOURCEtype while parsing capabilities. With these two lines source codec is accepted, although proper capture mode might require additional changes.Signed-off-by Ruslan N. Marchenko <[email protected]>---
audio/pcm_bluetooth.c | 4 +++-1 file changed, 3 insertions(+), 1 deletion(-)
We are about to remove alsa support from BlueZ as it doesn't support the Media API, so this is a nak
Please next time use git format-patch + git send-email so it is easier to us to apply the patch using git am, also there is no need for the signed-off-by for userspace patches.
Signature · 1 line
Luiz Augusto von Dentz
Hi Luiz Augusto,
Am 22.06.2012 22:34, schrieb Luiz Augusto von Dentz:
Quoted 8 lines
Hi Ruslan,
Quoted 5 lines · Ruslan N. Marchenko
Current implementation of the PCM code is considering capture (source) mode however it ignores codecs of the
SBC_SOURCEtype while parsing capabilities. With these two lines source codec is accepted, although proper capture mode might require additional changes.
Quoted 6 lines
Quoted 4 lines
Signed-off-by Ruslan N. Marchenko <[email protected]>--- audio/pcm_bluetooth.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)We are about to remove alsa support from BlueZ as it doesn't support the Media API, so this is a nak
I see even trunk PA, mentioned [1] to be using Media API is using same calls in the same ipc.c(bt_audio_service_open) - is it something still to be cleaned up?
Anyway - does it make sense to port pcm_bluetooth to Media API (media.c)? Or BlueZ team is going to abandon it in favour of PA in any case? I mean if someone submit patches for pcm on Media API is there chance for patches to be accepted?
1. - http://lists.freedesktop.org/archives/pulseaudio-discuss/2011-November/012222.html
Quoted 3 lines
Please next time use git format-patch + git send-email so it is easier to us to apply the patch using git am, also there is no need for the signed-off-by for userspace patches.
Thanks for tips, will follow.
Signature · 2 lines
Looking forward to reading yours...
Ruslan N. MarchenkoHi Ruslan,
Quoted 4 lines · Ruslan N. Marchenko
Anyway - does it make sense to port
pcm_bluetoothto Media API (media.c)? Or BlueZ team is going to abandon it in favour of PA in any case? I mean if someone submit patches for pcm on Media API is there chance for patches to be accepted?
I doubt this would make it in time for BlueZ 5, but I don't think there'd be any objections to accepting a patch later that adds an ALSA user space plugin with a clean implementation for the Media interface.
Johan