ahci: Enable SB600 64bit DMA on MSI K9AGM2 (MS-7327)

PATCH In review Mark Nelson 2 participants 5 messages Jun 26, 2012 – Jun 28, 2012 libata

Share & tools

Mark Nelson

author

2012-06-26 02:46 UTC #0 lore raw

PATCH 1/1 ahci: Enable SB600 64bit DMA on MSI K9AGM2 (MS-7327)

Like e65cc194f7628ecaa02462f22f42fb09b50dcd49 this patch enables 64bit DMA for the AHCI SATA controller of a board that has the SB600 southbridge. In this case though we're enabling 64bit DMA for another MSI motherboard, the K9AGM2 or MS-7327. It is new enough that all of the BIOS releases since the initial release (1.0 from 2007-02-09) work correctly with 64bit DMA enabled.

Signed-off-by Mark Nelson <[email protected]>

---
 drivers/ata/ahci.c |   16 ++++++++++++++++
 1 file changed, 16 insertions(+)

drivers/ata/ahci.c +16 -0

Index: linux-2.6/drivers/ata/ahci.c
===================================================================
@@ -777,6 +777,22 @@ static bool ahci_sb600_enable_64bit(stru
 			},
 		},
 		/*
+		 * All BIOS versions for the MSI K9AGM2 (MS-7327) support
+		 * 64bit DMA.
+		 *
+		 * This board also had the typo mentioned above in the
+		 * Manufacturer DMI field (fixed in BIOS version 1.5), so
+		 * match on DMI_BOARD_VENDOR of "MICRO-STAR INTER" again.
+		 */
+		{
+			.ident = "MSI K9AGM2",
+			.matches = {
+				DMI_MATCH(DMI_BOARD_VENDOR,
+					  "MICRO-STAR INTER"),
+				DMI_MATCH(DMI_BOARD_NAME, "MS-7327"),
+			},
+		},
+		/*
 		 * All BIOS versions for the Asus M3A support 64bit DMA.
 		 * (all release versions from 0301 to 1206 were tested)
 		 */

Sergei Shtylyov

2012-06-26 10:49 UTC #1 lore raw

Hello.

Quoted 1 line · Mark Nelson

Like e65cc194f7628ecaa02462f22f42fb09b50dcd49

Please also specify that commit's summary in parens.

Quoted 7 lines

this patch enables 64bit DMA
for the AHCI SATA controller of a board that has the SB600 southbridge. In this case though we're enabling 64bit DMA for another MSI motherboard, the K9AGM2 or MS-7327. It is new enough that all of the BIOS releases since the initial release (1.0 from 2007-02-09) work correctly with 64bit DMA enabled.
Signed-off-by Mark Nelson <[email protected]>

MBR, Sergei

Mark Nelson

author

2012-06-27 06:31 UTC #2 lore raw

Quoted 7 lines · Sergei Shtylyov

Hello.
Quoted 1 line · Mark Nelson
Like e65cc194f7628ecaa02462f22f42fb09b50dcd49
Please also specify that commit's summary in parens.

Very good point! Should I do a simple respin of this patch adding the commit summary, or just do it for future patches?

Thanks!
Mark

Quoted 13 lines

Quoted 11 lines
this patch enables 64bit DMA
for the AHCI SATA controller of a board that has the SB600 southbridge. In
this case though we're enabling 64bit DMA for another MSI motherboard, the
K9AGM2 or MS-7327. It is new enough that all of the BIOS releases since the initial release (1.0 from 2007-02-09) work correctly with 64bit DMA enabled.
Signed-off-by Mark Nelson <[email protected]>
MBR, Sergei

Sergei Shtylyov

2012-06-27 11:44 UTC #3 lore raw

Hello.

Quoted 6 lines · Mark Nelson

Quoted 3 lines
Quoted 1 line
Like e65cc194f7628ecaa02462f22f42fb09b50dcd49
Please also specify that commit's summary in parens.
Very good point! Should I do a simple respin of this patch adding the commit summary, or just do it for future patches?

That's up to the maintainer but I'd respin the patch...

Quoted 13 lines

Thanks!
Mark
Quoted 10 lines
Quoted 10 lines
this patch enables 64bit DMA
for the AHCI SATA controller of a board that has the SB600 southbridge. In
this case though we're enabling 64bit DMA for another MSI motherboard, the
K9AGM2 or MS-7327. It is new enough that all of the BIOS releases since the initial release (1.0 from 2007-02-09) work correctly with 64bit DMA enabled.
Signed-off-by Mark Nelson <[email protected]>

MBR, Sergei

Mark Nelson

author

2012-06-28 02:32 UTC #4 lore raw

PATCH 1/1 ahci: Enable SB600 64bit DMA on MSI K9AGM2 (MS-7327) v2

Like e65cc194f7628ecaa02462f22f42fb09b50dcd49 (ahci: Enable SB600 64bit DMA on MSI K9A2 Platinum) and 3c4aa91f21f65b7b40bdfb015eacbcb8453ccae2 (ahci: Enable SB600 64bit DMA on Asus M3A), this patch enables 64bit DMA for the AHCI SATA controller of another board that has the SB600 southbridge.

In this case though we're enabling 64bit DMA for another MSI motherboard, the K9AGM2 or MS-7327. It is new enough that all of the BIOS releases since the initial release (1.0 from 2007-02-09) work correctly with 64bit DMA enabled.

Signed-off-by Mark Nelson <[email protected]>

---
v2 brings a more fleshed out commit message including the commit summaries of the commits mentioned

 drivers/ata/ahci.c |   16 ++++++++++++++++
 1 file changed, 16 insertions(+)

drivers/ata/ahci.c +16 -0

Index: linux-2.6/drivers/ata/ahci.c
===================================================================
@@ -777,6 +777,22 @@ static bool ahci_sb600_enable_64bit(stru
 			},
 		},
 		/*
+		 * All BIOS versions for the MSI K9AGM2 (MS-7327) support
+		 * 64bit DMA.
+		 *
+		 * This board also had the typo mentioned above in the
+		 * Manufacturer DMI field (fixed in BIOS version 1.5), so
+		 * match on DMI_BOARD_VENDOR of "MICRO-STAR INTER" again.
+		 */
+		{
+			.ident = "MSI K9AGM2",
+			.matches = {
+				DMI_MATCH(DMI_BOARD_VENDOR,
+					  "MICRO-STAR INTER"),
+				DMI_MATCH(DMI_BOARD_NAME, "MS-7327"),
+			},
+		},
+		/*
 		 * All BIOS versions for the Asus M3A support 64bit DMA.
 		 * (all release versions from 0301 to 1206 were tested)
 		 */