Skip to contentSkip to conversation

dependencies: ensure that DESTDIR isn't set when running Buildroot

PATCH New Thomas Petazzoni 3 participants 3 messages Jun 29, 2012 – Jun 30, 2012

lore
Share & tools
lore

Thomas Petazzoni

author
#0 lore raw

PATCH 1/1 dependencies: ensure that DESTDIR isn't set when running Buildroot

Having DESTDIR set in the environment before running Buildroot creates some funky problems in the build process. Prevent users from running into this kind of troubles.

Cc Michael Opdenacker <[email protected]>
Signed-off-by Thomas Petazzoni <[email protected]>
---
 support/dependencies/dependencies.sh |    6 ++++++
 1 file changed, 6 insertions(+)
support/dependencies/dependencies.sh +6 -0
index c47ffcf..43ec3cc 100755
@@ -48,6 +48,12 @@ if test -n "$PERL_MM_OPT" ; then
     exit 1
 fi
 
+if test -n "$DESTDIR" ; then
+    /bin/echo -e "\nYou have the DESTDIR environment variable set. Please"
+    /bin/echo -e "unset it so that Buildroot can work properly."
+    exit 1
+fi
+
 # Verify that which is installed
 if ! which which > /dev/null ; then
 	/bin/echo -e "\nYou must install 'which' on your build machine\n";
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 dependencies: ensure that DESTDIR isn't set when running Buildroot

Quoted 15 lines · Thomas Petazzoni

Having DESTDIR set in the environment before running Buildroot creates some funky problems in the build process. Prevent users from running into this kind of troubles.

Cc Michael Opdenacker<[email protected]>
Signed-off-by Thomas Petazzoni<[email protected]>
---
  support/dependencies/dependencies.sh |    6 ++++++
  1 file changed, 6 insertions(+)
support/dependencies/dependencies.sh +0 -0
index c47ffcf..43ec3cc 100755

support/dependencies/dependencies.sh if test -n "$PERL_MM_OPT" ; then · line 55

Quoted 8 lines
support/dependencies/dependencies.sh +5 -0
@@ -48,6 +48,12 @@ if test -n "$PERL_MM_OPT" ; then
      exit 1
  fi
 
+if test -n "$DESTDIR" ; then
+    /bin/echo -e "\nYou have the DESTDIR environment variable set. Please"
+    /bin/echo -e "unset it so that Buildroot can work properly."
+    exit 1
+fi

Why not just override and export DESTDIR from the top-level Makefile?

Regards,
Arnout

Quoted 4 lines
support/dependencies/dependencies.sh +1 -0
+
  # Verify that which is installed
  if ! which which>  /dev/null ; then
  	/bin/echo -e "\nYou must install 'which' on your build machine\n";
Signature · 6 lines
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#2 lore raw

PATCH 1/1 dependencies: ensure that DESTDIR isn't set when running Buildroot

In reply to Thomas Petazzoni
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Thomas> Having DESTDIR set in the environment before running Buildroot creates Thomas> some funky problems in the build process. Prevent users from running Thomas> into this kind of troubles.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard