arm: ep93xx: Enable i2c support for ep9302

PATCH New Todor Colov 4 participants 6 messages Jun 10, 2012 – Jul 1, 2012

Subsystems (3)

Arm (32-bit) Arm sub-architectures Arm/Cirrus logic EP93XX Arm architecture

lore

Share & tools

lore

Todor Colov

author

2012-06-10 12:44 UTC #0 lore raw

PATCH 1/1 arm: ep93xx: Enable i2c support for ep9302

Enable i2c support for ep9302. i2c support is needed when external RTC is used.

Signed-off-by Todor Colov <[email protected]>

---

arch/arm/mach-ep93xx/edb93xx-i2c-ep9302-enabled.c renamed from arch/arm/mach-ep93xx/edb93xx.c +2 -2

@@ -91,8 +91,8 @@
 		ep93xx_register_i2c(&edb93xx_i2c_gpio_data,
 				    edb93xxa_i2c_board_info,
 				    ARRAY_SIZE(edb93xxa_i2c_board_info));
-	} else if (machine_is_edb9307() || machine_is_edb9312() ||
-		   machine_is_edb9315()) {
+	} else if (machine_is_edb9302() || machine_is_edb9307()
+		|| machine_is_edb9312() || machine_is_edb9315()) {
 		ep93xx_register_i2c(&edb93xx_i2c_gpio_data,
 				    edb93xx_i2c_board_info,
 				    ARRAY_SIZE(edb93xx_i2c_board_info));

Ryan Mallon

2012-06-10 23:58 UTC #1 lore raw

PATCH 1/1 arm: ep93xx: Enable i2c support for ep9302

Quoted 5 lines · Todor Colov

Enable i2c support for ep9302. i2c support is needed when external RTC is used.
Signed-off-by Todor Colov <[email protected]>

Thanks. Applied to ep93xx-fixes.

arch/arm/mach-ep93xx/edb93xx-i2c-ep9302-enabled.c

Quoted 2 lines

arch/arm/mach-ep93xx/edb93xx-i2c-ep9302-enabled.c renamed from arch/arm/mach-ep93xx/edb93xx.c +0 -0

Please use git diff in future. This wouldn't directly apply with git am.

~Ryan

H Hartley Sweeten

2012-06-11 15:45 UTC #2 lore raw

PATCH 1/1 arm: ep93xx: Enable i2c support for ep9302

Quoted 8 lines · Ryan Mallon

Quoted 5 lines · Todor Colov
Enable i2c support for ep9302. i2c support is needed when external RTC is used.
Signed-off-by Todor Colov <[email protected]>
Thanks. Applied to ep93xx-fixes.

Ryan,

I'm not sure about this patch...

The EDB9302 does not have a built-on external RTC connected to the I2C bus. The EECLK and EEDAT pins are simply routed to two headers. They are not connected to any I2C devices built onto the board.

This patch will cause _all_ edb9302 boards to bind the ds1337 driver to the I2C bus but that device will only exist if a user has connected the part externally to the board.

Just my 2 cents...

Regards,
Hartley

Ryan Mallon

2012-06-11 21:50 UTC #3 lore raw

PATCH 1/1 arm: ep93xx: Enable i2c support for ep9302

Quoted 18 lines · H Hartley Sweeten

Quoted 8 lines · Ryan Mallon
Quoted 5 lines · Todor Colov
Enable i2c support for ep9302. i2c support is needed when external RTC is used.
Signed-off-by Todor Colov <[email protected]>
Thanks. Applied to ep93xx-fixes.
Ryan,
I'm not sure about this patch...
The EDB9302 does not have a built-on external RTC connected to the I2C bus. The EECLK and EEDAT pins are simply routed to two headers. They are not connected to any I2C devices built onto the board.

Quoted 5 lines

This patch will cause _all_ edb9302 boards to bind the ds1337 driver to the I2C bus but that device will only exist if a user has connected the part externally to the board.
Just my 2 cents...

Hmm, the binding is not really a problem, since it will just fail if the ds1337 device is not present at that i2c address. I guess the main problem is if there are users of the edb9302 who want i2c on the headers and others who want to use the pins as gpio. Without being able to auto-detect such boards at runtime (which seems very unlikely) I can't think of a good solution to this, other than it being time for me to do more DT reading :-).

I'm inclined to leave the patch in. The ep93xx doesn't have a lot of users, so I think it is okay to tailor it a bit to the users we do have. I'm happy to revert it, and find a better solution if this breaks someone else's setup.

~Ryan

Martin Guy

2012-06-21 19:33 UTC #4 lore raw

PATCH 1/1 arm: ep93xx: Enable i2c support for ep9302

Quoted 34 lines · Ryan Mallon

Quoted 18 lines · H Hartley Sweeten
Quoted 8 lines · Ryan Mallon
Quoted 5 lines · Todor Colov
Enable i2c support for ep9302. i2c support is needed when external RTC is used.
Signed-off-by Todor Colov <[email protected]>
Thanks. Applied to ep93xx-fixes.
Ryan,
I'm not sure about this patch...
The EDB9302 does not have a built-on external RTC connected to the I2C bus. The EECLK and EEDAT pins are simply routed to two headers. They are not connected to any I2C devices built onto the board.
Quoted 5 lines
This patch will cause _all_ edb9302 boards to bind the ds1337 driver to the I2C bus but that device will only exist if a user has connected the part externally to the board.
Just my 2 cents...
Hmm, the binding is not really a problem, since it will just fail if the ds1337 device is not present at that i2c address. I guess the main problem is if there are users of the edb9302 who want i2c on the headers and others who want to use the pins as gpio. Without being able to auto-detect such boards at runtime (which seems very unlikely) I can't think of a good solution to this, other than it being time for me to do more DT reading :-).

Quoted 4 lines

I'm inclined to leave the patch in. The ep93xx doesn't have a lot of users, so I think it is okay to tailor it a bit to the users we do have. I'm happy to revert it, and find a better solution if this breaks someone else's setup.

Hi folks
Can I add that the SimpleMachines.it Sim.One board, based on the
EP9307, has a DS1337 on the I2C bus, for which the define is machine_is_sim_one() However, the existing Linux kernel already read/writes this chip successfully, so I'm not sure what advantage this change would bring for that board. If you would like to test your patch on that board too, we may be able to ship you an enginering sample; if that would be useful please reply by private email.

Cheers

Ryan Mallon

2012-07-01 22:57 UTC #5 lore raw

PATCH 1/1 arm: ep93xx: Enable i2c support for ep9302

Quoted 40 lines · Martin Guy

Quoted 34 lines · Ryan Mallon
Quoted 18 lines · H Hartley Sweeten
Quoted 8 lines · Ryan Mallon
Quoted 5 lines · Todor Colov
Enable i2c support for ep9302. i2c support is needed when external RTC is used.
Signed-off-by Todor Colov <[email protected]>
Thanks. Applied to ep93xx-fixes.
Ryan,
I'm not sure about this patch...
The EDB9302 does not have a built-on external RTC connected to the I2C bus. The EECLK and EEDAT pins are simply routed to two headers. They are not connected to any I2C devices built onto the board.
Quoted 5 lines
This patch will cause _all_ edb9302 boards to bind the ds1337 driver to the I2C bus but that device will only exist if a user has connected the part externally to the board.
Just my 2 cents...
Hmm, the binding is not really a problem, since it will just fail if the ds1337 device is not present at that i2c address. I guess the main problem is if there are users of the edb9302 who want i2c on the headers and others who want to use the pins as gpio. Without being able to auto-detect such boards at runtime (which seems very unlikely) I can't think of a good solution to this, other than it being time for me to do more DT reading :-).
Quoted 4 lines
I'm inclined to leave the patch in. The ep93xx doesn't have a lot of users, so I think it is okay to tailor it a bit to the users we do have. I'm happy to revert it, and find a better solution if this breaks someone else's setup.

Quoted 6 lines

Hi folks
Can I add that the SimpleMachines.it Sim.One board, based on the
EP9307, has a DS1337 on the I2C bus, for which the define is machine_is_sim_one() However, the existing Linux kernel already read/writes this chip successfully, so I'm not sure what advantage this change would bring for that board.

Hi Martin,

Sorry for the late reply, I've been on holiday. The change only affects the Cirrus EDB-9302 board. The Sim.one is managed by a separate board file.

Quoted 3 lines

If you would like to test
your patch on that board too, we may be able to ship you an enginering sample; if that would be useful please reply by private email.

I already have one of the Sim.one boards. Thanks.

~Ryan