Skip to contentSkip to conversation

mx28evk: Fix boot by adjusting HW_DRAM_CTL29 register

PATCH New Fabio Estevam 4 participants 4 messages Jun 19, 2012 – Jul 2, 2012

lore
Share & tools
lore

Fabio Estevam

author
#0 lore raw

PATCH 1/1 mx28evk: Fix boot by adjusting HW_DRAM_CTL29 register

commit acc4959fc1 (Revert "i.MX28: Enable additional DRAM address bits") broke mx28evk boot.

Fix it by properly adjusting the HW_DRAM_CTL29 register value.

Suggested-by Marek Vasut <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>
---
 board/freescale/mx28evk/iomux.c |   14 ++++++++++++++
 1 files changed, 14 insertions(+), 0 deletions(-)
board/freescale/mx28evk/iomux.c +14 -0
index 6587c45..1e60204 100644
@@ -161,6 +161,20 @@ const iomux_cfg_t iomux_setup[] = {
 		(MXS_PAD_3V3 | MXS_PAD_8MA | MXS_PAD_PULLUP),
 };
 
+#define HW_DRAM_CTL29	(0x74 >> 2)
+#define CS_MAP		0xf
+#define COLUMN_SIZE	0x2
+#define ADDR_PINS	0x1
+#define APREBIT		0xa
+
+#define HW_DRAM_CTL29_CONFIG	(CS_MAP << 24 | COLUMN_SIZE << 16 | \
+					ADDR_PINS << 8 | APREBIT)
+
+void mx28_adjust_memory_params(uint32_t *dram_vals)
+{
+	dram_vals[HW_DRAM_CTL29] = HW_DRAM_CTL29_CONFIG;
+}
+
 void board_init_ll(void)
 {
 	mx28_common_spl_init(iomux_setup, ARRAY_SIZE(iomux_setup));
Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/1 mx28evk: Fix boot by adjusting HW_DRAM_CTL29 register

Dear Fabio Estevam,

Quoted 5 lines

commit acc4959fc1 (Revert "i.MX28: Enable additional DRAM address bits") broke mx28evk boot.

Fix it by properly adjusting the HW_DRAM_CTL29 register value.

Review

Quoted 7 lines
Suggested-by Marek Vasut <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>
---
 board/freescale/mx28evk/iomux.c |   14 ++++++++++++++
 1 files changed, 14 insertions(+), 0 deletions(-)
(quoted diff) +0 -0

Uh, why isn't this file called splboot.c?

But

Acked-by Marek Vasut <[email protected]>
Quoted 14 lines

b/board/freescale/mx28evk/iomux.c index 6587c45..1e60204 100644

board/freescale/mx28evk/iomux.c +7 -0
@@ -161,6 +161,20 @@ const iomux_cfg_t iomux_setup[] = {
 		(MXS_PAD_3V3 | MXS_PAD_8MA | MXS_PAD_PULLUP),
 };
 
+#define HW_DRAM_CTL29	(0x74 >> 2)
+#define CS_MAP		0xf
+#define COLUMN_SIZE	0x2
+#define ADDR_PINS	0x1
+#define APREBIT		0xa
+
+#define HW_DRAM_CTL29_CONFIG	(CS_MAP << 24 | COLUMN_SIZE << 16 | \

board/freescale/mx28evk/iomux.c const iomux_cfg_t iomux_setup[] = { · line 180

Quoted 10 lines
board/freescale/mx28evk/iomux.c +7 -0
+					ADDR_PINS << 8 | APREBIT)
+
+void mx28_adjust_memory_params(uint32_t *dram_vals)
+{
+	dram_vals[HW_DRAM_CTL29] = HW_DRAM_CTL29_CONFIG;
+}
+
 void board_init_ll(void)
 {
 	mx28_common_spl_init(iomux_setup, ARRAY_SIZE(iomux_setup));

Best regards,
Marek Vasut

#2 lore raw

PATCH 1/1 mx28evk: Fix boot by adjusting HW_DRAM_CTL29 register

Hi Stefano,

Quoted 13 lines · Marek Vasut

Dear Fabio Estevam,

Quoted 11 lines

commit acc4959fc1 (Revert "i.MX28: Enable additional DRAM address bits") broke mx28evk boot.

Fix it by properly adjusting the HW_DRAM_CTL29 register value.

Suggested-by Marek Vasut <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>

---
?board/freescale/mx28evk/iomux.c | ? 14 ++++++++++++++ ?1 files changed, 14 insertions(+), 0 deletions(-)

Quoted 6 lines

Review

Quoted 1 line
(quoted diff) +0 -0

Uh, why isn't this file called splboot.c?

But

Acked-by Marek Vasut <[email protected]>

Could this one be applied?

mx28evk does not boot without this patch.

Thanks,

Fabio Estevam

#3 lore raw

PATCH 1/1 mx28evk: Fix boot by adjusting HW_DRAM_CTL29 register

In reply to Fabio Estevam
Quoted 8 lines · Fabio Estevam

commit acc4959fc1 (Revert "i.MX28: Enable additional DRAM address bits") broke mx28evk boot.

Fix it by properly adjusting the HW_DRAM_CTL29 register value.

Suggested-by Marek Vasut <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>

---

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================