Skip to contentSkip to conversation

Kernel oops in __netif_schedule() for at76c50x-usb

DISCUSSION Larry Finger 2 participants 8 messages Jul 2, 2012 – Jul 4, 2012

lore
Share & tools
lore
#0 lore raw

Regarding the oops that I reported for PPC architecture that reported "Unable to handle kernel paging request for data at address 0x000004c", I have now repeated it on x86_64 architecture, where the objdump tool is better. The error occurs in the line in __netif_schedule() that says

         if (!test_and_set_bit(__QDISC_STATE_SCHED, &q->state))

Debug printouts have shown that q is not NULL, and it appears to be in the correct address range. I think q->state is zero; however, q->state cannot be written.

Additional testing shows this problem to be another side effect of commit 3a25a8c ("mac80211: add improved HW queue control") for a device with only a single HW queue.

Any suggestions for additional debugging printouts will be greatly appreciated.

Thanks,

Larry

#1 lore raw

Hi Larry,

Sorry! I had your other email still marked unread but hadn't gotten around to it :-(

Quoted 7 lines

Regarding the oops that I reported for PPC architecture that reported "Unable to handle kernel paging request for data at address 0x000004c", I have now repeated it on x86_64 architecture, where the objdump tool is better. The error occurs in the line in __netif_schedule() that says

          if (!test_and_set_bit(__QDISC_STATE_SCHED, &q->state))
Quoted 7 lines

Debug printouts have shown that q is not NULL, and it appears to be in the correct address range. I think q->state is zero; however, q->state cannot be written.

Additional testing shows this problem to be another side effect of commit 3a25a8c ("mac80211: add improved HW queue control") for a device with only a single HW queue.

Looking at the code again, it seems pretty obviously wrong ... OUCH!

I'm not sure which fix is correct though. Should we have software QoS queues for these drivers, but we'll never use them? Then this would work:
http://p.sipsolutions.net/e015bf7db9a05887.txt

Or we could change the enable code path. Hmm.

johannes

#2 lore raw
Quoted 20 lines · Johannes Berg

Hi Larry,

Sorry! I had your other email still marked unread but hadn't gotten around to it :-(

Quoted 7 lines

Regarding the oops that I reported for PPC architecture that reported "Unable to handle kernel paging request for data at address 0x000004c", I have now repeated it on x86_64 architecture, where the objdump tool is better. The error occurs in the line in __netif_schedule() that says

           if (!test_and_set_bit(__QDISC_STATE_SCHED, &q->state))
Quoted 7 lines

Debug printouts have shown that q is not NULL, and it appears to be in the correct address range. I think q->state is zero; however, q->state cannot be written.

Additional testing shows this problem to be another side effect of commit 3a25a8c ("mac80211: add improved HW queue control") for a device with only a single HW queue.

Quoted 8 lines

Looking at the code again, it seems pretty obviously wrong ... OUCH!

I'm not sure which fix is correct though. Should we have software QoS queues for these drivers, but we'll never use them? Then this would work:
http://p.sipsolutions.net/e015bf7db9a05887.txt

Or we could change the enable code path. Hmm.

That patch does prevent the oops. I was not able to make a connection with the device, but I just acquired it, and I'm not sure of its quality, or that of the driver. It does scan OK, and I think the patch is OK. I'll do more tests with b43legacy later as the machine with that iface is busy. I will also test b43 on the PPC using the open-source firmware.

Although you may want to change the enable code path, some patch will be needed to prevent a regression in 3.5. If this is the one, you may add a "Tested-by" for me.

Larry

#3 lore raw
Quoted 11 lines
Quoted 7 lines

I'm not sure which fix is correct though. Should we have software QoS queues for these drivers, but we'll never use them? Then this would work:
http://p.sipsolutions.net/e015bf7db9a05887.txt

Or we could change the enable code path. Hmm.

That patch does prevent the oops. I was not able to make a connection with the device, but I just acquired it, and I'm not sure of its quality, or that of the driver.

I don't think that device works today -- IIRC it requires the BSSID before authentication and that wasn't possible before the auth redesign.

Quoted 7 lines

It does scan OK, and I think the patch is OK. I'll do more tests with b43legacy later as the machine with that iface is busy. I will also test b43 on the PPC using the open-source firmware.

Although you may want to change the enable code path, some patch will be needed to prevent a regression in 3.5. If this is the one, you may add a "Tested-by" for me.

Thanks. Could you try this patch instead? I think it makes more sense.

http://p.sipsolutions.net/c3e9b814a409ca11.txt

johannes

#4 lore raw
Quoted 19 lines · Johannes Berg
Quoted 11 lines
Quoted 7 lines

I'm not sure which fix is correct though. Should we have software QoS queues for these drivers, but we'll never use them? Then this would work:
http://p.sipsolutions.net/e015bf7db9a05887.txt

Or we could change the enable code path. Hmm.

That patch does prevent the oops. I was not able to make a connection with the device, but I just acquired it, and I'm not sure of its quality, or that of the driver.

I don't think that device works today -- IIRC it requires the BSSID before authentication and that wasn't possible before the auth redesign.

Quoted 4 lines

It does scan OK, and I think the patch is OK. I'll do more tests with b43legacy later as the machine with that iface is busy. I will also test b43 on the PPC using the open-source firmware.

Quoted 7 lines
Quoted 3 lines

Although you may want to change the enable code path, some patch will be needed to prevent a regression in 3.5. If this is the one, you may add a "Tested-by" for me.

Thanks. Could you try this patch instead? I think it makes more sense.

http://p.sipsolutions.net/c3e9b814a409ca11.txt

That one fails and gives the oops in __netif_schedule.

Larry

#5 lore raw
Quoted 24 lines · Larry Finger
Quoted 23 lines · Johannes Berg
Quoted 11 lines
Quoted 7 lines

I'm not sure which fix is correct though. Should we have software QoS queues for these drivers, but we'll never use them? Then this would work:
http://p.sipsolutions.net/e015bf7db9a05887.txt

Or we could change the enable code path. Hmm.

That patch does prevent the oops. I was not able to make a connection with the device, but I just acquired it, and I'm not sure of its quality, or that of the driver.

I don't think that device works today -- IIRC it requires the BSSID before authentication and that wasn't possible before the auth redesign.

Quoted 7 lines

It does scan OK, and I think the patch is OK. I'll do more tests with b43legacy later as the machine with that iface is busy. I will also test b43 on the PPC using the open-source firmware.

Although you may want to change the enable code path, some patch will be needed to prevent a regression in 3.5. If this is the one, you may add a "Tested-by" for me.

Quoted 5 lines
Quoted 3 lines

Thanks. Could you try this patch instead? I think it makes more sense.

http://p.sipsolutions.net/c3e9b814a409ca11.txt

That one fails and gives the oops in __netif_schedule.

Hmmm, that's odd. I'll try to reproduce this to be able to track it better.

johannes

#6 lore raw
Quoted 4 lines · Johannes Berg
Quoted 4 lines
Quoted 4 lines
Quoted 3 lines

Although you may want to change the enable code path, some patch will be needed to prevent a regression in 3.5. If this is the one, you may add a "Tested-by" for me.

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

Thanks. Could you try this patch instead? I think it makes more sense.

http://p.sipsolutions.net/c3e9b814a409ca11.txt

That one fails and gives the oops in __netif_schedule.

Hmmm, that's odd. I'll try to reproduce this to be able to track it better.

Ok, strange. I can reproduce the original problem easily with hwsim, but with this new patch, which should be equivalent to the old, it's fixed:

http://p.sipsolutions.net/d78d8740ad2d15b4.txt

Can you try just this patch?

johannes

#7 lore raw
Quoted 12 lines · Johannes Berg
Quoted 10 lines · Johannes Berg
Quoted 9 lines
Quoted 7 lines
Quoted 3 lines

Although you may want to change the enable code path, some patch will be needed to prevent a regression in 3.5. If this is the one, you may add a "Tested-by" for me.

Thanks. Could you try this patch instead? I think it makes more sense.

http://p.sipsolutions.net/c3e9b814a409ca11.txt

That one fails and gives the oops in __netif_schedule.

Quoted 7 lines
Quoted 2 lines

Hmmm, that's odd. I'll try to reproduce this to be able to track it better.

Ok, strange. I can reproduce the original problem easily with hwsim, but with this new patch, which should be equivalent to the old, it's fixed:

http://p.sipsolutions.net/d78d8740ad2d15b4.txt

Ok, actually, the same bug is on stop, but for some reason that doesn't crash for me.

I've posted this patch now:
http://p.sipsolutions.net/55032a5ae0520dd8.txt

johannes