Skip to contentSkip to conversation

arch-kirkwood: Ethernet port macro returning incorrect address

PATCH New Luke Lowrey 3 participants 3 messages Jun 25, 2012 – Jul 3, 2012 Arm (32-bit)

lore
Share & tools
lore

Luke Lowrey

author
#0 lore raw

PATCH 1/1 arch-kirkwood: Ethernet port macro returning incorrect address

Modified the arch-kirkwood header so KWGBE_PORT_SERIAL_CONTROL1_REG(x) returns the correct address.

Originally calling KWGBE_PORT_SERIAL_CONTROL1_REG(1) returned the address for port 0 and vice versa.

Doesn't have any knock on effects to the u-boot code as the only time they're used is to do the same function to both addresses

Signed-off-by Luke Lowrey <[email protected]>
---
 arch/arm/include/asm/arch-kirkwood/cpu.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/include/asm/arch-kirkwood/cpu.h +1 -1
index d28c51a..784ba87 100644
@@ -33,7 +33,7 @@
 			| (attr << 8) | (kw_winctrl_calcsize(size) << 16))
 
 #define KWGBE_PORT_SERIAL_CONTROL1_REG(_x)	\
-		((_x ? KW_EGIGA0_BASE : KW_EGIGA1_BASE) + 0x44c)
+		((_x ? KW_EGIGA1_BASE : KW_EGIGA0_BASE) + 0x44c)
 
 #define KW_REG_PCIE_DEVID		(KW_REG_PCIE_BASE + 0x00)
 #define KW_REG_PCIE_REVID		(KW_REG_PCIE_BASE + 0x08)
Signature · 1 line
1.5.6.5
#1 lore raw

PATCH 1/1 arch-kirkwood: Ethernet port macro returning incorrect address

Quoted 30 lines

-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot- bounces at lists.denx.de] On Behalf Of Luke Lowrey
Sent: 25 June 2012 22:07
To: u-boot at lists.denx.de
Subject: [U-Boot] [PATCH] arch-kirkwood: Ethernet port macro returning incorrect address

Modified the arch-kirkwood header so KWGBE_PORT_SERIAL_CONTROL1_REG(x) returns the correct address.

Originally calling KWGBE_PORT_SERIAL_CONTROL1_REG(1) returned the address for port 0 and vice versa.

Doesn't have any knock on effects to the u-boot code as the only time they're used is to do the same function to both addresses

Signed-off-by Luke Lowrey <[email protected]>
---
 arch/arm/include/asm/arch-kirkwood/cpu.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/include/asm/arch-kirkwood/cpu.h +0 -0
index d28c51a..784ba87 100644

arch/arm/include/asm/arch-kirkwood/cpu.h

Quoted 9 lines
arch/arm/include/asm/arch-kirkwood/cpu.h +1 -2
@@ -33,7 +33,7 @@
 			| (attr << 8) | (kw_winctrl_calcsize(size) << 16))
 
 #define KWGBE_PORT_SERIAL_CONTROL1_REG(_x)	\
-		((_x ? KW_EGIGA0_BASE : KW_EGIGA1_BASE) + 0x44c)
+		((_x ? KW_EGIGA1_BASE : KW_EGIGA0_BASE) + 0x44c)
 
 #define KW_REG_PCIE_DEVID		(KW_REG_PCIE_BASE + 0x00)
 #define KW_REG_PCIE_REVID		(KW_REG_PCIE_BASE + 0x08)
--
Acked-by Prafulla Wadaskar <[email protected]>

Regards..
Prafulla . . .

#2 lore raw

PATCH 1/1 arch-kirkwood: Ethernet port macro returning incorrect address

In reply to Luke Lowrey

Hello Luke,

Quoted 6 lines · Luke Lowrey

Modified the arch-kirkwood header so KWGBE_PORT_SERIAL_CONTROL1_REG(x) returns the correct address.

Originally calling KWGBE_PORT_SERIAL_CONTROL1_REG(1) returned the address for port 0 and vice versa.

Quoted 7 lines

Doesn't have any knock on effects to the u-boot code as the only time they're used is to do the same function to both addresses

Signed-off-by Luke Lowrey<[email protected]>
---
  arch/arm/include/asm/arch-kirkwood/cpu.h |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
Acked-by Heiko Schocher <[email protected]>

bye,
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany