Skip to contentSkip to conversation

video: fixed exynos_mipi_dsi_init() declaration

PATCH New Donghwa Lee 2 participants 3 messages Jul 2, 2012 – Jul 4, 2012

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 video: fixed exynos_mipi_dsi_init() declaration

To avoid compilers error in case of not using CONFIG_EXYNOS_MIPI_DSIM, add no operation function.

---
 arch/arm/include/asm/arch-exynos/mipi_dsim.h |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)
arch/arm/include/asm/arch-exynos/mipi_dsim.h +7 -0
index 9a7cbeb..b73263d 100644
@@ -358,7 +358,14 @@ struct mipi_dsim_lcd_driver {
 	void	(*mipi_display_on)(struct mipi_dsim_device *dsim_dev);
 };
 
+#ifdef CONFIG_EXYNOS_MIPI_DSIM
 int exynos_mipi_dsi_init(void);
+#else
+int exynos_mipi_dsi_init(void)
+{
+	return 0;
+}
+#endif
 
 /*
  * register mipi_dsim_lcd_driver object defined by lcd panel driver
Signature · 1 line
1.7.4.1
#1 lore raw

PATCH 1/1 video: fixed exynos_mipi_dsi_init() declaration

Quoted 15 lines · Donghwa Lee

To avoid compilers error in case of not using CONFIG_EXYNOS_MIPI_DSIM, add no operation function.

---
 arch/arm/include/asm/arch-exynos/mipi_dsim.h |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)
arch/arm/include/asm/arch-exynos/mipi_dsim.h +0 -0
index 9a7cbeb..b73263d 100644
@@ -358,7 +358,14 @@ struct mipi_dsim_lcd_driver {
        void    (*mipi_display_on)(struct mipi_dsim_device *dsim_dev);

arch/arm/include/asm/arch-exynos/mipi_dsim.h struct mipi_dsim_lcd_driver { · line 368

Quoted 10 lines
arch/arm/include/asm/arch-exynos/mipi_dsim.h +7 -0
 };
 
+#ifdef CONFIG_EXYNOS_MIPI_DSIM
 int exynos_mipi_dsi_init(void);
+#else
+int exynos_mipi_dsi_init(void)
+{
+       return 0;
+}
+#endif

How about weak function instead of ifdef?

Thanks.
Minkyu Kang.

Signature · 2 lines
from. prom.
www.promsoft.net
#2 lore raw

PATCH 1/1 video: fixed exynos_mipi_dsi_init() declaration

Quoted 29 lines · Minkyu Kang
Quoted 15 lines · Donghwa Lee

To avoid compilers error in case of not using CONFIG_EXYNOS_MIPI_DSIM, add no operation function.

---
 arch/arm/include/asm/arch-exynos/mipi_dsim.h |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)
arch/arm/include/asm/arch-exynos/mipi_dsim.h +0 -0
index 9a7cbeb..b73263d 100644
@@ -358,7 +358,14 @@ struct mipi_dsim_lcd_driver {
        void    (*mipi_display_on)(struct mipi_dsim_device *dsim_dev);

arch/arm/include/asm/arch-exynos/mipi_dsim.h struct mipi_dsim_lcd_driver { · line 368

Quoted 10 lines
arch/arm/include/asm/arch-exynos/mipi_dsim.h +7 -0
 };
 
+#ifdef CONFIG_EXYNOS_MIPI_DSIM
 int exynos_mipi_dsi_init(void);
+#else
+int exynos_mipi_dsi_init(void)
+{
+       return 0;
+}
+#endif

How about weak function instead of ifdef?

Quoted 2 lines

Thanks.
Minkyu Kang.

Ok, It looks like better. I will fix it later.

Thank you,
Donghwa Lee.