Skip to contentSkip to conversation

rgmanager: Fix a possible NULL pointer dereference

PATCH New Ryan McCabe 2 participants 2 messages Jun 28, 2012 – Jul 4, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 5/5 rgmanager: Fix a possible NULL pointer dereference

Fix a NULL pointer dereference that could happen when cman_get_node_count() returns 0 with errno set to EINTR.

Possibly resolves rhbz#820632

---
 rgmanager/src/clulib/members.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
rgmanager/src/clulib/members.c +3 -1
index f705297..72f4529 100644
@@ -367,8 +367,10 @@ get_member_list(cman_handle_t h)
 
 	do {	
 		++tries;
-		if (nodes)
+		if (nodes) {
 			free(nodes);
+			nodes = NULL;
+		}
 
 		c = cman_get_node_count(h);
 		if (c <= 0) {
Signature · 1 line
1.7.10.2
#1 lore raw

PATCH 5/5 rgmanager: Fix a possible NULL pointer dereference

ACK

Quoted 27 lines · Ryan McCabe

Fix a NULL pointer dereference that could happen when cman_get_node_count() returns 0 with errno set to EINTR.

Possibly resolves rhbz#820632

---
 rgmanager/src/clulib/members.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
rgmanager/src/clulib/members.c +3 -1
index f705297..72f4529 100644
@@ -367,8 +367,10 @@ get_member_list(cman_handle_t h)
 
 	do {	
 		++tries;
-		if (nodes)
+		if (nodes) {
 			free(nodes);
+			nodes = NULL;
+		}
 
 		c = cman_get_node_count(h);
 		if (c <= 0) {