perf-scripting/perf-tui features, v2

PATCH In review [email protected] 3 participants 10 messages Jul 6, 2012 – Jul 9, 2012

lore

Share & tools

lore

[email protected]

author

2012-07-06 20:41 UTC #0 lore raw

cover perf-scripting/perf-tui features, v2

From: Tom Zanussi <[email protected]>

This patchset adds perf-scriping and perf-tui features as a per-arch thing rather than per-machine, as suggested by Richard Purdie.

I just started testing this, it works so far, but thought I'd put it out there now in case there were comments before putting too much effort into that, and possibly giving other people a chance to try it out.

The following changes since commit 5051e9837fa698e03d0a7a8a918ee7aa98409ce1:
Robert P. J. Day (1):
bitbake: usermanual: Fix missing markup

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib.git tzanussi/perf-scripting-v2
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=tzanussi/perf-scripting-v2

Tom Zanussi (3):
perf: add perf.inc
perf: add arch-specific perf-scripting feature
perf: add arch-specific perf-tui feature

 meta/recipes-kernel/perf/perf.inc    |   30 ++++++++++++++++++++++++++++++
 meta/recipes-kernel/perf/perf_3.4.bb |   18 +++++++++++++++---
 2 files changed, 45 insertions(+), 3 deletions(-)
 create mode 100644 meta/recipes-kernel/perf/perf.inc

[email protected]

author

2012-07-06 20:41 UTC #1 lore raw

PATCH 1/3 perf: add perf.inc

From: Tom Zanussi <[email protected]>

Add a perf.inc to contain utility functions and definitions and to avoid cluttering up the main recipe.

Signed-off-by Tom Zanussi <[email protected]>

---
 meta/recipes-kernel/perf/perf.inc    |   30 ++++++++++++++++++++++++++++++
 meta/recipes-kernel/perf/perf_3.4.bb |    2 ++
 2 files changed, 32 insertions(+), 0 deletions(-)
 create mode 100644 meta/recipes-kernel/perf/perf.inc

meta/recipes-kernel/perf/perf.inc new file +30 -0

new file mode 100644
index 0000000..9b46311
@@ -0,0 +1,30 @@
+def perf_arch_supports_feature(feature, trueval, falseval, d):
+    """
+    Check which perf features a particular architecture supports.
+
+    The perf_features_by_arch table below lists the perf features
+    supported by each arch.  If you want a particular arch to support
+    a given set of perf features, add an entry for the arch to this
+    table.  Otherwise the arch won't support any features (which may
+    be exactly what you want, just a barebones perf without any extra
+    baggage, which is what you get if you don't add any features
+    here.)
+
+    Available perf features:
+      perf-scripting: enable support for Perl and Python bindings
+      perf-tui: enable support for the perf TUI (via libnewt)
+
+    """
+    perf_features_by_arch = {
+	"core2":      "perf-scripting perf-tui",
+	"core2-64":   "perf-scripting perf-tui",
+	"x86":	      "perf-scripting perf-tui",
+	"x86-64":     "perf-scripting perf-tui",
+	"i586":	      "perf-scripting perf-tui",
+	}
+
+    tune = d.getVar("DEFAULTTUNE", True) or ""
+    if perf_features_by_arch.has_key(tune):
+	if feature in perf_features_by_arch[tune]:
+		return trueval
+    return falseval

meta/recipes-kernel/perf/perf_3.4.bb +2 -0

index 381332e..d494243 100644
@@ -11,6 +11,8 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7"
 
 PR = "r1"
 
+require perf.inc
+
 BUILDPERF_libc-uclibc = "no"
 
 DEPENDS = "virtual/kernel \

Signature · 1 line

1.7.0.4

[email protected]

author

2012-07-06 20:41 UTC #2 lore raw

PATCH 2/3 perf: add arch-specific perf-scripting feature

From: Tom Zanussi <[email protected]>

Add a new architecture-specific feature named 'perf-scripting'. Adding this into the perf_features_by_arch table in perf.inc for a given arch will enable perf scripting on a target built for that arch, which will turn on all the language bindings currently aavailable in perf (Perl and Python), if perf is included in an image.

If 'perf-scripting' isn't named as a feature (the default), all perf language bindings will be disabled and unavailable.

Signed-off-by Tom Zanussi <[email protected]>

---
 meta/recipes-kernel/perf/perf_3.4.bb |   12 +++++++++---
 1 files changed, 9 insertions(+), 3 deletions(-)

meta/recipes-kernel/perf/perf_3.4.bb +9 -3

index d494243..a79e9e6 100644
@@ -9,7 +9,7 @@ as well."
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7"
 
-PR = "r1"
+PR = "r2"
 
 require perf.inc

@@ -21,7 +21,8 @@ DEPENDS = "virtual/kernel \
            ${MLPREFIX}binutils \
           "
 
-RDEPENDS_${PN} += "elfutils perl perl-modules python"
+SCRIPTING_RDEPENDS = "${@perf_arch_supports_feature('perf-scripting', 'perl perl-modules python', '',d)}"
+RDEPENDS_${PN} += "elfutils ${SCRIPTING_RDEPENDS}"
 
 PROVIDES = "virtual/perf"

@@ -45,6 +46,8 @@ export PERL_ARCHLIB = "${STAGING_LIBDIR}${PERL_OWN_DIR}/perl/${@get_perl_version
 S = "${STAGING_KERNEL_DIR}"
 B = "${WORKDIR}/${BPN}-${PV}"
 
+SCRIPTING_DEFINES = "${@perf_arch_supports_feature('perf-scripting', '', 'NO_LIBPERL=1 NO_LIBPYTHON=1',d)}"
+
 EXTRA_OEMAKE = \
 		'-C ${S}/tools/perf \
 		O=${B} \

@@ -53,7 +56,7 @@ EXTRA_OEMAKE = \
 		CC="${CC}" \
 		AR="${AR}" \
 		prefix=/usr \
-		NO_GTK2=1 NO_NEWT=1 NO_DWARF=1 \
+		NO_GTK2=1 NO_NEWT=1 NO_DWARF=1 ${SCRIPTING_DEFINES} \
 		'
 
 do_compile() {

@@ -62,6 +65,9 @@ do_compile() {
 
 do_install() {
 	oe_runmake DESTDIR=${D} install
+	if [ "${@perf_arch_supports_feature('perf-scripting', 1, 0, d)}" = "1" ]; then
+		oe_runmake DESTDIR=${D} install-python_ext
+	fi
 }
 
 PACKAGE_ARCH = "${MACHINE_ARCH}"

Signature · 1 line

1.7.0.4

Saul Wold

2012-07-08 22:11 UTC #3 lore raw

Re: [PATCH 2/3] perf: add arch-specific perf-scripting feature

Quoted 59 lines · On 07/06/2012 01:29 PM, [email protected] wrote:

From: Tom Zanussi <[email protected]>

If 'perf-scripting' isn't named as a feature (the default), all perf language bindings will be disabled and unavailable.

Signed-off-by Tom Zanussi <[email protected]>

---
  meta/recipes-kernel/perf/perf_3.4.bb |   12 +++++++++---
  1 files changed, 9 insertions(+), 3 deletions(-)

meta/recipes-kernel/perf/perf_3.4.bb +6 -3

index d494243..a79e9e6 100644
@@ -9,7 +9,7 @@ as well."
  LICENSE = "GPLv2"
  LIC_FILES_CHKSUM = "file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7"
 
-PR = "r1"
+PR = "r2"
 
  require perf.inc

@@ -21,7 +21,8 @@ DEPENDS = "virtual/kernel \
             ${MLPREFIX}binutils \
            "
 
-RDEPENDS_${PN} += "elfutils perl perl-modules python"
+SCRIPTING_RDEPENDS = "${@perf_arch_supports_feature('perf-scripting', 'perl perl-modules python', '',d)}"
+RDEPENDS_${PN} += "elfutils ${SCRIPTING_RDEPENDS}"
 
  PROVIDES = "virtual/perf"

@@ -45,6 +46,8 @@ export PERL_ARCHLIB = "${STAGING_LIBDIR}${PERL_OWN_DIR}/perl/${@get_perl_version
  S = "${STAGING_KERNEL_DIR}"
  B = "${WORKDIR}/${BPN}-${PV}"
 
+SCRIPTING_DEFINES = "${@perf_arch_supports_feature('perf-scripting', '', 'NO_LIBPERL=1 NO_LIBPYTHON=1',d)}"
+
  EXTRA_OEMAKE = \
  		'-C ${S}/tools/perf \
  		O=${B} \

@@ -53,7 +56,7 @@ EXTRA_OEMAKE = \
  		CC="${CC}" \
  		AR="${AR}" \
  		prefix=/usr \
-		NO_GTK2=1 NO_NEWT=1 NO_DWARF=1 \
+		NO_GTK2=1 NO_NEWT=1 NO_DWARF=1 ${SCRIPTING_DEFINES} \
  		'
 
  do_compile() {

meta/recipes-kernel/perf/perf_3.4.bb do_compile() { · line 73

Quoted 9 lines

meta/recipes-kernel/perf/perf_3.4.bb +3 -0

@@ -62,6 +65,9 @@ do_compile() {
 
  do_install() {
  	oe_runmake DESTDIR=${D} install
+	if [ "${@perf_arch_supports_feature('perf-scripting', 1, 0, d)}" = "1" ]; then
+		oe_runmake DESTDIR=${D} install-python_ext
+	fi
  }
 
  PACKAGE_ARCH = "${MACHINE_ARCH}"

Tom,

I am not sure this one is working correctly, I this set of 3 in a build and it failed, so I bicested down to this patch. I am still seeing the setup.py: Permission denied problem:

Quoted 10 lines

| install scripts/python/bin/* -t '/srv/ssd/sgw_ab/yocto-autobuilder/yocto-slave/nightly-x86-64/build/build/tmp/work/qemux86_64-poky-linux/perf-3.4-r3/image/usr/libexec/perf-core/scripts/python/bin'
| make: Leaving directory `/srv/ssd/sgw_ab/yocto-autobuilder/yocto-slave/nightly-x86-64/build/build/tmp/sysroots/qemux86-64/usr/src/kernel/tools/perf'
| NOTE: make -j 16 -C /srv/ssd/sgw_ab/yocto-autobuilder/yocto-slave/nightly-x86-64/build/build/tmp/sysroots/qemux86-64/usr/src/kernel/tools/perf O=/srv/ssd/sgw_ab/yocto-autobuilder/yocto-slave/nightly-x86-64/build/build/tmp/work/qemux86_64-poky-linux/perf-3.4-r3/perf-3.4 CROSS_COMPILE=x86_64-poky-linux- ARCH=x86 CC=x86_64-poky-linux-gcc    -m64 --sysroot=/srv/ssd/sgw_ab/yocto-autobuilder/yocto-slave/nightly-x86-64/build/build/tmp/sysroots/qemux86-64 AR=x86_64-poky-linux-ar prefix=/usr NO_GTK2=1 NO_DWARF=1 DESTDIR=/srv/ssd/sgw_ab/yocto-autobuilder/yocto-slave/nightly-x86-64/build/build/tmp/work/qemux86_64-poky-linux/perf-3.4-r3/image install-python_ext
| make: Entering directory `/srv/ssd/sgw_ab/yocto-autobuilder/yocto-slave/nightly-x86-64/build/build/tmp/sysroots/qemux86-64/usr/src/kernel/tools/perf'
| util/setup.py --quiet install --root='//srv/ssd/sgw_ab/yocto-autobuilder/yocto-slave/nightly-x86-64/build/build/tmp/work/qemux86_64-poky-linux/perf-3.4-r3/image'
| make: execvp: util/setup.py: Permission denied
| make: *** [install-python_ext] Error 127
| make: Leaving directory `/srv/ssd/sgw_ab/yocto-autobuilder/yocto-slave/nightly-x86-64/build/build/tmp/sysroots/qemux86-64/usr/src/kernel/tools/perf'
| ERROR: oe_runmake failed
| ERROR: Function failed: do_install (see /srv/ssd/sgw_ab/yocto-autobuilder/yocto-slave/nightly-x86-64/build/build/tmp/work/qemux86_64-poky-linux/perf-3.4-r3/temp/log.do_install.6037 for further information)

Sau!

Tom Zanussi

author

2012-07-09 04:14 UTC #4 lore raw

Re: [PATCH 2/3] perf: add arch-specific perf-scripting feature

Quoted 67 lines · Saul Wold

Quoted 66 lines · On 07/06/2012 01:29 PM, [email protected] wrote:

From: Tom Zanussi <[email protected]>

If 'perf-scripting' isn't named as a feature (the default), all perf language bindings will be disabled and unavailable.

Signed-off-by Tom Zanussi <[email protected]>

---
  meta/recipes-kernel/perf/perf_3.4.bb |   12 +++++++++---
  1 files changed, 9 insertions(+), 3 deletions(-)

meta/recipes-kernel/perf/perf_3.4.bb +9 -3

index d494243..a79e9e6 100644
@@ -9,7 +9,7 @@ as well."
  LICENSE = "GPLv2"
  LIC_FILES_CHKSUM = "file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7"
 
-PR = "r1"
+PR = "r2"
 
  require perf.inc

@@ -21,7 +21,8 @@ DEPENDS = "virtual/kernel \
             ${MLPREFIX}binutils \
            "
 
-RDEPENDS_${PN} += "elfutils perl perl-modules python"
+SCRIPTING_RDEPENDS = "${@perf_arch_supports_feature('perf-scripting', 'perl perl-modules python', '',d)}"
+RDEPENDS_${PN} += "elfutils ${SCRIPTING_RDEPENDS}"
 
  PROVIDES = "virtual/perf"

@@ -45,6 +46,8 @@ export PERL_ARCHLIB = "${STAGING_LIBDIR}${PERL_OWN_DIR}/perl/${@get_perl_version
  S = "${STAGING_KERNEL_DIR}"
  B = "${WORKDIR}/${BPN}-${PV}"
 
+SCRIPTING_DEFINES = "${@perf_arch_supports_feature('perf-scripting', '', 'NO_LIBPERL=1 NO_LIBPYTHON=1',d)}"
+
  EXTRA_OEMAKE = \
  		'-C ${S}/tools/perf \
  		O=${B} \

@@ -53,7 +56,7 @@ EXTRA_OEMAKE = \
  		CC="${CC}" \
  		AR="${AR}" \
  		prefix=/usr \
-		NO_GTK2=1 NO_NEWT=1 NO_DWARF=1 \
+		NO_GTK2=1 NO_NEWT=1 NO_DWARF=1 ${SCRIPTING_DEFINES} \
  		'
 
  do_compile() {

@@ -62,6 +65,9 @@ do_compile() {
 
  do_install() {
  	oe_runmake DESTDIR=${D} install
+	if [ "${@perf_arch_supports_feature('perf-scripting', 1, 0, d)}" = "1" ]; then
+		oe_runmake DESTDIR=${D} install-python_ext
+	fi
  }

Quoted 8 lines

meta/recipes-kernel/perf/perf_3.4.bb do_compile() { · line 73
Quoted 2 lines
meta/recipes-kernel/perf/perf_3.4.bb +0 -0
  PACKAGE_ARCH = "${MACHINE_ARCH}"
Tom,
I am not sure this one is working correctly, I this set of 3 in a build and it failed, so I bicested down to this patch. I am still seeing the setup.py: Permission denied problem:

Looks like your build isn't getting the kernel changes needed for this patchset. They were posted at the same time and have actually actually already been pulled in - you just need to get the kernel in your build to use them...

Tom

Quoted 14 lines

Quoted 10 lines

| install scripts/python/bin/* -t '/srv/ssd/sgw_ab/yocto-autobuilder/yocto-slave/nightly-x86-64/build/build/tmp/work/qemux86_64-poky-linux/perf-3.4-r3/image/usr/libexec/perf-core/scripts/python/bin'
| make: Leaving directory `/srv/ssd/sgw_ab/yocto-autobuilder/yocto-slave/nightly-x86-64/build/build/tmp/sysroots/qemux86-64/usr/src/kernel/tools/perf'
| NOTE: make -j 16 -C /srv/ssd/sgw_ab/yocto-autobuilder/yocto-slave/nightly-x86-64/build/build/tmp/sysroots/qemux86-64/usr/src/kernel/tools/perf O=/srv/ssd/sgw_ab/yocto-autobuilder/yocto-slave/nightly-x86-64/build/build/tmp/work/qemux86_64-poky-linux/perf-3.4-r3/perf-3.4 CROSS_COMPILE=x86_64-poky-linux- ARCH=x86 CC=x86_64-poky-linux-gcc    -m64 --sysroot=/srv/ssd/sgw_ab/yocto-autobuilder/yocto-slave/nightly-x86-64/build/build/tmp/sysroots/qemux86-64 AR=x86_64-poky-linux-ar prefix=/usr NO_GTK2=1 NO_DWARF=1 DESTDIR=/srv/ssd/sgw_ab/yocto-autobuilder/yocto-slave/nightly-x86-64/build/build/tmp/work/qemux86_64-poky-linux/perf-3.4-r3/image install-python_ext
| make: Entering directory `/srv/ssd/sgw_ab/yocto-autobuilder/yocto-slave/nightly-x86-64/build/build/tmp/sysroots/qemux86-64/usr/src/kernel/tools/perf'
| util/setup.py --quiet install --root='//srv/ssd/sgw_ab/yocto-autobuilder/yocto-slave/nightly-x86-64/build/build/tmp/work/qemux86_64-poky-linux/perf-3.4-r3/image'
| make: execvp: util/setup.py: Permission denied
| make: *** [install-python_ext] Error 127
| make: Leaving directory `/srv/ssd/sgw_ab/yocto-autobuilder/yocto-slave/nightly-x86-64/build/build/tmp/sysroots/qemux86-64/usr/src/kernel/tools/perf'
| ERROR: oe_runmake failed
| ERROR: Function failed: do_install (see /srv/ssd/sgw_ab/yocto-autobuilder/yocto-slave/nightly-x86-64/build/build/tmp/work/qemux86_64-poky-linux/perf-3.4-r3/temp/log.do_install.6037 for further information)

Sau!

[email protected]

author

2012-07-06 20:41 UTC #5 lore raw

PATCH 3/3 perf: add arch-specific perf-tui feature

In reply to [email protected]

From: Tom Zanussi <[email protected]>

Add a new architecture-specific feature named 'perf-tui'. Adding this into the perf_features_by_arch table in perf.inc for a given arch will enable the perf TUI (Text-base UI) user interface on a target built for that arch, which adds libnewt and turns on the perf text UI options in perf, if perf is included in an image.

If 'perf-tui' isn't named as a feature (the default), the perf TUI will be disabled and unavailable.

Signed-off-by Tom Zanussi <[email protected]>

---
 meta/recipes-kernel/perf/perf_3.4.bb |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

meta/recipes-kernel/perf/perf_3.4.bb +6 -2

index a79e9e6..aa9dd6c 100644
@@ -9,16 +9,19 @@ as well."
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7"
 
-PR = "r2"
+PR = "r3"
 
 require perf.inc
 
 BUILDPERF_libc-uclibc = "no"
 
+TUI_DEPENDS = "${@perf_arch_supports_feature('perf-tui', 'libnewt', '',d)}"
+
 DEPENDS = "virtual/kernel \
            virtual/${MLPREFIX}libc \
            ${MLPREFIX}elfutils \
            ${MLPREFIX}binutils \
+           ${TUI_DEPENDS} \
           "
 
 SCRIPTING_RDEPENDS = "${@perf_arch_supports_feature('perf-scripting', 'perl perl-modules python', '',d)}"

@@ -47,6 +50,7 @@ S = "${STAGING_KERNEL_DIR}"
 B = "${WORKDIR}/${BPN}-${PV}"
 
 SCRIPTING_DEFINES = "${@perf_arch_supports_feature('perf-scripting', '', 'NO_LIBPERL=1 NO_LIBPYTHON=1',d)}"
+TUI_DEFINES = "${@perf_arch_supports_feature('perf-tui', '', 'NO_NEWT=1',d)}"
 
 EXTRA_OEMAKE = \
 		'-C ${S}/tools/perf \

@@ -56,7 +60,7 @@ EXTRA_OEMAKE = \
 		CC="${CC}" \
 		AR="${AR}" \
 		prefix=/usr \
-		NO_GTK2=1 NO_NEWT=1 NO_DWARF=1 ${SCRIPTING_DEFINES} \
+		NO_GTK2=1 ${TUI_DEFINES} NO_DWARF=1 ${SCRIPTING_DEFINES} \
 		'
 
 do_compile() {

Signature · 1 line

1.7.0.4

Tom Zanussi

author

2012-07-08 05:29 UTC #6 lore raw

In reply to [email protected]

Quoted 11 lines · On Fri, 2012-07-06 at 15:29 -0500, [email protected] wrote:

From: Tom Zanussi <[email protected]>
This patchset adds perf-scriping and perf-tui features as a per-arch thing rather than per-machine, as suggested by Richard Purdie.
I just started testing this, it works so far, but thought I'd put it out there now in case there were comments before putting too much effort into that, and possibly giving other people a chance to try it out.

Looks fine after more build-testing: qemux86, qemux86-64, crownbay, sugarbay, qemuarm and qemuppc both with and without perf-scripting and perf-tui, and builds without perf as well all build fine here.

Tom

Quoted 19 lines

The following changes since commit 5051e9837fa698e03d0a7a8a918ee7aa98409ce1:
Robert P. J. Day (1):
bitbake: usermanual: Fix missing markup
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib.git tzanussi/perf-scripting-v2
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=tzanussi/perf-scripting-v2
Tom Zanussi (3):
perf: add perf.inc
perf: add arch-specific perf-scripting feature
perf: add arch-specific perf-tui feature
 meta/recipes-kernel/perf/perf.inc    |   30 ++++++++++++++++++++++++++++++
 meta/recipes-kernel/perf/perf_3.4.bb |   18 +++++++++++++++---
 2 files changed, 45 insertions(+), 3 deletions(-)
 create mode 100644 meta/recipes-kernel/perf/perf.inc

Saul Wold

2012-07-09 08:06 UTC #7 lore raw

Quoted 13 lines · Tom Zanussi

Quoted 11 lines · On Fri, 2012-07-06 at 15:29 -0500, [email protected] wrote:
From: Tom Zanussi <[email protected]>
This patchset adds perf-scriping and perf-tui features as a per-arch thing rather than per-machine, as suggested by Richard Purdie.
I just started testing this, it works so far, but thought I'd put it out there now in case there were comments before putting too much effort into that, and possibly giving other people a chance to try it out.

Quoted 4 lines

Looks fine after more build-testing: qemux86, qemux86-64, crownbay, sugarbay, qemuarm and qemuppc both with and without perf-scripting and perf-tui, and builds without perf as well all build fine here.

Tom, I am sorry, I am not sure how else to say this, I have tested master with the only the following change and I am still getting the the setup.py failure mentioned.

I am not sure what else to suspect at this point, this is Master plus 3 commits, please help me understand where I have gone wrong.

This is the branch I have tested, which is 3 commits pasted Master:

http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sgw/fail

Thanks
Sau!

Quoted 30 lines

Tom
Quoted 14 lines
The following changes since commit 5051e9837fa698e03d0a7a8a918ee7aa98409ce1:
Robert P. J. Day (1):
bitbake: usermanual: Fix missing markup
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib.git tzanussi/perf-scripting-v2
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=tzanussi/perf-scripting-v2
Tom Zanussi (3):
perf: add perf.inc
perf: add arch-specific perf-scripting feature
perf: add arch-specific perf-tui feature
Quoted 5 lines
  meta/recipes-kernel/perf/perf.inc    |   30 ++++++++++++++++++++++++++++++
  meta/recipes-kernel/perf/perf_3.4.bb |   18 +++++++++++++++---
  2 files changed, 45 insertions(+), 3 deletions(-)
create mode 100644 meta/recipes-kernel/perf/perf.inc
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Tom Zanussi

author

2012-07-09 13:58 UTC #8 lore raw

Quoted 22 lines · Saul Wold

Quoted 13 lines · Tom Zanussi
Quoted 11 lines · On Fri, 2012-07-06 at 15:29 -0500, [email protected] wrote:
From: Tom Zanussi <[email protected]>
This patchset adds perf-scriping and perf-tui features as a per-arch thing rather than per-machine, as suggested by Richard Purdie.
I just started testing this, it works so far, but thought I'd put it out there now in case there were comments before putting too much effort into that, and possibly giving other people a chance to try it out.
Quoted 4 lines
Looks fine after more build-testing: qemux86, qemux86-64, crownbay, sugarbay, qemuarm and qemuppc both with and without perf-scripting and perf-tui, and builds without perf as well all build fine here.
Tom, I am sorry, I am not sure how else to say this, I have tested master with the only the following change and I am still getting the the setup.py failure mentioned.

Quoted 7 lines

I am not sure what else to suspect at this point, this is Master plus 3 commits, please help me understand where I have gone wrong.
This is the branch I have tested, which is 3 commits pasted Master:
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sgw/fail

Saul,

It's because your kernel hasn't advanced the SRCREVs to include the new commits - the above patches won't work without the associated kernel changes. So if you're build-testing qemux86-64 for instance, you'd want to change the following line in linux_yocto_3.4.bb from:

SRCREV_machine_qemux86-64 ?= "d345461f0d52d1a82553c2edd845a8bee908923f"

to include the last commit of the associated kernel patch series i.e.the top of the common-pc-64 branch:

SRCREV_machine_qemux86-64 ?= "49f1599b2ce0288599805b5364b895f5a9febb3e"

That should get the kernel changes associated with the patchset into your kernel and everything should build nicely...

Tom

Quoted 34 lines

Thanks
Sau!
Quoted 30 lines
Tom
Quoted 14 lines
The following changes since commit 5051e9837fa698e03d0a7a8a918ee7aa98409ce1:
Robert P. J. Day (1):
bitbake: usermanual: Fix missing markup
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib.git tzanussi/perf-scripting-v2
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=tzanussi/perf-scripting-v2
Tom Zanussi (3):
perf: add perf.inc
perf: add arch-specific perf-scripting feature
perf: add arch-specific perf-tui feature
Quoted 5 lines
  meta/recipes-kernel/perf/perf.inc    |   30 ++++++++++++++++++++++++++++++
  meta/recipes-kernel/perf/perf_3.4.bb |   18 +++++++++++++++---
  2 files changed, 45 insertions(+), 3 deletions(-)
create mode 100644 meta/recipes-kernel/perf/perf.inc
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Bruce Ashfield

2012-07-09 14:02 UTC #9 lore raw

Quoted 38 lines · Tom Zanussi

Quoted 22 lines · Saul Wold
Quoted 13 lines · Tom Zanussi
Quoted 11 lines · On Fri, 2012-07-06 at 15:29 -0500, [email protected] wrote:
From: Tom Zanussi <[email protected]>
This patchset adds perf-scriping and perf-tui features as a per-arch thing rather than per-machine, as suggested by Richard Purdie.
I just started testing this, it works so far, but thought I'd put it out there now in case there were comments before putting too much effort into that, and possibly giving other people a chance to try it out.
Quoted 4 lines
Looks fine after more build-testing: qemux86, qemux86-64, crownbay, sugarbay, qemuarm and qemuppc both with and without perf-scripting and perf-tui, and builds without perf as well all build fine here.
Tom, I am sorry, I am not sure how else to say this, I have tested master with the only the following change and I am still getting the the setup.py failure mentioned.
Quoted 7 lines
I am not sure what else to suspect at this point, this is Master plus 3 commits, please help me understand where I have gone wrong.
This is the branch I have tested, which is 3 commits pasted Master:
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sgw/fail
Saul,
It's because your kernel hasn't advanced the SRCREVs to include the new commits - the above patches won't work without the associated kernel changes. So if you're build-testing qemux86-64 for instance, you'd want to change the following line in linux_yocto_3.4.bb from:

Quoted 6 lines

SRCREV_machine_qemux86-64 ?= "d345461f0d52d1a82553c2edd845a8bee908923f"
to include the last commit of the associated kernel patch series i.e.the top of the common-pc-64 branch:
SRCREV_machine_qemux86-64 ?= "49f1599b2ce0288599805b5364b895f5a9febb3e"

.. and I'm about to send a new set of SRCREVs that have this and some more. I was just waiting to see how these conversations played out.

Cheers,

Bruce

Quoted 47 lines

That should get the kernel changes associated with the patchset into your kernel and everything should build nicely...
Tom
Quoted 34 lines
Thanks
Sau!
Quoted 30 lines
Tom
Quoted 14 lines
The following changes since commit 5051e9837fa698e03d0a7a8a918ee7aa98409ce1:
Robert P. J. Day (1):
bitbake: usermanual: Fix missing markup
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib.git tzanussi/perf-scripting-v2
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=tzanussi/perf-scripting-v2
Tom Zanussi (3):
perf: add perf.inc
perf: add arch-specific perf-scripting feature
perf: add arch-specific perf-tui feature
Quoted 5 lines
  meta/recipes-kernel/perf/perf.inc    |   30 ++++++++++++++++++++++++++++++
  meta/recipes-kernel/perf/perf_3.4.bb |   18 +++++++++++++++---
  2 files changed, 45 insertions(+), 3 deletions(-)
create mode 100644 meta/recipes-kernel/perf/perf.inc
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Signature · 2 lines

"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"