Skip to contentSkip to conversation

EXYNOS: Fix USB compiler warning

PATCH New Rajeshwari Shinde 5 participants 5 messages Jul 10, 2012

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 EXYNOS: Fix USB compiler warning

Fixed the compiler warning message.

---
 arch/arm/cpu/armv7/exynos/system.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/arm/cpu/armv7/exynos/system.c +0 -1
index cc6ee03..4426611 100644
@@ -29,7 +29,6 @@ static void exynos5_set_usbhost_mode(unsigned int mode)
 {
 	struct exynos5_sysreg *sysreg =
 		(struct exynos5_sysreg *)samsung_get_base_sysreg();
-	unsigned int phy_cfg;
 
 	/* Setting USB20PHY_CONFIG register to USB 2.0 HOST link */
 	if (mode == USB20_PHY_CFG_HOST_LINK_EN) {
Signature · 1 line
1.7.4.4
#1 lore raw

PATCH 1/1 EXYNOS: Fix USB compiler warning

Dear Rajeshwari Shinde,

Quoted 1 line

Fixed the compiler warning message.

Quoted 10 lines
---
 arch/arm/cpu/armv7/exynos/system.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
(quoted diff) +0 -0

b/arch/arm/cpu/armv7/exynos/system.c index cc6ee03..4426611 100644

arch/arm/cpu/armv7/exynos/system.c static void exynos5_set_usbhost_mode(unsigned int mode) · line 34

Quoted 7 lines
arch/arm/cpu/armv7/exynos/system.c +0 -1
@@ -29,7 +29,6 @@ static void exynos5_set_usbhost_mode(unsigned int mode)
 {
 	struct exynos5_sysreg *sysreg =
 		(struct exynos5_sysreg *)samsung_get_base_sysreg();
-	unsigned int phy_cfg;
 
 	/* Setting USB20PHY_CONFIG register to USB 2.0 HOST link */
 	if (mode == USB20_PHY_CFG_HOST_LINK_EN) {

Best regards,
Marek Vasut

#2 lore raw

PATCH 1/1 EXYNOS: Fix USB compiler warning

In reply to Rajeshwari Shinde

Hi Rajeshwari,

How do you think about fixing other warning messages? If you are inconvenience, i will fix it.

pinmux.c: In function 'exynos_pinmux_config':
pinmux.c:100:20: warning: 'gpio_func' may be used uninitialized in this function [-Wuninitialized] pinmux.c:69:16: note: 'gpio_func' was declared here
pinmux.c:99:31: warning: 'start' may be used uninitialized in this function [-Wuninitialized] pinmux.c:69:9: note: 'start' was declared here

Best Regards,
Jaehoon Chung

Quoted 19 lines · Rajeshwari Shinde

Fixed the compiler warning message.

---
 arch/arm/cpu/armv7/exynos/system.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/arm/cpu/armv7/exynos/system.c +0 -1
index cc6ee03..4426611 100644
@@ -29,7 +29,6 @@ static void exynos5_set_usbhost_mode(unsigned int mode)
 {
 	struct exynos5_sysreg *sysreg =
 		(struct exynos5_sysreg *)samsung_get_base_sysreg();
-	unsigned int phy_cfg;
 
 	/* Setting USB20PHY_CONFIG register to USB 2.0 HOST link */
 	if (mode == USB20_PHY_CFG_HOST_LINK_EN) {
#3 lore raw

PATCH 1/1 EXYNOS: Fix USB compiler warning

Hi Jaehoon Chung,

I just fixed the waning messages i saw on u-boot-usb. Did not find these warning messages in that tree. Will fix these. Sorry for inconvenience.

Regards,
Rajeshwari Shinde.

Quoted 41 lines · Jaehoon Chung

Hi Rajeshwari,

How do you think about fixing other warning messages? If you are inconvenience, i will fix it.

pinmux.c: In function 'exynos_pinmux_config':
pinmux.c:100:20: warning: 'gpio_func' may be used uninitialized in this function [-Wuninitialized] pinmux.c:69:16: note: 'gpio_func' was declared here
pinmux.c:99:31: warning: 'start' may be used uninitialized in this function [-Wuninitialized] pinmux.c:69:9: note: 'start' was declared here

Best Regards,
Jaehoon Chung

Quoted 12 lines · Rajeshwari Shinde

Fixed the compiler warning message.

---
 arch/arm/cpu/armv7/exynos/system.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/arm/cpu/armv7/exynos/system.c +0 -0
index cc6ee03..4426611 100644

arch/arm/cpu/armv7/exynos/system.c static void exynos5_set_usbhost_mode(unsigned int mode) · line 34

Quoted 7 lines
arch/arm/cpu/armv7/exynos/system.c +0 -1
@@ -29,7 +29,6 @@ static void exynos5_set_usbhost_mode(unsigned int mode)
 {
      struct exynos5_sysreg *sysreg =
              (struct exynos5_sysreg *)samsung_get_base_sysreg();
-     unsigned int phy_cfg;
 
      /* Setting USB20PHY_CONFIG register to USB 2.0 HOST link */
      if (mode == USB20_PHY_CFG_HOST_LINK_EN) {

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

#4 lore raw

PATCH 1/1 EXYNOS: Fix USB compiler warning

In reply to Rajeshwari Shinde

Dear Rajeshwari Shinde,

Quoted 6 lines · In message <[email protected]> you…

Fixed the compiler warning message.

---
 arch/arm/cpu/armv7/exynos/system.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
An expert is a person who avoids the small errors while  sweeping  on
to the grand fallacy.