Skip to contentSkip to conversation

drivers/staging/iio/adc/max1363_ring.c:87:7: warning: 'rxbuf' may be us

PATCH In review [email protected] 2 participants 2 messages Jul 10, 2012 Kernel janitors

lore
Share & tools
lore
#0 lore raw

PATCH 84/99 drivers/staging/iio/adc/max1363_ring.c:87:7: warning: 'rxbuf' may be us

Hi Lars-Peter,

There are new compile warnings show up in

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next
head:   f12db36d3fd7ab75c29015c32a12d49697e11f61
commit: da0f01e1ed88b4ac650d884e4e2ee11c9cd4d83b [84/99] staging:iio:max1363: Do not return error code in interrupt handler

All warnings:

drivers/staging/iio/adc/max1363_ring.c: In function 'max1363_trigger_handler':
drivers/staging/iio/adc/max1363_ring.c:87:7: warning: 'rxbuf' may be used uninitialized in this function [-Wmaybe-uninitialized]

vim +87 drivers/staging/iio/adc/max1363_ring.c

    84	
    85	done:
    86		iio_trigger_notify_done(indio_dev->trig);
Quoted 1 line

87 kfree(rxbuf);

    88	
    89		return IRQ_HANDLED;
    90	}

---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu <[email protected]> Intel Corporation

#1 lore raw

Re: [staging:staging-next 84/99] drivers/staging/iio/adc/max1363_ring.c:87:7: warning: 'rxbuf' may b

Quoted 4 lines · On 07/10/2012 02:40 AM, [email protected] wrote:

Hi Lars-Peter,

There are new compile warnings show up in

Quoted 9 lines
tree:   git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next
head:   f12db36d3fd7ab75c29015c32a12d49697e11f61
commit: da0f01e1ed88b4ac650d884e4e2ee11c9cd4d83b [84/99] staging:iio:max1363: Do not return error code in interrupt handler

All warnings:

drivers/staging/iio/adc/max1363_ring.c: In function 'max1363_trigger_handler':
drivers/staging/iio/adc/max1363_ring.c:87:7: warning: 'rxbuf' may be used uninitialized in this function [-Wmaybe-uninitialized]

Yea, known issue. I somehow managed to send out an outdated version of the patch, the one I have locally does not have this issue. Will send out a fix shortly.

Thanks for reporting.
- Lars

Quoted 12 lines

vim +87 drivers/staging/iio/adc/max1363_ring.c

    84	
    85	done:
    86		iio_trigger_notify_done(indio_dev->trig);
Quoted 1 line

87 kfree(rxbuf);

    88	
    89		return IRQ_HANDLED;
    90	}

---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu <[email protected]> Intel Corporation