tc: filter: validate filter priority in userspace.

PATCH Applied Li Wei 2 participants 2 messages Jul 10, 2012

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

Li Wei

author

2012-07-10 08:59 UTC #0 lore raw

PATCH 1/1 tc: filter: validate filter priority in userspace.

Because we use the high 16 bits of tcm_info to pass prio value to kernel, thus it's range would be [0, 0xffff], without validation in tc when user pass a lager(>65535) priority, the actual priority set in kernel would confuse the user.

So, add a validation to ensure prio in the range.

---
 tc/tc_filter.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

tc/tc_filter.c +1 -1

index 207302f..04c3b82 100644
@@ -105,7 +105,7 @@ int tc_filter_modify(int cmd, unsigned flags, int argc, char **argv)
 			NEXT_ARG();
 			if (prio)
 				duparg("priority", *argv);
-			if (get_u32(&prio, *argv, 0))
+			if (get_u32(&prio, *argv, 0) || prio > 0xFFFF)
 				invarg(*argv, "invalid priority value");
 		} else if (matches(*argv, "protocol") == 0) {
 			__u16 id;

Signature · 1 line

1.7.1

Stephen Hemminger

Applied

2012-07-10 22:40 UTC #1 lore raw

Quoted 7 lines · On Tue, 10 Jul 2012 16:45:28 +0800 Li Wei <[email protected]> wrote:

Because we use the high 16 bits of tcm_info to pass prio value to kernel, thus it's range would be [0, 0xffff], without validation in tc when user pass a lager(>65535) priority, the actual priority set in kernel would confuse the user.
So, add a validation to ensure prio in the range.

Applied