Skip to contentSkip to conversation

i2c: deblock i2c bus also if accessed before realocation

PATCH New Holger Brunck 2 participants 3 messages Jun 28, 2012 – Jul 10, 2012

lore
Share & tools
lore

Holger Brunck

author
#0 lore raw

PATCH 1/1 i2c: deblock i2c bus also if accessed before realocation

If we switch to a different i2c bus in changing the mux config for the i2c mux, we have to be sure to deblock the bus also before realocation.

Signed-off-by Holger Brunck <[email protected]>
cc Heiko Schocher <[email protected]>
cc Valentin Longchamp <[email protected]>
---
 common/cmd_i2c.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
common/cmd_i2c.c +1 -0
index 2cdc4ed..795814d 100644
@@ -1445,6 +1445,7 @@ int i2c_mux_ident_muxstring_f (uchar *buf)
 		oldpos = pos;
 
 	}
+	i2c_init_board();
 
 	return 0;
 }
Signature · 1 line
1.7.1
author
#1 lore raw

PATCH 1/1 i2c: deblock i2c bus also if accessed before realocation

Hi Heiko,

Quoted 16 lines · Holger Brunck

If we switch to a different i2c bus in changing the mux config for the i2c mux, we have to be sure to deblock the bus also before realocation.

Signed-off-by Holger Brunck <[email protected]>
cc Heiko Schocher <[email protected]>
cc Valentin Longchamp <[email protected]>
---
 common/cmd_i2c.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
common/cmd_i2c.c +0 -0
index 2cdc4ed..795814d 100644

common/cmd_i2c.c int i2c_mux_ident_muxstring_f (uchar *buf) · line 1451

Quoted 7 lines
common/cmd_i2c.c +1 -0
@@ -1445,6 +1445,7 @@ int i2c_mux_ident_muxstring_f (uchar *buf)
 		oldpos = pos;
 
 	}
+	i2c_init_board();
 
 	return 0;
 }

do you consider this one as a bugfix for 2012.07 or do you think it should be included in the next merge window?

Regards
Holger

#2 lore raw

PATCH 1/1 i2c: deblock i2c bus also if accessed before realocation

Hello Holger,

Quoted 24 lines · Holger Brunck

Hi Heiko,

Quoted 21 lines · Holger Brunck

If we switch to a different i2c bus in changing the mux config for the i2c mux, we have to be sure to deblock the bus also before realocation.

Signed-off-by Holger Brunck<[email protected]>
cc Heiko Schocher<[email protected]>
cc Valentin Longchamp<[email protected]>
---
  common/cmd_i2c.c |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)
common/cmd_i2c.c +1 -0
index 2cdc4ed..795814d 100644
@@ -1445,6 +1445,7 @@ int i2c_mux_ident_muxstring_f (uchar *buf)
  		oldpos = pos;
 
  	}
+	i2c_init_board();
Quoted 6 lines

common/cmd_i2c.c int i2c_mux_ident_muxstring_f (uchar *buf) · line 1451

Quoted 2 lines
common/cmd_i2c.c +0 -0
  	return 0;
  }

do you consider this one as a bugfix for 2012.07 or do you think it should be included in the next merge window?

I queued it for the next merge window ...

bye,
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany