Skip to contentSkip to conversation

drm/amdgpu/display: include slab.h in dcn21_resource.c

PATCH In review Alex Deucher 2 participants 4 messages Sep 23, 2019 – Sep 24, 2019 3 messages not in the archive

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu/display: include slab.h in dcn21_resource.c

It's apparently needed in some configurations.

---
 drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c +2 -0
index 3ca5139f1273..de182185fe1f 100644
@@ -23,6 +23,8 @@
  *
  */
 
+#include <linux/slab.h>
+
 #include "dm_services.h"
 #include "dc.h"
 
Signature · 6 lines
2.20.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 20190923205804.12300-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org

#2 lore raw
Quoted 1 line · Alex Deucher

It's apparently needed in some configurations.

Curious which config fails and what compiler errors we get... Sounds like our includes are messed up somewhere.

Harry

Quoted 12 lines
---
 drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c +0 -0
index 3ca5139f1273..de182185fe1f 100644

drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c line 30

Quoted 8 lines
drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c +2 -0
@@ -23,6 +23,8 @@
  *
  */
 
+#include <linux/slab.h>
+
 #include "dm_services.h"
 #include "dc.h"
 

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 9ad314e5-1a6f-f17f-ac1c-ec33aed2912e-5C7GfCeVMHo@public.gmane.org

#4 lore raw
Quoted 6 lines · Harry Wentland
Quoted 1 line · Alex Deucher

It's apparently needed in some configurations.

Curious which config fails and what compiler errors we get... Sounds like our includes are messed up somewhere.

Not sure exactly:
https://lkml.org/lkml/2019/9/20/998

Alex

Quoted 17 lines

Harry

Quoted 14 lines
---
 drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c +0 -0
index 3ca5139f1273..de182185fe1f 100644
@@ -23,6 +23,8 @@
  *
  */
 
Quoted 6 lines

drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c line 30

Quoted 6 lines
drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c +2 -0
+#include <linux/slab.h>
+
 #include "dm_services.h"
 #include "dc.h"
 

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): CADnq5_NK57bqucbjp9Dn73kKPnhAqEvVHO68vZOvatOZ4pwCyw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

Reviewed-by
#6 lore raw
Quoted 11 lines · Alex Deucher
Quoted 6 lines · Harry Wentland
Quoted 1 line · Alex Deucher

It's apparently needed in some configurations.

Curious which config fails and what compiler errors we get... Sounds like our includes are messed up somewhere.

Not sure exactly:
https://lkml.org/lkml/2019/9/20/998

Just noticed the other dcnXY_resource.c files have that as well.

Harry

Quoted 19 lines

Alex

Quoted 17 lines

Harry

Quoted 14 lines
---
 drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c +0 -0
index 3ca5139f1273..de182185fe1f 100644
@@ -23,6 +23,8 @@
  *
  */
 
Quoted 6 lines
Quoted 6 lines

drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c line 30

Quoted 6 lines
drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c +2 -0
+#include <linux/slab.h>
+
 #include "dm_services.h"
 #include "dc.h"
 

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx