Skip to contentSkip to conversation

drm/nouveau/flcn/qmgr: Move assignment outside if condition

PATCH New [email protected] 1 participant 1 message Jul 11, 2023 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 drm/nouveau/flcn/qmgr: Move assignment outside if condition

Fixes the following checkpatch errors:

ERROR: do not use assignment in if condition

---
 drivers/gpu/drm/nouveau/nvkm/falcon/qmgr.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/nouveau/nvkm/falcon/qmgr.c +2 -1
index a453de341a75..48abdb124326 100644
@@ -73,7 +73,8 @@ nvkm_falcon_qmgr_new(struct nvkm_falcon *falcon,
     struct nvkm_falcon_qmgr *qmgr;
     int i;
 
-    if (!(qmgr = *pqmgr = kzalloc(sizeof(*qmgr), GFP_KERNEL)))
+    qmgr = *pqmgr = kzalloc(sizeof(*qmgr), GFP_KERNEL);
+    if (!qmgr)
         return -ENOMEM;
 
     qmgr->falcon = falcon;