Skip to contentSkip to conversation

configs: dra7xx_evm: Remove ENV_IS_IN_FAT and SPL_ENV_*

PATCH New Faiz Abbas 3 participants 9 messages Feb 19, 2019 – Feb 25, 2019

lore
Share & tools
lore

Faiz Abbas

author
#0 lore raw

PATCH 1/1 configs: dra7xx_evm: Remove ENV_IS_IN_FAT and SPL_ENV_*

With U-boot supporting environment in multiple places, enable only ENV_IS_IN_EMMC in U-boot.

---
 configs/dra7xx_evm_defconfig    | 2 ++
 configs/dra7xx_hs_evm_defconfig | 2 ++
 2 files changed, 4 insertions(+)
configs/dra7xx_evm_defconfig +2 -0
index ef061501ef..07a7973ea2 100644
@@ -36,8 +36,10 @@ CONFIG_OF_LIST="dra7-evm dra72-evm dra72-evm-revc dra71-evm dra76-evm"
 CONFIG_SPL_MULTI_DTB_FIT=y
 CONFIG_SPL_MULTI_DTB_FIT_UNCOMPRESS_SZ=0x9000
 CONFIG_OF_SPL_REMOVE_PROPS="clocks clock-names interrupt-parent"
+# CONFIG_ENV_IS_IN_FAT is not set
 CONFIG_ENV_IS_IN_MMC=y
 CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y
+# CONFIG_SPL_ENV_IS_IN_MMC is not set
 CONFIG_DM=y
 CONFIG_SPL_DM=y
 CONFIG_SPL_DM_DEVICE_REMOVE=y
configs/dra7xx_hs_evm_defconfig +2 -0
index 3cf7659496..8b2a83aad3 100644
@@ -40,8 +40,10 @@ CONFIG_OF_LIST="dra7-evm dra72-evm dra72-evm-revc dra71-evm dra76-evm"
 CONFIG_SPL_MULTI_DTB_FIT=y
 CONFIG_SPL_MULTI_DTB_FIT_UNCOMPRESS_SZ=0x9000
 CONFIG_OF_SPL_REMOVE_PROPS="clocks clock-names interrupt-parent"
+# CONFIG_ENV_IS_IN_FAT is not set
 CONFIG_ENV_IS_IN_MMC=y
 CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y
+# CONFIG_SPL_ENV_IS_IN_MMC is not set
 CONFIG_DM=y
 CONFIG_SPL_DM=y
 CONFIG_SPL_DM_DEVICE_REMOVE=y
Signature · 1 line
2.19.2
#1 lore raw

PATCH 1/1 configs: dra7xx_evm: Remove ENV_IS_IN_FAT and SPL_ENV_*

Quoted 4 lines · Faiz Abbas

With U-boot supporting environment in multiple places, enable only ENV_IS_IN_EMMC in U-boot.

Since we had previously and intentionally enabled FAT over raw MMC location, why the switch back? Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190219/b80edc12/attachment.sig>
author
#2 lore raw

PATCH 1/1 configs: dra7xx_evm: Remove ENV_IS_IN_FAT and SPL_ENV_*

Hi Tom,

Quoted 10 lines · Tom Rini
Quoted 4 lines · Faiz Abbas

With U-boot supporting environment in multiple places, enable only ENV_IS_IN_EMMC in U-boot.

Since we had previously and intentionally enabled FAT over raw MMC location, why the switch back? Thanks!

This commit added this:

commit fb69464eae1ec5aed2ee0e3a9e5533a31ad38bac

Author: Maxime Ripard <[email protected]>
Date:   Tue Jan 23 21:17:01 2018 +0100

env: Allow to build multiple environments in Kconfig

Now that we have everything in place in the code, let's allow to build multiple environments backend through Kconfig.

Looking at the the cover letter for that series
(https://patchwork.ozlabs.org/cover/842057/) , it seems to be an attempt to combat the increasing size of U-boot by permanently moving the environment to FAT partition.

Maybe I am not seeing the whole picture here, but this doesn't make sense to me. Why should we dictate where every board with MMC storage puts their environment? Shouldn't we give the freedom for the board owner to decide that (and work around the ramifications of the increasing size of U-boot)?

dra7xx has two MMC instances. One is a FAT partitioned SD card and the other is a raw (or at most GPT partitioned) eMMC. We have been keeping environment in eMMC to better support android boot requirements and would like to keep it that way.

Thanks,
Faiz

#3 lore raw

PATCH 1/1 configs: dra7xx_evm: Remove ENV_IS_IN_FAT and SPL_ENV_*

Quoted 31 lines · Faiz Abbas

Hi Tom,

Quoted 10 lines · Tom Rini
Quoted 4 lines · Faiz Abbas

With U-boot supporting environment in multiple places, enable only ENV_IS_IN_EMMC in U-boot.

Since we had previously and intentionally enabled FAT over raw MMC location, why the switch back? Thanks!

This commit added this:

commit fb69464eae1ec5aed2ee0e3a9e5533a31ad38bac

Author: Maxime Ripard <[email protected]>
Date:   Tue Jan 23 21:17:01 2018 +0100

env: Allow to build multiple environments in Kconfig

Now that we have everything in place in the code, let's allow to build multiple environments backend through Kconfig.

Quoted 4 lines

Looking at the the cover letter for that series
(https://patchwork.ozlabs.org/cover/842057/) , it seems to be an attempt to combat the increasing size of U-boot by permanently moving the environment to FAT partition.

Well, not exactly. It's about allowing more than one location to be enabled. For example, raw eMMC when that makes sense or FAT file when that makes sense. If Lokesh ack's the change (or passes MAINTAINER over to someone else who acks), OK, we'll do this. But there's intentional reasons we've put it in a file in FAT before, even on this platform. But maybe use cases have changed, and that's fine.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190221/1d82aa0f/attachment.sig>
author
#4 lore raw

PATCH 1/1 configs: dra7xx_evm: Remove ENV_IS_IN_FAT and SPL_ENV_*

Tom,

Quoted 37 lines · Tom Rini
Quoted 31 lines · Faiz Abbas

Hi Tom,

Quoted 10 lines · Tom Rini
Quoted 4 lines · Faiz Abbas

With U-boot supporting environment in multiple places, enable only ENV_IS_IN_EMMC in U-boot.

Since we had previously and intentionally enabled FAT over raw MMC location, why the switch back? Thanks!

This commit added this:

commit fb69464eae1ec5aed2ee0e3a9e5533a31ad38bac

Author: Maxime Ripard <[email protected]>
Date:   Tue Jan 23 21:17:01 2018 +0100

env: Allow to build multiple environments in Kconfig

Now that we have everything in place in the code, let's allow to build multiple environments backend through Kconfig.

Quoted 4 lines

Looking at the the cover letter for that series
(https://patchwork.ozlabs.org/cover/842057/) , it seems to be an attempt to combat the increasing size of U-boot by permanently moving the environment to FAT partition.

Quoted 7 lines

Well, not exactly. It's about allowing more than one location to be enabled. For example, raw eMMC when that makes sense or FAT file when that makes sense. If Lokesh ack's the change (or passes MAINTAINER over to someone else who acks), OK, we'll do this. But there's intentional reasons we've put it in a file in FAT before, even on this platform. But maybe use cases have changed, and that's fine.

Ok. The cover letter said they want to get rid of raw bootmode altogether and that is why I was concerned. Thanks for clearing it up.

Regards,
Faiz

#5 lore raw

PATCH 1/1 configs: dra7xx_evm: Remove ENV_IS_IN_FAT and SPL_ENV_*

Quoted 48 lines · Faiz Abbas

Tom,

Quoted 37 lines · Tom Rini
Quoted 31 lines · Faiz Abbas

Hi Tom,

Quoted 10 lines · Tom Rini
Quoted 4 lines · Faiz Abbas

With U-boot supporting environment in multiple places, enable only ENV_IS_IN_EMMC in U-boot.

Since we had previously and intentionally enabled FAT over raw MMC location, why the switch back? Thanks!

This commit added this:

commit fb69464eae1ec5aed2ee0e3a9e5533a31ad38bac

Author: Maxime Ripard <[email protected]>
Date:   Tue Jan 23 21:17:01 2018 +0100

env: Allow to build multiple environments in Kconfig

Now that we have everything in place in the code, let's allow to build multiple environments backend through Kconfig.

Quoted 4 lines

Looking at the the cover letter for that series
(https://patchwork.ozlabs.org/cover/842057/) , it seems to be an attempt to combat the increasing size of U-boot by permanently moving the environment to FAT partition.

Quoted 7 lines

Well, not exactly. It's about allowing more than one location to be enabled. For example, raw eMMC when that makes sense or FAT file when that makes sense. If Lokesh ack's the change (or passes MAINTAINER over to someone else who acks), OK, we'll do this. But there's intentional reasons we've put it in a file in FAT before, even on this platform. But maybe use cases have changed, and that's fine.

Quoted 2 lines

Ok. The cover letter said they want to get rid of raw bootmode altogether and that is why I was concerned. Thanks for clearing it up.

If EMMC is the already the first in the list for saving env, then we don't need this change right?

Thanks and regards,
Lokesh

Quoted 4 lines

Regards,
Faiz

author
#6 lore raw

PATCH 1/1 configs: dra7xx_evm: Remove ENV_IS_IN_FAT and SPL_ENV_*

Lokesh,

Quoted 51 lines · Lokesh Vutla
Quoted 48 lines · Faiz Abbas

Tom,

Quoted 44 lines · Tom Rini
Quoted 31 lines · Faiz Abbas

Hi Tom,

Quoted 10 lines · Tom Rini
Quoted 4 lines · Faiz Abbas

With U-boot supporting environment in multiple places, enable only ENV_IS_IN_EMMC in U-boot.

Since we had previously and intentionally enabled FAT over raw MMC location, why the switch back? Thanks!

This commit added this:

commit fb69464eae1ec5aed2ee0e3a9e5533a31ad38bac

Author: Maxime Ripard <[email protected]>
Date:   Tue Jan 23 21:17:01 2018 +0100

env: Allow to build multiple environments in Kconfig

Now that we have everything in place in the code, let's allow to build multiple environments backend through Kconfig.

Quoted 4 lines

Looking at the the cover letter for that series
(https://patchwork.ozlabs.org/cover/842057/) , it seems to be an attempt to combat the increasing size of U-boot by permanently moving the environment to FAT partition.

Well, not exactly. It's about allowing more than one location to be enabled. For example, raw eMMC when that makes sense or FAT file when that makes sense. If Lokesh ack's the change (or passes MAINTAINER over to someone else who acks), OK, we'll do this. But there's intentional reasons we've put it in a file in FAT before, even on this platform. But maybe use cases have changed, and that's fine.

Quoted 6 lines
Quoted 2 lines

Ok. The cover letter said they want to get rid of raw bootmode altogether and that is why I was concerned. Thanks for clearing it up.

If EMMC is the already the first in the list for saving env, then we don't need this change right?

Its not the first in list. It always tries to look for FAT first and then EMMC.

Thanks,
Faiz

#7 lore raw

PATCH 1/1 configs: dra7xx_evm: Remove ENV_IS_IN_FAT and SPL_ENV_*

Quoted 57 lines · Faiz Abbas

Lokesh,

Quoted 54 lines · Lokesh Vutla
Quoted 50 lines · Faiz Abbas

Tom,

Quoted 37 lines · Tom Rini
Quoted 31 lines · Faiz Abbas

Hi Tom,

Quoted 10 lines · Tom Rini
Quoted 4 lines · Faiz Abbas

With U-boot supporting environment in multiple places, enable only ENV_IS_IN_EMMC in U-boot.

Since we had previously and intentionally enabled FAT over raw MMC location, why the switch back? Thanks!

This commit added this:

commit fb69464eae1ec5aed2ee0e3a9e5533a31ad38bac

Author: Maxime Ripard <[email protected]>
Date:   Tue Jan 23 21:17:01 2018 +0100

env: Allow to build multiple environments in Kconfig

Now that we have everything in place in the code, let's allow to build multiple environments backend through Kconfig.

Quoted 4 lines

Looking at the the cover letter for that series
(https://patchwork.ozlabs.org/cover/842057/) , it seems to be an attempt to combat the increasing size of U-boot by permanently moving the environment to FAT partition.

Quoted 7 lines

Well, not exactly. It's about allowing more than one location to be enabled. For example, raw eMMC when that makes sense or FAT file when that makes sense. If Lokesh ack's the change (or passes MAINTAINER over to someone else who acks), OK, we'll do this. But there's intentional reasons we've put it in a file in FAT before, even on this platform. But maybe use cases have changed, and that's fine.

Ok. The cover letter said they want to get rid of raw bootmode altogether and that is why I was concerned. Thanks for clearing it up.

Quoted 6 lines
Quoted 3 lines

If EMMC is the already the first in the list for saving env, then we don't need this change right?

Its not the first in list. It always tries to look for FAT first and then EMMC.

okay. We have android requirements to save env in EMMC. So I am okay with this change. Also do not drop env from SPL. Falcon boot might require it.

Thanks and regards,
Lokesh

Quoted 4 lines

Thanks,
Faiz

author
#8 lore raw

PATCH 1/1 configs: dra7xx_evm: Remove ENV_IS_IN_FAT and SPL_ENV_*

Hi Lokesh,

Quoted 64 lines · Lokesh Vutla
Quoted 61 lines · Faiz Abbas

Lokesh,

Quoted 57 lines · Lokesh Vutla
Quoted 48 lines · Faiz Abbas

Tom,

Quoted 37 lines · Tom Rini
Quoted 31 lines · Faiz Abbas

Hi Tom,

Quoted 10 lines · Tom Rini
Quoted 4 lines · Faiz Abbas

With U-boot supporting environment in multiple places, enable only ENV_IS_IN_EMMC in U-boot.

Since we had previously and intentionally enabled FAT over raw MMC location, why the switch back? Thanks!

This commit added this:

commit fb69464eae1ec5aed2ee0e3a9e5533a31ad38bac

Author: Maxime Ripard <[email protected]>
Date:   Tue Jan 23 21:17:01 2018 +0100

env: Allow to build multiple environments in Kconfig

Now that we have everything in place in the code, let's allow to build multiple environments backend through Kconfig.

Quoted 4 lines

Looking at the the cover letter for that series
(https://patchwork.ozlabs.org/cover/842057/) , it seems to be an attempt to combat the increasing size of U-boot by permanently moving the environment to FAT partition.

Quoted 7 lines

Well, not exactly. It's about allowing more than one location to be enabled. For example, raw eMMC when that makes sense or FAT file when that makes sense. If Lokesh ack's the change (or passes MAINTAINER over to someone else who acks), OK, we'll do this. But there's intentional reasons we've put it in a file in FAT before, even on this platform. But maybe use cases have changed, and that's fine.

Quoted 2 lines

Ok. The cover letter said they want to get rid of raw bootmode altogether and that is why I was concerned. Thanks for clearing it up.

If EMMC is the already the first in the list for saving env, then we don't need this change right?

Quoted 6 lines
Quoted 2 lines

Its not the first in list. It always tries to look for FAT first and then EMMC.

okay. We have android requirements to save env in EMMC. So I am okay with this change. Also do not drop env from SPL. Falcon boot might require it.

Ok. Removing in v2.

Thanks,
Faiz