Skip to contentSkip to conversation

scsi: qla4xxx: Convert snprintf to scnprintf

PATCH In review [email protected] 2 participants 2 messages Jul 17, 2023 – Jul 19, 2023 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 scsi: qla4xxx: Convert snprintf to scnprintf

Fix the following coccicheck warnings:

./drivers/scsi/qla4xxx/ql4_attr.c:200:8-16: WARNING: use scnprintf or sprintf ./drivers/scsi/qla4xxx/ql4_attr.c:273:8-16: WARNING: use scnprintf or sprintf ./drivers/scsi/qla4xxx/ql4_attr.c:281:8-16: WARNING: use scnprintf or sprintf ./drivers/scsi/qla4xxx/ql4_attr.c:303:8-16: WARNING: use scnprintf or sprintf ./drivers/scsi/qla4xxx/ql4_attr.c:210:8-16: WARNING: use scnprintf or sprintf ./drivers/scsi/qla4xxx/ql4_attr.c:264:8-16: WARNING: use scnprintf or sprintf ./drivers/scsi/qla4xxx/ql4_attr.c:312:8-16: WARNING: use scnprintf or sprintf ./drivers/scsi/qla4xxx/ql4_attr.c:159:9-17: WARNING: use scnprintf or sprintf ./drivers/scsi/qla4xxx/ql4_attr.c:256:8-16: WARNING: use scnprintf or sprintf ./drivers/scsi/qla4xxx/ql4_attr.c:247:8-16: WARNING: use scnprintf or sprintf ./drivers/scsi/qla4xxx/ql4_attr.c:181:8-16: WARNING: use scnprintf or sprintf ./drivers/scsi/qla4xxx/ql4_attr.c:190:8-16: WARNING: use scnprintf or sprintf ./drivers/scsi/qla4xxx/ql4_attr.c:223:8-16: WARNING: use scnprintf or sprintf ./drivers/scsi/qla4xxx/ql4_attr.c:235:8-16: WARNING: use scnprintf or sprintf ./drivers/scsi/qla4xxx/ql4_attr.c:173:8-16: WARNING: use scnprintf or sprintf

---
 drivers/scsi/qla4xxx/ql4_attr.c | 30 +++++++++++++++---------------
 1 file changed, 15 insertions(+), 15 deletions(-)
drivers/scsi/qla4xxx/ql4_attr.c +15 -15
index abfa6ef60480..6ab578443e12 100644
@@ -156,7 +156,7 @@ qla4xxx_fw_version_show(struct device *dev,
     struct scsi_qla_host *ha = to_qla_host(class_to_shost(dev));
 
     if (is_qla80XX(ha))
-        return snprintf(buf, PAGE_SIZE, "%d.%02d.%02d (%x)\n",
+        return scnprintf(buf, PAGE_SIZE, "%d.%02d.%02d (%x)\n",
                 ha->fw_info.fw_major, ha->fw_info.fw_minor,
                 ha->fw_info.fw_patch, ha->fw_info.fw_build);
     else
@@ -170,7 +170,7 @@ qla4xxx_serial_num_show(struct device *dev, struct device_attribute *attr,
             char *buf)
 {
     struct scsi_qla_host *ha = to_qla_host(class_to_shost(dev));
-    return snprintf(buf, PAGE_SIZE, "%s\n", ha->serial_number);
+    return scnprintf(buf, PAGE_SIZE, "%s\n", ha->serial_number);
 }
 
 static ssize_t
@@ -178,7 +178,7 @@ qla4xxx_iscsi_version_show(struct device *dev, struct device_attribute *attr,
                char *buf)
 {
     struct scsi_qla_host *ha = to_qla_host(class_to_shost(dev));
-    return snprintf(buf, PAGE_SIZE, "%d.%02d\n", ha->fw_info.iscsi_major,
+    return scnprintf(buf, PAGE_SIZE, "%d.%02d\n", ha->fw_info.iscsi_major,
             ha->fw_info.iscsi_minor);
 }
 
@@ -187,7 +187,7 @@ qla4xxx_optrom_version_show(struct device *dev, struct device_attribute *attr,
                 char *buf)
 {
     struct scsi_qla_host *ha = to_qla_host(class_to_shost(dev));
-    return snprintf(buf, PAGE_SIZE, "%d.%02d.%02d.%02d\n",
+    return scnprintf(buf, PAGE_SIZE, "%d.%02d.%02d.%02d\n",
             ha->fw_info.bootload_major, ha->fw_info.bootload_minor,
             ha->fw_info.bootload_patch, ha->fw_info.bootload_build);
 }
@@ -197,7 +197,7 @@ qla4xxx_board_id_show(struct device *dev, struct device_attribute *attr,
               char *buf)
 {
     struct scsi_qla_host *ha = to_qla_host(class_to_shost(dev));
-    return snprintf(buf, PAGE_SIZE, "0x%08X\n", ha->board_id);
+    return scnprintf(buf, PAGE_SIZE, "0x%08X\n", ha->board_id);
 }
 
 static ssize_t
@@ -207,7 +207,7 @@ qla4xxx_fw_state_show(struct device *dev, struct device_attribute *attr,
     struct scsi_qla_host *ha = to_qla_host(class_to_shost(dev));
 
     qla4xxx_get_firmware_state(ha);
-    return snprintf(buf, PAGE_SIZE, "0x%08X%8X\n", ha->firmware_state,
+    return scnprintf(buf, PAGE_SIZE, "0x%08X%8X\n", ha->firmware_state,
             ha->addl_fw_state);
 }
 
@@ -220,7 +220,7 @@ qla4xxx_phy_port_cnt_show(struct device *dev, struct device_attribute *attr,
     if (is_qla40XX(ha))
         return -ENOSYS;
 
-    return snprintf(buf, PAGE_SIZE, "0x%04X\n", ha->phy_port_cnt);
+    return scnprintf(buf, PAGE_SIZE, "0x%04X\n", ha->phy_port_cnt);
 }
 
 static ssize_t
@@ -232,7 +232,7 @@ qla4xxx_phy_port_num_show(struct device *dev, struct device_attribute *attr,
     if (is_qla40XX(ha))
         return -ENOSYS;
 
-    return snprintf(buf, PAGE_SIZE, "0x%04X\n", ha->phy_port_num);
+    return scnprintf(buf, PAGE_SIZE, "0x%04X\n", ha->phy_port_num);
 }
 
 static ssize_t
@@ -244,7 +244,7 @@ qla4xxx_iscsi_func_cnt_show(struct device *dev, struct device_attribute *attr,
     if (is_qla40XX(ha))
         return -ENOSYS;
 
-    return snprintf(buf, PAGE_SIZE, "0x%04X\n", ha->iscsi_pci_func_cnt);
+    return scnprintf(buf, PAGE_SIZE, "0x%04X\n", ha->iscsi_pci_func_cnt);
 }
 
 static ssize_t
@@ -253,7 +253,7 @@ qla4xxx_hba_model_show(struct device *dev, struct device_attribute *attr,
 {
     struct scsi_qla_host *ha = to_qla_host(class_to_shost(dev));
 
-    return snprintf(buf, PAGE_SIZE, "%s\n", ha->model_name);
+    return scnprintf(buf, PAGE_SIZE, "%s\n", ha->model_name);
 }
 
 static ssize_t
@@ -261,7 +261,7 @@ qla4xxx_fw_timestamp_show(struct device *dev, struct device_attribute *attr,
               char *buf)
 {
     struct scsi_qla_host *ha = to_qla_host(class_to_shost(dev));
-    return snprintf(buf, PAGE_SIZE, "%s %s\n", ha->fw_info.fw_build_date,
+    return scnprintf(buf, PAGE_SIZE, "%s %s\n", ha->fw_info.fw_build_date,
             ha->fw_info.fw_build_time);
 }
 
@@ -270,7 +270,7 @@ qla4xxx_fw_build_user_show(struct device *dev, struct device_attribute *attr,
                char *buf)
 {
     struct scsi_qla_host *ha = to_qla_host(class_to_shost(dev));
-    return snprintf(buf, PAGE_SIZE, "%s\n", ha->fw_info.fw_build_user);
+    return scnprintf(buf, PAGE_SIZE, "%s\n", ha->fw_info.fw_build_user);
 }
 
 static ssize_t
@@ -278,7 +278,7 @@ qla4xxx_fw_ext_timestamp_show(struct device *dev, struct device_attribute *attr,
                   char *buf)
 {
     struct scsi_qla_host *ha = to_qla_host(class_to_shost(dev));
-    return snprintf(buf, PAGE_SIZE, "%s\n", ha->fw_info.extended_timestamp);
+    return scnprintf(buf, PAGE_SIZE, "%s\n", ha->fw_info.extended_timestamp);
 }
 
 static ssize_t
@@ -300,7 +300,7 @@ qla4xxx_fw_load_src_show(struct device *dev, struct device_attribute *attr,
         break;
     }
 
-    return snprintf(buf, PAGE_SIZE, "%s\n", load_src);
+    return scnprintf(buf, PAGE_SIZE, "%s\n", load_src);
 }
 
 static ssize_t
@@ -309,7 +309,7 @@ qla4xxx_fw_uptime_show(struct device *dev, struct device_attribute *attr,
 {
     struct scsi_qla_host *ha = to_qla_host(class_to_shost(dev));
     qla4xxx_about_firmware(ha);
-    return snprintf(buf, PAGE_SIZE, "%u.%u secs\n", ha->fw_uptime_secs,
+    return scnprintf(buf, PAGE_SIZE, "%u.%u secs\n", ha->fw_uptime_secs,
             ha->fw_uptime_msecs);
 }
#2 lore raw
Quoted 33 lines · On Mon, Jul 17, 2023 at 02:18:31PM +0800, [email protected] wrote:

Fix the following coccicheck warnings:

./drivers/scsi/qla4xxx/ql4_attr.c:200:8-16: WARNING: use scnprintf or sprintf
./drivers/scsi/qla4xxx/ql4_attr.c:273:8-16: WARNING: use scnprintf or sprintf
./drivers/scsi/qla4xxx/ql4_attr.c:281:8-16: WARNING: use scnprintf or sprintf
./drivers/scsi/qla4xxx/ql4_attr.c:303:8-16: WARNING: use scnprintf or sprintf
./drivers/scsi/qla4xxx/ql4_attr.c:210:8-16: WARNING: use scnprintf or sprintf
./drivers/scsi/qla4xxx/ql4_attr.c:264:8-16: WARNING: use scnprintf or sprintf
./drivers/scsi/qla4xxx/ql4_attr.c:312:8-16: WARNING: use scnprintf or sprintf
./drivers/scsi/qla4xxx/ql4_attr.c:159:9-17: WARNING: use scnprintf or sprintf
./drivers/scsi/qla4xxx/ql4_attr.c:256:8-16: WARNING: use scnprintf or sprintf
./drivers/scsi/qla4xxx/ql4_attr.c:247:8-16: WARNING: use scnprintf or sprintf
./drivers/scsi/qla4xxx/ql4_attr.c:181:8-16: WARNING: use scnprintf or sprintf
./drivers/scsi/qla4xxx/ql4_attr.c:190:8-16: WARNING: use scnprintf or sprintf
./drivers/scsi/qla4xxx/ql4_attr.c:223:8-16: WARNING: use scnprintf or sprintf
./drivers/scsi/qla4xxx/ql4_attr.c:235:8-16: WARNING: use scnprintf or sprintf
./drivers/scsi/qla4xxx/ql4_attr.c:173:8-16: WARNING: use scnprintf or sprintf

Quoted 1 line

These should all be converted to sysfs_emit, and not scnprintf.

Thanks,
- Chris Leech