Skip to contentSkip to conversation

Import a new test, jitterz

PATCH Superseded [email protected] 2 participants 3 messages Apr 1, 2020 – Apr 18, 2020 Kbuild

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Import a new test, jitterz

From: Tom Rix <[email protected]>

jitterz is a program for measuring system jitter.

It is a rewrite of sysjitter
https://github.com/alexeiz/sysjitter

The upstream location of jitterz is
https://github.com/trixirt/jitterz

---
 Makefile              |   7 +-
 src/jitterz/jitterz.c | 329 ++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 335 insertions(+), 1 deletion(-)
 create mode 100644 src/jitterz/jitterz.c
Makefile +6 -1
index 05fc5ed..2059389 100644
@@ -17,7 +17,8 @@ sources = cyclictest.c \
 	  cyclicdeadline.c \
 	  deadline_test.c \
 	  queuelat.c \
-	  ssdd.c
+	  ssdd.c \
+	  jitterz.c
 
 TARGETS = $(sources:.c=)
 LIBS	= -lrt -lpthread
@@ -96,6 +97,7 @@ VPATH	+= src/hackbench:
 VPATH	+= src/sched_deadline:
 VPATH	+= src/queuelat:	
 VPATH	+= src/ssdd:
+VPATH	+= src/jitterz:
 
 $(OBJDIR)/%.o: %.c | $(OBJDIR)
 	$(CC) -D VERSION=$(VERSION) -c $< $(CFLAGS) $(CPPFLAGS) -o $@
@@ -163,6 +165,9 @@ queuelat: $(OBJDIR)/queuelat.o $(OBJDIR)/librttest.a
 ssdd: $(OBJDIR)/ssdd.o $(OBJDIR)/librttest.a
 	$(CC) $(CFLAGS) $(LDFLAGS) -o $@ $< $(LIBS) $(RTTESTLIB)
 
+jitterz: $(OBJDIR)/jitterz.o
+	$(CC) $(CFLAGS) $(LDFLAGS) -o $@ $< $(LIBS)
+
 %.8.gz: %.8
 	gzip -nc $< > $@
 
src/jitterz/jitterz.c new file +329 -0

329 lines not on this page · raw message

Signature · 1 line
2.18.1
#1 lore raw

Tom,

Quoted 3 lines · [email protected] writes:

From: Tom Rix <[email protected]>

jitterz is a program for measuring system jitter.

The exact purpose of this is?

Quoted 4 lines
src/jitterz/jitterz.c new file +4 -0
+
+#define CHECK_LOST_TIME()					\
+	do {							\
+		if (d >= dt_min) {				\

src/jitterz/jitterz.c line 49

Quoted 10 lines
src/jitterz/jitterz.c new file +10 -0
+			lt += d;				\
+			for (j = 16; j > 0; j--) {		\
+				if (d >= b[j - 1].s) {		\
+					b[j - 1].c =		\
+						b[j - 1].c + 1;	\
+					break;			\
+				}				\
+			}					\
+		}						\
+	} while (0)						\

Aside of having a \ at the last line, macros which rely on variable names at the call site are broken to begin with. What's so magic to hide this in a macro instead of writing a proper function?

src/jitterz/jitterz.c line 60

Quoted 10 lines
src/jitterz/jitterz.c new file +10 -0
+static inline uint64_t tsc(void)
+{
+	uint64_t ret = 0;
+	uint32_t l, h;
+
+	__asm__ __volatile__("lfence");
+	__asm__ __volatile__("rdtsc" : "=a"(l), "=d"(h));
+	ret = ((uint64_t)h << 32) | l;
+	return ret;
+}

Having x86 specific code in a generic test suite is a non starter.

Quoted 16 lines
src/jitterz/jitterz.c new file +16 -0
+static int move_to_core(int core_i)
+{
+	cpu_set_t cpus;
+
+	CPU_ZERO(&cpus);
+	CPU_SET(core_i, &cpus);
+	return sched_setaffinity(0, sizeof(cpus), &cpus);
+}
+
+static int set_sched(void)
+{
+	struct sched_param p = { 0 };
+
+	p.sched_priority = priority;
+	return sched_setscheduler(0, policy, &p);
+}

src/jitterz/jitterz.c line 87

Quoted 10 lines
src/jitterz/jitterz.c new file +10 -0
+
+static long read_cpuinfo_cur_freq(int core_i)
+{
+	uint64_t fs = -1;
+	char path[80];
+	struct stat sb;
+	int i;
+	char *freq[2] = {
+		"cpuinfo_cur_freq",
+		/* assumes a busy wait will be run at the max freq */

Assumptions in tools which are meant to provide useful output are really not useful at all.

src/jitterz/jitterz.c line 99

Quoted 12 lines
src/jitterz/jitterz.c new file +12 -0
+		"cpuinfo_max_freq",
+	};
+	for (i = 0; i < 2; i++) {
+		snprintf(path, 80,
+			 "/sys/devices/system/cpu/cpu%d/cpufreq/%s",
+			 core_i, freq[1]);
+		if (!stat(path, &sb)) {
+			FILE *f = 0;
+
+			f = fopen(path, "rt");
+			if (f) {
+				fscanf(f, "%lu", &fs);

That definitely has never seen a 32bit compile.

src/jitterz/jitterz.c line 109

Quoted 10 lines
src/jitterz/jitterz.c new file +10 -0
+				fclose(f);
+			} else {
+				perror(path);
+			}
+		} else {
+			perror(path);
+		}
+	}
+
+	if (fs == (uint64_t) -1) {

So here you have a typecast but at the place where this is initialized this is not required, right?

Quoted 97 lines
src/jitterz/jitterz.c new file +97 -0
+		printf("Error reading CPU frequency for core %d\n", core_i);
+		exit(1);
+	}
+	return fs;
+}
+
+int main(int argc, char **argv)
+{
+	int max_cpus = sysconf(_SC_NPROCESSORS_ONLN);
+	struct timespec tvs, tve;
+	double sec;
+	uint64_t fs, fe, fr;
+	unsigned int i, j, rt = 60;
+	uint64_t dt = 1500;
+	struct bucket {
+		uint64_t s;
+		uint64_t c;
+	} b[16];
+	uint64_t frs, fre, lt;
+
+	process_options(argc, argv, max_cpus);
+
+	/* return of this function must be tested for success */
+	if (move_to_core(cpu) != 0) {
+		printf("Error while setting thread affinity to cpu %d!", cpu);
+		exit(1);
+	}
+	if (set_sched() != 0) {
+		printf("Error while setting %s policy, priority %d!",
+		       policyname(policy), priority);
+		exit(1);
+	}
+
+	fr = fs = 0;
+	fe = 1;
+	while (fs != fe) {
+retry:
+		if (!fr) {
+			fs = read_cpuinfo_cur_freq(cpu);
+			fe = 0;
+		} else {
+			fs = fr;
+		}
+		uint64_t dt_min = (dt * fs) / 1000000;
+
+		lt = 0;
+		for (j = 0; j < 16; j++) {
+			b[j].c = 0;
+			if (j == 0)
+				b[j].s = dt_min;
+			else
+				b[j].s = b[j - 1].s * 2;
+		}
+		fs *= 1000;
+
+		frs = tsc();
+		clock_gettime(CLOCK_MONOTONIC_RAW, &tvs);
+
+		for (i = 0; i < rt; i++) {
+			uint64_t s, e, so;
+
+			s = tsc();
+			e = s;
+			e += fs;
+			if (e < s)
+				goto retry;
+			so = s;
+
+			while (1) {
+				uint64_t d;
+
+				s = tsc();
+				if (s == so)
+					continue;
+
+				d = s - so;
+				CHECK_LOST_TIME();
+				if (s >= e)
+					break;
+				so = s;
+			}
+		}
+		fre = tsc();
+		clock_gettime(CLOCK_MONOTONIC_RAW, &tve);
+		sec = tve.tv_sec - tvs.tv_sec +
+		      (tve.tv_nsec - tvs.tv_nsec) / 1e9;
+		if ((fabs(sec - rt) / (double)rt) > 0.01) {
+			if (fre > frs) {
+				fr = (fre - frs) / (1000 * sec);
+				fe = fr * 1000;
+			}
+			goto retry;
+		}
+		if (!fr) {
+			fe = read_cpuinfo_cur_freq(cpu);
+			fe *= 1000;
+		}

src/jitterz/jitterz.c line 328

Quoted 10 lines
src/jitterz/jitterz.c new file +10 -0
+	}
+	for (j = 0; j < 16; j++)
+		printf("%lu\n", b[j].c);
+
+	if (lt != fs) {
+		printf("Lost time %f\n", (double)lt / (double)fs);
+		return 1;
+	}
+
+	return 0;

As the above is completely unreadable gibberish I can only assume that I wasted time staring at a well done April 1st joke :)

Thanks,

tglx

author
#2 lore raw

What changed.

A general cleanup of test.

A man page added.

More comments.

Addressing issues, see below.

Quoted 7 lines · Thomas Gleixner

The exact purpose of this is?

src/jitterz/jitterz.c line 39

Quoted 4 lines
src/jitterz/jitterz.c new file +4 -0
+
+#define CHECK_LOST_TIME()					\
+	do {							\
+		if (d >= dt_min) {				\

This is the update_buckets call, if time difference is greater than a threshold it is added to a bucket.

Quoted 3 lines

Aside of having a \ at the last line, macros which rely on variable names at the call site are broken to begin with. What's so magic to hide this in a macro instead of writing a proper function?

This was changed to a function.

Quoted 11 lines

src/jitterz/jitterz.c line 60

Quoted 10 lines
src/jitterz/jitterz.c new file +10 -0
+static inline uint64_t tsc(void)
+{
+	uint64_t ret = 0;
+	uint32_t l, h;
+
+	__asm__ __volatile__("lfence");
+	__asm__ __volatile__("rdtsc" : "=a"(l), "=d"(h));
+	ret = ((uint64_t)h << 32) | l;
+	return ret;
+}

Having x86 specific code in a generic test suite is a non starter.

If-def added to build of x86, else provide a runtime error.

Quoted 5 lines
src/jitterz/jitterz.c new file +3 -0
+	char *freq[2] = {
+		"cpuinfo_cur_freq",
+		/* assumes a busy wait will be run at the max freq */

Assumptions in tools which are meant to provide useful output are really not useful at all.

These frequencies are only starting points, the test recalculates the frequency at runtime.

Quoted 3 lines

src/jitterz/jitterz.c line 99

Quoted 2 lines
src/jitterz/jitterz.c new file +2 -0
+			if (f) {
+				fscanf(f, "%lu", &fs);

That definitely has never seen a 32bit compile.

Changed to use PRIu64 macro and verified on i386 compile.

Quoted 4 lines
(quoted diff) +2 -0
+
+	if (fs == (uint64_t) -1) {

So here you have a typecast but at the place where this is initialized this is not required, right?

Typecast removed.

Quoted 4 lines

src/jitterz/jitterz.c line 328

Quoted 2 lines
src/jitterz/jitterz.c new file +1 -0
+	return 0;

As the above is completely unreadable gibberish I can only assume that I wasted time staring at a well done April 1st joke :)

Rewrite + comments should make the understanding the main loop easier.

Tom