ocfs2: fix ocfs2 read inode data panic in ocfs2_iget
PATCH 1/1 ocfs2: fix ocfs2 read inode data panic in ocfs2_iget
In some cases, the function ocfs2_iget read the data of inode, which has been deleted for some reason. That will make the system panic. So We should judge whether this inode has been deleted, and tell the caller that the inode is a bad inode.
[283465.542049] OCFS2: ERROR (device sdp): ocfs2_validate_inode_block:
Invalid dinode #580640: OCFS2_VALID_FL not set
[283465.545490] Kernel panic - not syncing: OCFS2: (device sdp): panic forced
after error
[283465.546889] CPU: 5 PID: 12416 Comm: nfsd Tainted: G W 4.1.12-124.18.6.el6uek.bug28762940v3.x86_64 #2 [283465.548382] Hardware name: VMware, Inc. VMware Virtual Platform/440BX Desktop Reference Platform, BIOS 6.00 09/21/2015 [283465.549657] 0000000000000000 ffff8800a56fb7b8 ffffffff816e839c ffffffffa0514758 [283465.550392] 000000000008dc20 ffff8800a56fb838 ffffffff816e62d3 0000000000000008 [283465.551056] ffff880000000010 ffff8800a56fb848 ffff8800a56fb7e8 ffff88005df9f000 [283465.551710] Call Trace: [283465.552516] [<ffffffff816e839c>] dump_stack+0x63/0x81 [283465.553291] [<ffffffff816e62d3>] panic+0xcb/0x21b [283465.554037] [<ffffffffa04e66b0>] ocfs2_handle_error+0xf0/0xf0 [ocfs2] [283465.554882] [<ffffffffa04e7737>] __ocfs2_error+0x67/0x70 [ocfs2] [283465.555768] [<ffffffffa049c0f9>] ocfs2_validate_inode_block+0x229/0x230 [ocfs2] [283465.556683] [<ffffffffa047bcbc>] ocfs2_read_blocks+0x46c/0x7b0 [ocfs2] [283465.557408] [<ffffffffa049bed0>] ? ocfs2_inode_cache_io_unlock+0x20/0x20 [ocfs2] [283465.557973] [<ffffffffa049f0eb>] ocfs2_read_inode_block_full+0x3b/0x60 [ocfs2] [283465.558525] [<ffffffffa049f5ba>] ocfs2_iget+0x4aa/0x880 [ocfs2] [283465.559082] [<ffffffffa049146e>] ocfs2_get_parent+0x9e/0x220 [ocfs2] [283465.559622] [<ffffffff81297c05>] reconnect_path+0xb5/0x300 [283465.560156] [<ffffffff81297f46>] exportfs_decode_fh+0xf6/0x2b0 [283465.560708] [<ffffffffa062faf0>] ? nfsd_proc_getattr+0xa0/0xa0 [nfsd] [283465.561262] [<ffffffff810a8196>] ? prepare_creds+0x26/0x110 [283465.561932] [<ffffffffa0630860>] fh_verify+0x350/0x660 [nfsd] [283465.562862] [<ffffffffa0637804>] ? nfsd_cache_lookup+0x44/0x630 [nfsd] [283465.563697] [<ffffffffa063a8b9>] nfsd3_proc_getattr+0x69/0xf0 [nfsd] [283465.564510] [<ffffffffa062cf60>] nfsd_dispatch+0xe0/0x290 [nfsd] [283465.565358] [<ffffffffa05eb892>] ? svc_tcp_adjust_wspace+0x12/0x30 [sunrpc] [283465.566272] [<ffffffffa05ea652>] svc_process_common+0x412/0x6a0 [sunrpc] [283465.567155] [<ffffffffa05eaa03>] svc_process+0x123/0x210 [sunrpc] [283465.568020] [<ffffffffa062c90f>] nfsd+0xff/0x170 [nfsd] [283465.568962] [<ffffffffa062c810>] ? nfsd_destroy+0x80/0x80 [nfsd] [283465.570112] [<ffffffff810a622b>] kthread+0xcb/0xf0 [283465.571099] [<ffffffff810a6160>] ? kthread_create_on_node+0x180/0x180 [283465.572114] [<ffffffff816f11b8>] ret_from_fork+0x58/0x90 [283465.573156] [<ffffffff810a6160>] ? kthread_create_on_node+0x180/0x180 --- fs/ocfs2/inode.c | 22 ++++++++++++++++++++++ 1 files changed, 22 insertions(+), 0 deletions(-)
fs/ocfs2/inode.c +22 -0
@@ -513,6 +513,16 @@ static int ocfs2_read_locked_inode(struct inode *inode, status = -EINVAL ; fe = (struct ocfs2_dinode *) bh->b_data; +/* +* In some cases, this inode has been deleted, but the data of +* inode is read directly. So We should judge whether this inode +* has been deleted. +* */ +if (unlikely (fe->i_dtime !=0 )) { +mlog (ML_NOTICE ,"The inode %llu has been deleted\n" , +le64_to_cpu (fe->i_blkno)); + goto bail; + }/* * This is a code bug. Right now the caller needs to * understand whether it is asking for a system file inode or
@@ -1331,6 +1341,18 @@ int ocfs2_validate_inode_block(struct super_block *sb,BUG_ON (!buffer_uptodate (bh)); +/* +* In some cases, this inode has been deleted, but the data of +* inode is read directly. This is not a data corruption.So +* We should judge whether this inode has been deleted. +* */ +if (unlikely (di->i_dtime !=0 )) { + rc = -EINVAL ; +mlog (ML_NOTICE ,"The inode %llu has been deleted\n" , +le64_to_cpu (di->i_blkno)); + goto bail; + } +/* * If the ecc fails, we return the error but otherwise * leave the filesystem running. We know any error is
Signature · 1 line
1.7.1
PATCH 1/1 ocfs2: fix ocfs2 read inode data panic in ocfs2_iget
Quoted 8 lines · Shuning Zhang
In some cases, the function
ocfs2_igetread the data of inode, which has been deleted for some reason. That will make the system panic. So We should judge whether this inode has been deleted, and tell the caller that the inode is a bad inode.[283465.542049] OCFS2: ERROR (device sdp): ocfs2_validate_inode_block:Invalid dinode #580640:
OCFS2_VALID_FLnot set
Looks like it is a filesystem corruption bug.
So we'd better find where it is introduced and try to fix it there.
Thanks,
Joseph
Quoted 90 lines
[283465.545490] Kernel panic - not syncing: OCFS2: (device sdp): panic forcedafter error
[283465.546889] CPU: 5 PID: 12416 Comm: nfsd Tainted: G W 4.1.12-124.18.6.el6uek.bug28762940v3.x86_64 #2 [283465.548382] Hardware name: VMware, Inc. VMware Virtual Platform/440BX Desktop Reference Platform, BIOS 6.00 09/21/2015 [283465.549657] 0000000000000000 ffff8800a56fb7b8 ffffffff816e839c ffffffffa0514758 [283465.550392] 000000000008dc20 ffff8800a56fb838 ffffffff816e62d3 0000000000000008 [283465.551056] ffff880000000010 ffff8800a56fb848 ffff8800a56fb7e8 ffff88005df9f000 [283465.551710] Call Trace: [283465.552516] [<ffffffff816e839c>] dump_stack+0x63/0x81 [283465.553291] [<ffffffff816e62d3>] panic+0xcb/0x21b [283465.554037] [<ffffffffa04e66b0>] ocfs2_handle_error+0xf0/0xf0 [ocfs2] [283465.554882] [<ffffffffa04e7737>] __ocfs2_error+0x67/0x70 [ocfs2] [283465.555768] [<ffffffffa049c0f9>] ocfs2_validate_inode_block+0x229/0x230 [ocfs2] [283465.556683] [<ffffffffa047bcbc>] ocfs2_read_blocks+0x46c/0x7b0 [ocfs2] [283465.557408] [<ffffffffa049bed0>] ? ocfs2_inode_cache_io_unlock+0x20/0x20 [ocfs2] [283465.557973] [<ffffffffa049f0eb>] ocfs2_read_inode_block_full+0x3b/0x60 [ocfs2] [283465.558525] [<ffffffffa049f5ba>] ocfs2_iget+0x4aa/0x880 [ocfs2] [283465.559082] [<ffffffffa049146e>] ocfs2_get_parent+0x9e/0x220 [ocfs2] [283465.559622] [<ffffffff81297c05>] reconnect_path+0xb5/0x300 [283465.560156] [<ffffffff81297f46>] exportfs_decode_fh+0xf6/0x2b0 [283465.560708] [<ffffffffa062faf0>] ? nfsd_proc_getattr+0xa0/0xa0 [nfsd] [283465.561262] [<ffffffff810a8196>] ? prepare_creds+0x26/0x110 [283465.561932] [<ffffffffa0630860>] fh_verify+0x350/0x660 [nfsd] [283465.562862] [<ffffffffa0637804>] ? nfsd_cache_lookup+0x44/0x630 [nfsd] [283465.563697] [<ffffffffa063a8b9>] nfsd3_proc_getattr+0x69/0xf0 [nfsd] [283465.564510] [<ffffffffa062cf60>] nfsd_dispatch+0xe0/0x290 [nfsd] [283465.565358] [<ffffffffa05eb892>] ? svc_tcp_adjust_wspace+0x12/0x30 [sunrpc] [283465.566272] [<ffffffffa05ea652>] svc_process_common+0x412/0x6a0 [sunrpc] [283465.567155] [<ffffffffa05eaa03>] svc_process+0x123/0x210 [sunrpc] [283465.568020] [<ffffffffa062c90f>] nfsd+0xff/0x170 [nfsd] [283465.568962] [<ffffffffa062c810>] ? nfsd_destroy+0x80/0x80 [nfsd] [283465.570112] [<ffffffff810a622b>] kthread+0xcb/0xf0 [283465.571099] [<ffffffff810a6160>] ? kthread_create_on_node+0x180/0x180 [283465.572114] [<ffffffff816f11b8>] ret_from_fork+0x58/0x90 [283465.573156] [<ffffffff810a6160>] ? kthread_create_on_node+0x180/0x180 --- fs/ocfs2/inode.c | 22 ++++++++++++++++++++++ 1 files changed, 22 insertions(+), 0 deletions(-)fs/ocfs2/inode.c +22
-0@@ -513,6 +513,16 @@ static int ocfs2_read_locked_inode(struct inode *inode, status = -EINVAL ; fe = (struct ocfs2_dinode *) bh->b_data; +/* +* In some cases, this inode has been deleted, but the data of +* inode is read directly. So We should judge whether this inode +* has been deleted. +* */ +if (unlikely (fe->i_dtime !=0 )) { +mlog (ML_NOTICE ,"The inode %llu has been deleted\n" , +le64_to_cpu (fe->i_blkno)); + goto bail; + }/* * This is a code bug. Right now the caller needs to * understand whether it is asking for a system file inode or @@ -1331,6 +1341,18 @@ int ocfs2_validate_inode_block(struct super_block *sb,BUG_ON (!buffer_uptodate (bh)); +/* +* In some cases, this inode has been deleted, but the data of +* inode is read directly. This is not a data corruption.So +* We should judge whether this inode has been deleted. +* */ +if (unlikely (di->i_dtime !=0 )) { + rc = -EINVAL ; +mlog (ML_NOTICE ,"The inode %llu has been deleted\n" , +le64_to_cpu (di->i_blkno)); + goto bail; + } +/* * If the ecc fails, we return the error but otherwise * leave the filesystem running. We know any error is
PATCH 1/1 ocfs2: fix ocfs2 read inode data panic in ocfs2_iget
Quoted 8 lines · Joseph Qi
Quoted 5 lines · Shuning Zhang
In some cases, the function
ocfs2_igetread the data of inode, which has been deleted for some reason. That will make the system panic. So We should judge whether this inode has been deleted, and tell the caller that the inode is a bad inode.
Quoted 6 lines
Quoted 3 lines
[283465.542049] OCFS2: ERROR (device sdp): ocfs2_validate_inode_block:Invalid dinode #580640:
OCFS2_VALID_FLnot setLooks like it is a filesystem corruption bug.
So we'd better find where it is introduced and try to fix it there.
Agreed, sounds like read-only problem.
Quoted 100 lines
Thanks,
JosephQuoted 80 lines
[283465.545490] Kernel panic - not syncing: OCFS2: (device sdp): panic forcedafter error
[283465.546889] CPU: 5 PID: 12416 Comm: nfsd Tainted: G W 4.1.12-124.18.6.el6uek.bug28762940v3.x86_64 #2 [283465.548382] Hardware name: VMware, Inc. VMware Virtual Platform/440BX Desktop Reference Platform, BIOS 6.00 09/21/2015 [283465.549657] 0000000000000000 ffff8800a56fb7b8 ffffffff816e839c ffffffffa0514758 [283465.550392] 000000000008dc20 ffff8800a56fb838 ffffffff816e62d3 0000000000000008 [283465.551056] ffff880000000010 ffff8800a56fb848 ffff8800a56fb7e8 ffff88005df9f000 [283465.551710] Call Trace: [283465.552516] [<ffffffff816e839c>] dump_stack+0x63/0x81 [283465.553291] [<ffffffff816e62d3>] panic+0xcb/0x21b [283465.554037] [<ffffffffa04e66b0>] ocfs2_handle_error+0xf0/0xf0 [ocfs2] [283465.554882] [<ffffffffa04e7737>] __ocfs2_error+0x67/0x70 [ocfs2] [283465.555768] [<ffffffffa049c0f9>] ocfs2_validate_inode_block+0x229/0x230 [ocfs2] [283465.556683] [<ffffffffa047bcbc>] ocfs2_read_blocks+0x46c/0x7b0 [ocfs2] [283465.557408] [<ffffffffa049bed0>] ? ocfs2_inode_cache_io_unlock+0x20/0x20 [ocfs2] [283465.557973] [<ffffffffa049f0eb>] ocfs2_read_inode_block_full+0x3b/0x60 [ocfs2] [283465.558525] [<ffffffffa049f5ba>] ocfs2_iget+0x4aa/0x880 [ocfs2] [283465.559082] [<ffffffffa049146e>] ocfs2_get_parent+0x9e/0x220 [ocfs2] [283465.559622] [<ffffffff81297c05>] reconnect_path+0xb5/0x300 [283465.560156] [<ffffffff81297f46>] exportfs_decode_fh+0xf6/0x2b0 [283465.560708] [<ffffffffa062faf0>] ? nfsd_proc_getattr+0xa0/0xa0 [nfsd] [283465.561262] [<ffffffff810a8196>] ? prepare_creds+0x26/0x110 [283465.561932] [<ffffffffa0630860>] fh_verify+0x350/0x660 [nfsd] [283465.562862] [<ffffffffa0637804>] ? nfsd_cache_lookup+0x44/0x630 [nfsd] [283465.563697] [<ffffffffa063a8b9>] nfsd3_proc_getattr+0x69/0xf0 [nfsd] [283465.564510] [<ffffffffa062cf60>] nfsd_dispatch+0xe0/0x290 [nfsd] [283465.565358] [<ffffffffa05eb892>] ? svc_tcp_adjust_wspace+0x12/0x30 [sunrpc] [283465.566272] [<ffffffffa05ea652>] svc_process_common+0x412/0x6a0 [sunrpc] [283465.567155] [<ffffffffa05eaa03>] svc_process+0x123/0x210 [sunrpc] [283465.568020] [<ffffffffa062c90f>] nfsd+0xff/0x170 [nfsd] [283465.568962] [<ffffffffa062c810>] ? nfsd_destroy+0x80/0x80 [nfsd] [283465.570112] [<ffffffff810a622b>] kthread+0xcb/0xf0 [283465.571099] [<ffffffff810a6160>] ? kthread_create_on_node+0x180/0x180 [283465.572114] [<ffffffff816f11b8>] ret_from_fork+0x58/0x90 [283465.573156] [<ffffffff810a6160>] ? kthread_create_on_node+0x180/0x180 --- fs/ocfs2/inode.c | 22 ++++++++++++++++++++++ 1 files changed, 22 insertions(+), 0 deletions(-)fs/ocfs2/inode.c +15
-0@@ -513,6 +513,16 @@ static int ocfs2_read_locked_inode(struct inode *inode, status = -EINVAL ; fe = (struct ocfs2_dinode *) bh->b_data; +/* +* In some cases, this inode has been deleted, but the data of +* inode is read directly. So We should judge whether this inode +* has been deleted. +* */ +if (unlikely (fe->i_dtime !=0 )) { +mlog (ML_NOTICE ,"The inode %llu has been deleted\n" , +le64_to_cpu (fe->i_blkno)); + goto bail; + }/* * This is a code bug. Right now the caller needs to * understand whether it is asking for a system file inode or @@ -1331,6 +1341,18 @@ int ocfs2_validate_inode_block(struct super_block *sb,BUG_ON (!buffer_uptodate (bh)); +/* +* In some cases, this inode has been deleted, but the data of +* inode is read directly. This is not a data corruption.So +* We should judge whether this inode has been deleted. +* */ fs/ocfs2/inode.c int ocfs2_validate_inode_block(struct super_block *sb, · line 1358
Quoted 10 lines
fs/ocfs2/inode.c +7
-0+if (unlikely (di->i_dtime !=0 )) { + rc = -EINVAL ; +mlog (ML_NOTICE ,"The inode %llu has been deleted\n" , +le64_to_cpu (di->i_blkno)); + goto bail; + } +/* * If the ecc fails, we return the error but otherwise * leave the filesystem running. We know any error is _______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel at oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel
PATCH 1/1 ocfs2: fix ocfs2 read inode data panic in ocfs2_iget
In reply to Joseph Qi? 2019?03?25? 09:31, Joseph Qi ??:
Quoted 7 lines · Shuning Zhang
Quoted 5 lines
In some cases, the function
ocfs2_igetread the data of inode, which has been deleted for some reason. That will make the system panic. So We should judge whether this inode has been deleted, and tell the caller that the inode is a bad inode.
Quoted 5 lines
Quoted 3 lines
[283465.542049] OCFS2: ERROR (device sdp): ocfs2_validate_inode_block:Invalid dinode #580640:
OCFS2_VALID_FLnot setLooks like it is a filesystem corruption bug.
So we'd better find where it is introduced and try to fix it there.
Thank you for reviewing
In that case, the ocfs2 was used as rear end of NFS(V3), which is stateless as we know.? NFS can't protect parent
directory from being deleted, when child is being accessed.? We can find the description at Documentation/filesystems/nfs/Exporting. I have reproduced this issue by adding some delay codes.? This issue can be reproduced in the production environment in case of heavy load . Of course this is a defect of NFS(V3),? But I think ocfs2 should have some fault tolerance. ocfs2 should not panic, if it try to get a nonexistent inode.
Thanks,
Sunny
Quoted 93 lines
Thanks,
JosephQuoted 90 lines
[283465.545490] Kernel panic - not syncing: OCFS2: (device sdp): panic forcedafter error
[283465.546889] CPU: 5 PID: 12416 Comm: nfsd Tainted: G W 4.1.12-124.18.6.el6uek.bug28762940v3.x86_64 #2 [283465.548382] Hardware name: VMware, Inc. VMware Virtual Platform/440BX Desktop Reference Platform, BIOS 6.00 09/21/2015 [283465.549657] 0000000000000000 ffff8800a56fb7b8 ffffffff816e839c ffffffffa0514758 [283465.550392] 000000000008dc20 ffff8800a56fb838 ffffffff816e62d3 0000000000000008 [283465.551056] ffff880000000010 ffff8800a56fb848 ffff8800a56fb7e8 ffff88005df9f000 [283465.551710] Call Trace: [283465.552516] [<ffffffff816e839c>] dump_stack+0x63/0x81 [283465.553291] [<ffffffff816e62d3>] panic+0xcb/0x21b [283465.554037] [<ffffffffa04e66b0>] ocfs2_handle_error+0xf0/0xf0 [ocfs2] [283465.554882] [<ffffffffa04e7737>] __ocfs2_error+0x67/0x70 [ocfs2] [283465.555768] [<ffffffffa049c0f9>] ocfs2_validate_inode_block+0x229/0x230 [ocfs2] [283465.556683] [<ffffffffa047bcbc>] ocfs2_read_blocks+0x46c/0x7b0 [ocfs2] [283465.557408] [<ffffffffa049bed0>] ? ocfs2_inode_cache_io_unlock+0x20/0x20 [ocfs2] [283465.557973] [<ffffffffa049f0eb>] ocfs2_read_inode_block_full+0x3b/0x60 [ocfs2] [283465.558525] [<ffffffffa049f5ba>] ocfs2_iget+0x4aa/0x880 [ocfs2] [283465.559082] [<ffffffffa049146e>] ocfs2_get_parent+0x9e/0x220 [ocfs2] [283465.559622] [<ffffffff81297c05>] reconnect_path+0xb5/0x300 [283465.560156] [<ffffffff81297f46>] exportfs_decode_fh+0xf6/0x2b0 [283465.560708] [<ffffffffa062faf0>] ? nfsd_proc_getattr+0xa0/0xa0 [nfsd] [283465.561262] [<ffffffff810a8196>] ? prepare_creds+0x26/0x110 [283465.561932] [<ffffffffa0630860>] fh_verify+0x350/0x660 [nfsd] [283465.562862] [<ffffffffa0637804>] ? nfsd_cache_lookup+0x44/0x630 [nfsd] [283465.563697] [<ffffffffa063a8b9>] nfsd3_proc_getattr+0x69/0xf0 [nfsd] [283465.564510] [<ffffffffa062cf60>] nfsd_dispatch+0xe0/0x290 [nfsd] [283465.565358] [<ffffffffa05eb892>] ? svc_tcp_adjust_wspace+0x12/0x30 [sunrpc] [283465.566272] [<ffffffffa05ea652>] svc_process_common+0x412/0x6a0 [sunrpc] [283465.567155] [<ffffffffa05eaa03>] svc_process+0x123/0x210 [sunrpc] [283465.568020] [<ffffffffa062c90f>] nfsd+0xff/0x170 [nfsd] [283465.568962] [<ffffffffa062c810>] ? nfsd_destroy+0x80/0x80 [nfsd] [283465.570112] [<ffffffff810a622b>] kthread+0xcb/0xf0 [283465.571099] [<ffffffff810a6160>] ? kthread_create_on_node+0x180/0x180 [283465.572114] [<ffffffff816f11b8>] ret_from_fork+0x58/0x90 [283465.573156] [<ffffffff810a6160>] ? kthread_create_on_node+0x180/0x180 --- fs/ocfs2/inode.c | 22 ++++++++++++++++++++++ 1 files changed, 22 insertions(+), 0 deletions(-)fs/ocfs2/inode.c +22
-0@@ -513,6 +513,16 @@ static int ocfs2_read_locked_inode(struct inode *inode, status = -EINVAL ; fe = (struct ocfs2_dinode *) bh->b_data; +/* +* In some cases, this inode has been deleted, but the data of +* inode is read directly. So We should judge whether this inode +* has been deleted. +* */ +if (unlikely (fe->i_dtime !=0 )) { +mlog (ML_NOTICE ,"The inode %llu has been deleted\n" , +le64_to_cpu (fe->i_blkno)); + goto bail; + }/* * This is a code bug. Right now the caller needs to * understand whether it is asking for a system file inode or @@ -1331,6 +1341,18 @@ int ocfs2_validate_inode_block(struct super_block *sb,BUG_ON (!buffer_uptodate (bh)); +/* +* In some cases, this inode has been deleted, but the data of +* inode is read directly. This is not a data corruption.So +* We should judge whether this inode has been deleted. +* */ +if (unlikely (di->i_dtime !=0 )) { + rc = -EINVAL ; +mlog (ML_NOTICE ,"The inode %llu has been deleted\n" , +le64_to_cpu (di->i_blkno)); + goto bail; + } +/* * If the ecc fails, we return the error but otherwise * leave the filesystem running. We know any error is
PATCH 1/1 ocfs2: fix ocfs2 read inode data panic in ocfs2_iget
Hi Sunny,
Quoted 1 line
Quoted 1 line
Quoted 1 line
On 2019/3/25 at 10:18, in message
<[email protected]>, "sunny.s.zhang"
Quoted 13 lines · <[email protected]> wrote:
? 2019?03?25? 09:31, Joseph Qi ??:
Quoted 7 lines · Shuning Zhang
Quoted 5 lines
In some cases, the function
ocfs2_igetread the data of inode, which has been deleted for some reason. That will make the system panic. So We should judge whether this inode has been deleted, and tell the caller that the inode is a bad inode.Quoted 5 lines
Quoted 3 lines
[283465.542049] OCFS2: ERROR (device sdp): ocfs2_validate_inode_block:Invalid dinode #580640:
OCFS2_VALID_FLnot setLooks like it is a filesystem corruption bug.
So we'd better find where it is introduced and try to fix it there.
Quoted 10 lines
Thank you for reviewing
In that case, the ocfs2 was used as rear end of NFS(V3), which is stateless as we know. NFS can't protect parent
directory from being deleted, when child is being accessed. We can find the description atDocumentation/filesystems/nfs/Exporting. I have reproduced this issue by adding some delay codes. This issue can be reproduced in the production environment in case of heavy load . Of course this is a defect of NFS(V3), But I think ocfs2 should have some fault tolerance. ocfs2 should not panic, if it try to get a nonexistent inode.
I feel ocfs2_test_inode_bit() can avoid the problem, but why do we still encounter this problem? Maybe there are some potential logic(or race condition) problem.
Thanks
Gang
Quoted 104 lines
Thanks,
SunnyQuoted 4 lines
Thanks,
JosephQuoted 1 line
[283465.545490] Kernel panic - not syncing: OCFS2: (device sdp): panicforced
Quoted 56 lines
Quoted 56 lines
after error
[283465.546889] CPU: 5 PID: 12416 Comm: nfsd Tainted: G W 4.1.12-124.18.6.el6uek.bug28762940v3.x86_64 #2 [283465.548382] Hardware name: VMware, Inc. VMware Virtual Platform/440BX Desktop Reference Platform, BIOS 6.00 09/21/2015 [283465.549657] 0000000000000000 ffff8800a56fb7b8 ffffffff816e839c ffffffffa0514758 [283465.550392] 000000000008dc20 ffff8800a56fb838 ffffffff816e62d3 0000000000000008 [283465.551056] ffff880000000010 ffff8800a56fb848 ffff8800a56fb7e8 ffff88005df9f000 [283465.551710] Call Trace: [283465.552516] [<ffffffff816e839c>] dump_stack+0x63/0x81 [283465.553291] [<ffffffff816e62d3>] panic+0xcb/0x21b [283465.554037] [<ffffffffa04e66b0>] ocfs2_handle_error+0xf0/0xf0 [ocfs2] [283465.554882] [<ffffffffa04e7737>] __ocfs2_error+0x67/0x70 [ocfs2] [283465.555768] [<ffffffffa049c0f9>] ocfs2_validate_inode_block+0x229/0x230 [ocfs2] [283465.556683] [<ffffffffa047bcbc>] ocfs2_read_blocks+0x46c/0x7b0 [ocfs2] [283465.557408] [<ffffffffa049bed0>] ? ocfs2_inode_cache_io_unlock+0x20/0x20 [ocfs2] [283465.557973] [<ffffffffa049f0eb>] ocfs2_read_inode_block_full+0x3b/0x60 [ocfs2] [283465.558525] [<ffffffffa049f5ba>] ocfs2_iget+0x4aa/0x880 [ocfs2] [283465.559082] [<ffffffffa049146e>] ocfs2_get_parent+0x9e/0x220 [ocfs2] [283465.559622] [<ffffffff81297c05>] reconnect_path+0xb5/0x300 [283465.560156] [<ffffffff81297f46>] exportfs_decode_fh+0xf6/0x2b0 [283465.560708] [<ffffffffa062faf0>] ? nfsd_proc_getattr+0xa0/0xa0 [nfsd] [283465.561262] [<ffffffff810a8196>] ? prepare_creds+0x26/0x110 [283465.561932] [<ffffffffa0630860>] fh_verify+0x350/0x660 [nfsd] [283465.562862] [<ffffffffa0637804>] ? nfsd_cache_lookup+0x44/0x630 [nfsd] [283465.563697] [<ffffffffa063a8b9>] nfsd3_proc_getattr+0x69/0xf0 [nfsd] [283465.564510] [<ffffffffa062cf60>] nfsd_dispatch+0xe0/0x290 [nfsd] [283465.565358] [<ffffffffa05eb892>] ? svc_tcp_adjust_wspace+0x12/0x30 [sunrpc] [283465.566272] [<ffffffffa05ea652>] svc_process_common+0x412/0x6a0 [sunrpc] [283465.567155] [<ffffffffa05eaa03>] svc_process+0x123/0x210 [sunrpc] [283465.568020] [<ffffffffa062c90f>] nfsd+0xff/0x170 [nfsd] [283465.568962] [<ffffffffa062c810>] ? nfsd_destroy+0x80/0x80 [nfsd] [283465.570112] [<ffffffff810a622b>] kthread+0xcb/0xf0 [283465.571099] [<ffffffff810a6160>] ? kthread_create_on_node+0x180/0x180 [283465.572114] [<ffffffff816f11b8>] ret_from_fork+0x58/0x90 [283465.573156] [<ffffffff810a6160>] ? kthread_create_on_node+0x180/0x180 --- fs/ocfs2/inode.c | 22 ++++++++++++++++++++++ 1 files changed, 22 insertions(+), 0 deletions(-)fs/ocfs2/inode.c +0
-0@@ -513,6 +513,16 @@ static int ocfs2_read_locked_inode(struct inode *inode, status = -EINVAL ; fe = (struct ocfs2_dinode *) bh->b_data;Quoted 14 lines
fs/ocfs2/inode.c int ocfs2_validate_inode_block(struct super_block
Quoted 14 lines
fs/ocfs2/inode.c +10
-0+/* +* In some cases, this inode has been deleted, but the data of +* inode is read directly. So We should judge whether this inode +* has been deleted. +* */ +if (unlikely (fe->i_dtime !=0 )) { +mlog (ML_NOTICE ,"The inode %llu has been deleted\n" , +le64_to_cpu (fe->i_blkno)); + goto bail; + }/* * This is a code bug. Right now the caller needs to * understand whether it is asking for a system file inode or @@ -1331,6 +1341,18 @@ int ocfs2_validate_inode_block(struct super_block*sb,
Quoted 19 lines
Quoted 9 lines
fs/ocfs2/inode.c +6
-0BUG_ON (!buffer_uptodate (bh)); +/* +* In some cases, this inode has been deleted, but the data of +* inode is read directly. This is not a data corruption.So +* We should judge whether this inode has been deleted. +* */ +if (unlikely (di->i_dtime !=0 )) {fs/ocfs2/inode.c int ocfs2_validate_inode_block(struct super_block *sb,
Quoted 10 lines
fs/ocfs2/inode.c +6
-0+ rc = -EINVAL ; +mlog (ML_NOTICE ,"The inode %llu has been deleted\n" , +le64_to_cpu (di->i_blkno)); + goto bail; + } +/* * If the ecc fails, we return the error but otherwise * leave the filesystem running. We know any error is _______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel at oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel
PATCH 1/1 ocfs2: fix ocfs2 read inode data panic in ocfs2_iget
Hi Gang,
? 2019?03?25? 11:11, Gang He ??:
Quoted 29 lines
Hi Sunny,
Quoted 1 line
Quoted 1 line
Quoted 1 line
On 2019/3/25 at 10:18, in message
<[email protected]>, "sunny.s.zhang"
Quoted 12 lines · <[email protected]> wrote:
? 2019?03?25? 09:31, Joseph Qi ??:
Quoted 11 lines · Shuning Zhang
Quoted 8 lines
In some cases, the function
ocfs2_igetread the data of inode, which has been deleted for some reason. That will make the system panic. So We should judge whether this inode has been deleted, and tell the caller that the inode is a bad inode.[283465.542049] OCFS2: ERROR (device sdp): ocfs2_validate_inode_block:Invalid dinode #580640:
OCFS2_VALID_FLnot setLooks like it is a filesystem corruption bug.
So we'd better find where it is introduced and try to fix it there.Quoted 10 lines
Thank you for reviewing
In that case, the ocfs2 was used as rear end of NFS(V3), which is stateless as we know. NFS can't protect parent
directory from being deleted, when child is being accessed. We can find the description atDocumentation/filesystems/nfs/Exporting. I have reproduced this issue by adding some delay codes. This issue can be reproduced in the production environment in case of heavy load . Of course this is a defect of NFS(V3), But I think ocfs2 should have some fault tolerance. ocfs2 should not panic, if it try to get a nonexistent inode.
Quoted 2 lines
I feel
ocfs2_test_inode_bit()can avoid the problem, but why do we still encounter this problem? Maybe there are some potential logic(or race condition) problem.
ocfs2_test_inode_bit() can test whether the inode have been deleted, but can't avoid this issue.
The key of this issue is ocfs2_get_parent() calls ocfs2_iget(inode) , but does not check if the inode exists.
I think this issue alse can be fixed, If ocfs2_get_parent() call ocfs2_test_inode_bit before? calling ocfs2_iget().
But this will have a little impact on performance.
This issue can be reproduce by the following steps. on the nfs server side,
..../patha/pathb
Step 1: The process A was scheduled before calling the function fh_verify.
Step 2: The process B is removing the 'pathb', and just completed the call to
function dput.
Then the dentry of 'pathb' has been deleted from the dcache, and all ancestors have been deleted also.
The relationship of dentry and inode was deleted through the function hlist_del_init. The following is the call stack. dentry_iput->hlist_del_init(&dentry->d_u.d_alias)
At this time, the inode is still in the dcache.
Step 3: The process A call the function ocfs2_get_dentry, which get the inode
from dcache. Then the refcount of inode is 1. The following is the call stack. nfsd3_proc_getacl->fh_verify->exportfs_decode_fh->fh_to_dentry(ocfs2_get_dentr
y)
Step 4: Dirty pages are flushed by bdi threads. So the inode of 'patha' is evicted, and this directory was deleted.
But the inode of 'pathb' can't be evicted, because the refcount of the inode
was 1.
Step 5: The process A keep running, and call the function reconnect_path(in exportfs_decode_fh),
which call function ocfs2_get_parent of ocfs2. Get the block number of parent
directory(patha) by the name of "..". Then read the data from disk by the block number. Bug this inode has been deleted, so the system panic.
Process A???????????????????????????????????????????? ? ?? Process B
1. in nfsd3_proc_getacl???????????????? ?? ? |
2. |??????? dput
3. fh_to_dentry(ocfs2_get_dentry)? |
4. bdi flush dirty cache?????????????????????? |
5. ocfs2_iget???????????????????? ? ? ?? ????????????? |
Thanks,
Sunny
Quoted 106 lines
Thanks
GangQuoted 102 lines
Thanks,
SunnyQuoted 4 lines
Thanks,
JosephQuoted 1 line
[283465.545490] Kernel panic - not syncing: OCFS2: (device sdp): panicforced
Quoted 56 lines
Quoted 56 lines
after error
[283465.546889] CPU: 5 PID: 12416 Comm: nfsd Tainted: G W 4.1.12-124.18.6.el6uek.bug28762940v3.x86_64 #2 [283465.548382] Hardware name: VMware, Inc. VMware Virtual Platform/440BX Desktop Reference Platform, BIOS 6.00 09/21/2015 [283465.549657] 0000000000000000 ffff8800a56fb7b8 ffffffff816e839c ffffffffa0514758 [283465.550392] 000000000008dc20 ffff8800a56fb838 ffffffff816e62d3 0000000000000008 [283465.551056] ffff880000000010 ffff8800a56fb848 ffff8800a56fb7e8 ffff88005df9f000 [283465.551710] Call Trace: [283465.552516] [<ffffffff816e839c>] dump_stack+0x63/0x81 [283465.553291] [<ffffffff816e62d3>] panic+0xcb/0x21b [283465.554037] [<ffffffffa04e66b0>] ocfs2_handle_error+0xf0/0xf0 [ocfs2] [283465.554882] [<ffffffffa04e7737>] __ocfs2_error+0x67/0x70 [ocfs2] [283465.555768] [<ffffffffa049c0f9>] ocfs2_validate_inode_block+0x229/0x230 [ocfs2] [283465.556683] [<ffffffffa047bcbc>] ocfs2_read_blocks+0x46c/0x7b0 [ocfs2] [283465.557408] [<ffffffffa049bed0>] ? ocfs2_inode_cache_io_unlock+0x20/0x20 [ocfs2] [283465.557973] [<ffffffffa049f0eb>] ocfs2_read_inode_block_full+0x3b/0x60 [ocfs2] [283465.558525] [<ffffffffa049f5ba>] ocfs2_iget+0x4aa/0x880 [ocfs2] [283465.559082] [<ffffffffa049146e>] ocfs2_get_parent+0x9e/0x220 [ocfs2] [283465.559622] [<ffffffff81297c05>] reconnect_path+0xb5/0x300 [283465.560156] [<ffffffff81297f46>] exportfs_decode_fh+0xf6/0x2b0 [283465.560708] [<ffffffffa062faf0>] ? nfsd_proc_getattr+0xa0/0xa0 [nfsd] [283465.561262] [<ffffffff810a8196>] ? prepare_creds+0x26/0x110 [283465.561932] [<ffffffffa0630860>] fh_verify+0x350/0x660 [nfsd] [283465.562862] [<ffffffffa0637804>] ? nfsd_cache_lookup+0x44/0x630 [nfsd] [283465.563697] [<ffffffffa063a8b9>] nfsd3_proc_getattr+0x69/0xf0 [nfsd] [283465.564510] [<ffffffffa062cf60>] nfsd_dispatch+0xe0/0x290 [nfsd] [283465.565358] [<ffffffffa05eb892>] ? svc_tcp_adjust_wspace+0x12/0x30 [sunrpc] [283465.566272] [<ffffffffa05ea652>] svc_process_common+0x412/0x6a0 [sunrpc] [283465.567155] [<ffffffffa05eaa03>] svc_process+0x123/0x210 [sunrpc] [283465.568020] [<ffffffffa062c90f>] nfsd+0xff/0x170 [nfsd] [283465.568962] [<ffffffffa062c810>] ? nfsd_destroy+0x80/0x80 [nfsd] [283465.570112] [<ffffffff810a622b>] kthread+0xcb/0xf0 [283465.571099] [<ffffffff810a6160>] ? kthread_create_on_node+0x180/0x180 [283465.572114] [<ffffffff816f11b8>] ret_from_fork+0x58/0x90 [283465.573156] [<ffffffff810a6160>] ? kthread_create_on_node+0x180/0x180 --- fs/ocfs2/inode.c | 22 ++++++++++++++++++++++ 1 files changed, 22 insertions(+), 0 deletions(-)fs/ocfs2/inode.c +0
-0@@ -513,6 +513,16 @@ static int ocfs2_read_locked_inode(struct inode *inode, status = -EINVAL ; fe = (struct ocfs2_dinode *) bh->b_data;Quoted 14 lines
fs/ocfs2/inode.c int ocfs2_validate_inode_block(struct super_block
Quoted 14 lines
fs/ocfs2/inode.c +10
-0+/* +* In some cases, this inode has been deleted, but the data of +* inode is read directly. So We should judge whether this inode +* has been deleted. +* */ +if (unlikely (fe->i_dtime !=0 )) { +mlog (ML_NOTICE ,"The inode %llu has been deleted\n" , +le64_to_cpu (fe->i_blkno)); + goto bail; + }/* * This is a code bug. Right now the caller needs to * understand whether it is asking for a system file inode or @@ -1331,6 +1341,18 @@ int ocfs2_validate_inode_block(struct super_block*sb,
Quoted 19 lines
Quoted 9 lines
fs/ocfs2/inode.c +6
-0BUG_ON (!buffer_uptodate (bh)); +/* +* In some cases, this inode has been deleted, but the data of +* inode is read directly. This is not a data corruption.So +* We should judge whether this inode has been deleted. +* */ +if (unlikely (di->i_dtime !=0 )) {fs/ocfs2/inode.c int ocfs2_validate_inode_block(struct super_block *sb,
Quoted 10 lines
fs/ocfs2/inode.c +6
-0+ rc = -EINVAL ; +mlog (ML_NOTICE ,"The inode %llu has been deleted\n" , +le64_to_cpu (di->i_blkno)); + goto bail; + } +/* * If the ecc fails, we return the error but otherwise * leave the filesystem running. We know any error is _______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel at oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel
PATCH 1/1 ocfs2: fix ocfs2 read inode data panic in ocfs2_iget
Hi Gang,? Jiang Qi,? Joseph,
Is my description clear?
Are there any other suggestions?
In addition, it works fine on ext4.
? 2019?03?25? 14:15, sunny.s.zhang ??:
Quoted 219 lines
Hi Gang,
? 2019?03?25? 11:11, Gang He ??:
Quoted 32 lines
Hi Sunny,
Quoted 1 line
Quoted 1 line
Quoted 1 line
On 2019/3/25 at 10:18, in message
<[email protected]>, "sunny.s.zhang"
Quoted 14 lines · <[email protected]> wrote:
? 2019?03?25? 09:31, Joseph Qi ??:
Quoted 7 lines · Shuning Zhang
Quoted 6 lines
In some cases, the function
ocfs2_igetread the data of inode, which has
been deleted for some reason. That will make the system panic. So We should judge whether this inode has been deleted, and tell the caller that the inode is a bad inode.Quoted 6 lines
Quoted 4 lines
[283465.542049] OCFS2: ERROR (device sdp):
ocfs2_validate_inode_block:
Invalid dinode #580640:OCFS2_VALID_FLnot setLooks like it is a filesystem corruption bug.
So we'd better find where it is introduced and try to fix it there.Quoted 11 lines
Thank you for reviewing
In that case, the ocfs2 was used as rear end of NFS(V3), which is stateless as we know.? NFS can't protect parent
directory from being deleted, when child is being accessed. We can find the description atDocumentation/filesystems/nfs/Exporting. I have reproduced this issue by adding some delay codes.? This issue can
be reproduced in the production environment in case of heavy load . Of course this is a defect of NFS(V3),? But I think ocfs2 should have some fault tolerance. ocfs2 should not panic, if it try to get a nonexistent inode.Quoted 3 lines
I feel
ocfs2_test_inode_bit()can avoid the problem, but why do we still encounter this problem?
Maybe there are some potential logic(or race condition) problem.
ocfs2_test_inode_bit()can test whether the inode have been deleted, but can't avoid this issue.
The key of this issue isocfs2_get_parent()callsocfs2_iget(inode), but does not check if the inode exists.
I think this issue alse can be fixed, Ifocfs2_get_parent()callocfs2_test_inode_bitbefore? callingocfs2_iget().
But this will have a little impact on performance.This issue can be reproduce by the following steps. on the nfs server side,
..../patha/pathbStep 1: The process A was scheduled before calling the function
fh_verify.Step 2: The process B is removing the 'pathb', and just completed the call to
function dput.
Then the dentry of 'pathb' has been deleted from the dcache, and all ancestors have been deleted also.
The relationship of dentry and inode was deleted through the functionhlist_del_init. The following is the call stack.dentry_iput->hlist_del_init(&dentry->d_u.d_alias)At this time, the inode is still in the dcache.
Step 3: The process A call the function
ocfs2_get_dentry, which get the inode
from dcache. Then the refcount of inode is 1. The following is the call stack. nfsd3_proc_getacl->fh_verify->exportfs_decode_fh->fh_to_dentry(ocfs2_get_dentry)
Step 4: Dirty pages are flushed by bdi threads. So the inode of 'patha' is
evicted, and this directory was deleted.
But the inode of 'pathb' can't be evicted, because the refcount of the inode
was 1.Step 5: The process A keep running, and call the function
reconnect_path(in exportfs_decode_fh),
which call functionocfs2_get_parentof ocfs2. Get the block number of parent
directory(patha) by the name of "..". Then read the data from disk by the block number. Bug this inode has been deleted, so the system panic.Process A???????????????????????????????????????????? ? ?? Process B
1. innfsd3_proc_getacl???????????????? ?? ? |
2. |??????? dput
3.fh_to_dentry(ocfs2_get_dentry)? |
4. bdi flush dirty cache?????????????????????? |
5.ocfs2_iget???????????????????? ? ? ?? ????????????? |Thanks,
SunnyQuoted 121 lines
Thanks
GangQuoted 117 lines
Thanks,
SunnyQuoted 5 lines
Thanks,
JosephQuoted 2 lines
[283465.545490] Kernel panic - not syncing: OCFS2: (device sdp):panic
forced
Quoted 78 lines
Quoted 78 lines
after error
[283465.546889] CPU: 5 PID: 12416 Comm: nfsd Tainted: G??????? W 4.1.12-124.18.6.el6uek.bug28762940v3.x86_64 #2 [283465.548382] Hardware name: VMware, Inc. VMware Virtual Platform/440BX Desktop Reference Platform, BIOS 6.00 09/21/2015 [283465.549657]? 0000000000000000 ffff8800a56fb7b8 ffffffff816e839c ffffffffa0514758 [283465.550392]? 000000000008dc20 ffff8800a56fb838 ffffffff816e62d3 0000000000000008 [283465.551056]? ffff880000000010 ffff8800a56fb848 ffff8800a56fb7e8 ffff88005df9f000 [283465.551710] Call Trace: [283465.552516]? [<ffffffff816e839c>] dump_stack+0x63/0x81 [283465.553291]? [<ffffffff816e62d3>] panic+0xcb/0x21b [283465.554037]? [<ffffffffa04e66b0>] ocfs2_handle_error+0xf0/0xf0 [ocfs2] [283465.554882]? [<ffffffffa04e7737>] __ocfs2_error+0x67/0x70 [ocfs2] [283465.555768]? [<ffffffffa049c0f9>] ocfs2_validate_inode_block+0x229/0x230 [ocfs2] [283465.556683]? [<ffffffffa047bcbc>] ocfs2_read_blocks+0x46c/0x7b0 [ocfs2] [283465.557408]? [<ffffffffa049bed0>] ? ocfs2_inode_cache_io_unlock+0x20/0x20 [ocfs2] [283465.557973]? [<ffffffffa049f0eb>] ocfs2_read_inode_block_full+0x3b/0x60 [ocfs2] [283465.558525]? [<ffffffffa049f5ba>] ocfs2_iget+0x4aa/0x880 [ocfs2] [283465.559082]? [<ffffffffa049146e>] ocfs2_get_parent+0x9e/0x220 [ocfs2] [283465.559622]? [<ffffffff81297c05>] reconnect_path+0xb5/0x300 [283465.560156]? [<ffffffff81297f46>] exportfs_decode_fh+0xf6/0x2b0 [283465.560708]? [<ffffffffa062faf0>] ? nfsd_proc_getattr+0xa0/0xa0 [nfsd] [283465.561262]? [<ffffffff810a8196>] ? prepare_creds+0x26/0x110 [283465.561932]? [<ffffffffa0630860>] fh_verify+0x350/0x660 [nfsd] [283465.562862]? [<ffffffffa0637804>] ? nfsd_cache_lookup+0x44/0x630 [nfsd] [283465.563697]? [<ffffffffa063a8b9>] nfsd3_proc_getattr+0x69/0xf0 [nfsd] [283465.564510]? [<ffffffffa062cf60>] nfsd_dispatch+0xe0/0x290 [nfsd] [283465.565358]? [<ffffffffa05eb892>] ? svc_tcp_adjust_wspace+0x12/0x30 [sunrpc] [283465.566272]? [<ffffffffa05ea652>] svc_process_common+0x412/0x6a0 [sunrpc] [283465.567155]? [<ffffffffa05eaa03>] svc_process+0x123/0x210 [sunrpc] [283465.568020]? [<ffffffffa062c90f>] nfsd+0xff/0x170 [nfsd] [283465.568962]? [<ffffffffa062c810>] ? nfsd_destroy+0x80/0x80 [nfsd] [283465.570112]? [<ffffffff810a622b>] kthread+0xcb/0xf0 [283465.571099]? [<ffffffff810a6160>] ? kthread_create_on_node+0x180/0x180 [283465.572114]? [<ffffffff816f11b8>] ret_from_fork+0x58/0x90 [283465.573156]? [<ffffffff810a6160>] ?
kthread_create_on_node+0x180/0x180
---
??fs/ocfs2/inode.c|?? 22 ++++++++++++++++++++++ ?? 1 files changed, 22 insertions(+), 0 deletions(-)fs/ocfs2/inode.c +0
-0@@ -513,6 +513,16 @@ static int ocfs2_read_locked_inode(structinode *inode, ?????? status = -EINVAL; ?????? fe = (struct ocfs2_dinode *) bh->b_data;?? +??? /*
+???? * In some cases, this inode has been deleted, but the data of +???? * inode is read directly. So We should judge whether this inode +???? * has been deleted.
+???? * */
+??? if (unlikely(fe->i_dtime != 0)) {
+??????? mlog(ML_NOTICE, "The inode %llu has been deleted\n",Quoted 8 lines
Quoted 8 lines
+????????????
le64_to_cpu(fe->i_blkno));
+??????????? goto bail;
+??? }
?????? /*
??????? * This is a code bug. Right now the caller needs to ??????? * understand whether it is asking for a system file inode orfs/ocfs2/inode.c +0
-0@@ -1331,6 +1341,18 @@ int ocfs2_validate_inode_block(struct
super_block*sb,
Quoted 9 lines
Quoted 9 lines
BUG_ON(!buffer_uptodate(bh));
?? +??? /*
+???? * In some cases, this inode has been deleted, but the data of +???? * inode is read directly. This is not a data corruption.So +???? * We should judge whether this inode has been deleted. +???? * */
+??? if (unlikely(di->i_dtime != 0)) {
+??????? rc =-EINVAL;
+??????? mlog(ML_NOTICE, "The inode %llu has been deleted\n",Quoted 8 lines
Quoted 8 lines
+????????????
le64_to_cpu(di->i_blkno)); +??????????? goto bail;
+??? }
+
?????? /*
??????? * If the ecc fails, we return the error but otherwise ??????? * leave the filesystem running.? We know any error is_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel at oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel
PATCH 1/1 ocfs2: fix ocfs2 read inode data panic in ocfs2_iget
Quoted 5 lines · sunny.s.zhang
Hi Gang,? Jiang Qi,? Joseph,
Is my description clear?
Are there any other suggestions?
In addition, it works fine on ext4.
So this happens when using ocfs2 as NFSv3 backend, right? If so, please describe the use case in commit log as well as the sequence how it happens.
BTW, since the dinode has been deleted, the block may be used in other way. So I don't think we can use "di->i_dtime != 0" to identify this case.
Thanks,
Joseph
PATCH 1/1 ocfs2: fix ocfs2 read inode data panic in ocfs2_iget
Hi Joseph,
? 2019?03?29? 10:21, Joseph Qi ??:
Quoted 10 lines · sunny.s.zhang
Quoted 5 lines
Hi Gang,? Jiang Qi,? Joseph,
Is my description clear?
Are there any other suggestions?
In addition, it works fine on ext4.So this happens when using ocfs2 as NFSv3 backend, right? If so, please describe the use case in commit log as well as the sequence how it happens.
Thank you very much for the feedback.
OK, I will add it to the commit log.
Quoted 4 lines
BTW, since the dinode has been deleted, the block may be used in other way. So I don't think we can use "
di->i_dtime!= 0" to identify this case.
Yes, Although the time window is very small, it is strictly possible to happen.
I will make a new patch and consider the above question. Thanks,
Sunny
Quoted 3 lines
Thanks,
Joseph
PATCH 1/1 ocfs2: fix ocfs2 read inode data panic in ocfs2_iget
In reply to sunny.s.zhangHello Sunny,
The bug description is OK for us.
But I feel the fix looks like a little hack.
Could we use a normal way to handle this problem?
e.g. use ocfs2_dentry_revalidate() function to check the related dentry in case from nfs related access paths.
Thanks
Gang
Quoted 1 line
Quoted 1 line
Quoted 1 line
On 3/29/2019 at 9:05 am, in message
<[email protected]>, "sunny.s.zhang"
Quoted 226 lines · <[email protected]> wrote:
Hi Gang, Jiang Qi, Joseph,
Is my description clear?
Are there any other suggestions?
In addition, it works fine on ext4.? 2019?03?25? 14:15, sunny.s.zhang ??:
Quoted 219 lines
Hi Gang,
? 2019?03?25? 11:11, Gang He ??:
Quoted 32 lines
Hi Sunny,
Quoted 1 line
Quoted 1 line
Quoted 1 line
On 2019/3/25 at 10:18, in message
<[email protected]>, "sunny.s.zhang"
Quoted 14 lines · <[email protected]> wrote:
? 2019?03?25? 09:31, Joseph Qi ??:
Quoted 7 lines · Shuning Zhang
Quoted 6 lines
In some cases, the function
ocfs2_igetread the data of inode, which has
been deleted for some reason. That will make the system panic. So We should judge whether this inode has been deleted, and tell the caller that the inode is a bad inode.Quoted 6 lines
Quoted 4 lines
[283465.542049] OCFS2: ERROR (device sdp):
ocfs2_validate_inode_block:
Invalid dinode #580640:OCFS2_VALID_FLnot setLooks like it is a filesystem corruption bug.
So we'd better find where it is introduced and try to fix it there.Quoted 11 lines
Thank you for reviewing
In that case, the ocfs2 was used as rear end of NFS(V3), which is stateless as we know. NFS can't protect parent
directory from being deleted, when child is being accessed. We can find the description atDocumentation/filesystems/nfs/Exporting. I have reproduced this issue by adding some delay codes. This issue can
be reproduced in the production environment in case of heavy load . Of course this is a defect of NFS(V3), But I think ocfs2 should have some fault tolerance. ocfs2 should not panic, if it try to get a nonexistent inode.Quoted 3 lines
I feel
ocfs2_test_inode_bit()can avoid the problem, but why do we still encounter this problem?
Maybe there are some potential logic(or race condition) problem.
ocfs2_test_inode_bit()can test whether the inode have been deleted, but can't avoid this issue.
The key of this issue isocfs2_get_parent()callsocfs2_iget(inode), but does not check if the inode exists.
I think this issue alse can be fixed, Ifocfs2_get_parent()callocfs2_test_inode_bitbefore callingocfs2_iget().
But this will have a little impact on performance.This issue can be reproduce by the following steps. on the nfs server side,
..../patha/pathbStep 1: The process A was scheduled before calling the function
fh_verify.Step 2: The process B is removing the 'pathb', and just completed the call to
function dput.
Then the dentry of 'pathb' has been deleted from the dcache, and all ancestors have been deleted also.
The relationship of dentry and inode was deleted through the functionhlist_del_init. The following is the call stack.dentry_iput->hlist_del_init(&dentry->d_u.d_alias)At this time, the inode is still in the dcache.
Step 3: The process A call the function
ocfs2_get_dentry, which get the inode
from dcache. Then the refcount of inode is 1. The following is the call stack. nfsd3_proc_getacl->fh_verify->exportfs_decode_fh->fh_to_dentry(ocfs2_get_dentry)
Step 4: Dirty pages are flushed by bdi threads. So the inode of 'patha' is
evicted, and this directory was deleted.
But the inode of 'pathb' can't be evicted, because the refcount of the inode
was 1.Step 5: The process A keep running, and call the function
reconnect_path(in exportfs_decode_fh),
which call functionocfs2_get_parentof ocfs2. Get the block number of parent
directory(patha) by the name of "..". Then read the data from disk by the block number. Bug this inode has been deleted, so the system panic.Process A Process B
1. innfsd3_proc_getacl|
2. | dput
3.fh_to_dentry(ocfs2_get_dentry)|
4. bdi flush dirty cache |
5.ocfs2_iget|Thanks,
SunnyQuoted 121 lines
Thanks
GangQuoted 117 lines
Thanks,
SunnyQuoted 5 lines
Thanks,
JosephQuoted 2 lines
[283465.545490] Kernel panic - not syncing: OCFS2: (device sdp):panic
forced
Quoted 78 lines
Quoted 78 lines
after error
[283465.546889] CPU: 5 PID: 12416 Comm: nfsd Tainted: G W 4.1.12-124.18.6.el6uek.bug28762940v3.x86_64 #2 [283465.548382] Hardware name: VMware, Inc. VMware Virtual Platform/440BX Desktop Reference Platform, BIOS 6.00 09/21/2015 [283465.549657] 0000000000000000 ffff8800a56fb7b8 ffffffff816e839c ffffffffa0514758 [283465.550392] 000000000008dc20 ffff8800a56fb838 ffffffff816e62d3 0000000000000008 [283465.551056] ffff880000000010 ffff8800a56fb848 ffff8800a56fb7e8 ffff88005df9f000 [283465.551710] Call Trace: [283465.552516] [<ffffffff816e839c>] dump_stack+0x63/0x81 [283465.553291] [<ffffffff816e62d3>] panic+0xcb/0x21b [283465.554037] [<ffffffffa04e66b0>] ocfs2_handle_error+0xf0/0xf0 [ocfs2] [283465.554882] [<ffffffffa04e7737>] __ocfs2_error+0x67/0x70 [ocfs2] [283465.555768] [<ffffffffa049c0f9>] ocfs2_validate_inode_block+0x229/0x230 [ocfs2] [283465.556683] [<ffffffffa047bcbc>] ocfs2_read_blocks+0x46c/0x7b0 [ocfs2] [283465.557408] [<ffffffffa049bed0>] ? ocfs2_inode_cache_io_unlock+0x20/0x20 [ocfs2] [283465.557973] [<ffffffffa049f0eb>] ocfs2_read_inode_block_full+0x3b/0x60 [ocfs2] [283465.558525] [<ffffffffa049f5ba>] ocfs2_iget+0x4aa/0x880 [ocfs2] [283465.559082] [<ffffffffa049146e>] ocfs2_get_parent+0x9e/0x220 [ocfs2] [283465.559622] [<ffffffff81297c05>] reconnect_path+0xb5/0x300 [283465.560156] [<ffffffff81297f46>] exportfs_decode_fh+0xf6/0x2b0 [283465.560708] [<ffffffffa062faf0>] ? nfsd_proc_getattr+0xa0/0xa0 [nfsd] [283465.561262] [<ffffffff810a8196>] ? prepare_creds+0x26/0x110 [283465.561932] [<ffffffffa0630860>] fh_verify+0x350/0x660 [nfsd] [283465.562862] [<ffffffffa0637804>] ? nfsd_cache_lookup+0x44/0x630 [nfsd] [283465.563697] [<ffffffffa063a8b9>] nfsd3_proc_getattr+0x69/0xf0 [nfsd] [283465.564510] [<ffffffffa062cf60>] nfsd_dispatch+0xe0/0x290 [nfsd] [283465.565358] [<ffffffffa05eb892>] ? svc_tcp_adjust_wspace+0x12/0x30 [sunrpc] [283465.566272] [<ffffffffa05ea652>] svc_process_common+0x412/0x6a0 [sunrpc] [283465.567155] [<ffffffffa05eaa03>] svc_process+0x123/0x210 [sunrpc] [283465.568020] [<ffffffffa062c90f>] nfsd+0xff/0x170 [nfsd] [283465.568962] [<ffffffffa062c810>] ? nfsd_destroy+0x80/0x80 [nfsd] [283465.570112] [<ffffffff810a622b>] kthread+0xcb/0xf0 [283465.571099] [<ffffffff810a6160>] ? kthread_create_on_node+0x180/0x180 [283465.572114] [<ffffffff816f11b8>] ret_from_fork+0x58/0x90 [283465.573156] [<ffffffff810a6160>] ? kthread_create_on_node+0x180/0x180 --- fs/ocfs2/inode.c | 22 ++++++++++++++++++++++ 1 files changed, 22 insertions(+), 0 deletions(-)fs/ocfs2/inode.c +6
-0@@ -513,6 +513,16 @@ static int ocfs2_read_locked_inode(structinode *inode, status = -EINVAL ; fe = (struct ocfs2_dinode *) bh->b_data; +/* +* In some cases, this inode has been deleted, but the data of +* inode is read directly. So We should judge whether this inode +* has been deleted. +* */ + if (unlikely(fe->i_dtime != 0)) { + mlog(ML_NOTICE, "The inode %llu has been deleted\n",Quoted 8 lines
Quoted 8 lines
fs/ocfs2/inode.c +3
-0+ le64_to_cpu(fe->i_blkno)); + goto bail; + }/* * This is a code bug. Right now the caller needs to * understand whether it is asking for a system file inode or @@ -1331,6 +1341,18 @@ int ocfs2_validate_inode_block(struct
super_block*sb,
Quoted 9 lines
Quoted 9 lines
BUG_ON(!buffer_uptodate(bh));
+ /*fs/ocfs2/inode.c +7
-0+* In some cases, this inode has been deleted, but the data of +* inode is read directly. This is not a data corruption.So +* We should judge whether this inode has been deleted. +* */ +if (unlikely (di->i_dtime !=0 )) { + rc = -EINVAL ; + mlog(ML_NOTICE, "The inode %llu has been deleted\n",Quoted 8 lines
fs/ocfs2/inode.c int ocfs2_validate_inode_block(struct super_block *sb, · line 1358
Quoted 8 lines
fs/ocfs2/inode.c +4
-0+ le64_to_cpu(di->i_blkno)); + goto bail; + } +/* * If the ecc fails, we return the error but otherwise * leave the filesystem running. We know any error is _______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel at oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel
PATCH 1/1 ocfs2: fix ocfs2 read inode data panic in ocfs2_iget
Hi Gang,
? 2019?03?29? 12:31, Gang He ??:
Quoted 6 lines
Hello Sunny,
The bug description is OK for us.
But I feel the fix looks like a little hack.
Could we use a normal way to handle this problem?
e.g. useocfs2_dentry_revalidate()function to check the related dentry in case from nfs related access paths.
Thank you very much for the suggestion.
I will try to adjust the code of this patch.
Thanks
Sunny
Quoted 231 lines
Thanks
GangQuoted 1 line
Quoted 1 line
Quoted 1 line
On 3/29/2019 at 9:05 am, in message
<[email protected]>, "sunny.s.zhang"
Quoted 224 lines · <[email protected]> wrote:
Hi Gang, Jiang Qi, Joseph,
Is my description clear?
Are there any other suggestions?
In addition, it works fine on ext4.? 2019?03?25? 14:15, sunny.s.zhang ??:
Quoted 217 lines
Hi Gang,
? 2019?03?25? 11:11, Gang He ??:
Quoted 32 lines
Hi Sunny,
Quoted 1 line
Quoted 1 line
Quoted 1 line
On 2019/3/25 at 10:18, in message
<[email protected]>, "sunny.s.zhang"
Quoted 14 lines · <[email protected]> wrote:
? 2019?03?25? 09:31, Joseph Qi ??:
Quoted 7 lines · Shuning Zhang
Quoted 6 lines
In some cases, the function
ocfs2_igetread the data of inode, which has
been deleted for some reason. That will make the system panic. So We should judge whether this inode has been deleted, and tell the caller that the inode is a bad inode.Quoted 6 lines
Quoted 4 lines
[283465.542049] OCFS2: ERROR (device sdp):
ocfs2_validate_inode_block:
Invalid dinode #580640:OCFS2_VALID_FLnot setLooks like it is a filesystem corruption bug.
So we'd better find where it is introduced and try to fix it there.Quoted 11 lines
Thank you for reviewing
In that case, the ocfs2 was used as rear end of NFS(V3), which is stateless as we know. NFS can't protect parent
directory from being deleted, when child is being accessed. We can find the description atDocumentation/filesystems/nfs/Exporting. I have reproduced this issue by adding some delay codes. This issue can
be reproduced in the production environment in case of heavy load . Of course this is a defect of NFS(V3), But I think ocfs2 should have some fault tolerance. ocfs2 should not panic, if it try to get a nonexistent inode.Quoted 3 lines
I feel
ocfs2_test_inode_bit()can avoid the problem, but why do we still encounter this problem?
Maybe there are some potential logic(or race condition) problem.
ocfs2_test_inode_bit()can test whether the inode have been deleted, but can't avoid this issue.
The key of this issue isocfs2_get_parent()callsocfs2_iget(inode), but does not check if the inode exists.
I think this issue alse can be fixed, Ifocfs2_get_parent()callocfs2_test_inode_bitbefore callingocfs2_iget().
But this will have a little impact on performance.This issue can be reproduce by the following steps. on the nfs server side,
..../patha/pathbStep 1: The process A was scheduled before calling the function
fh_verify.Step 2: The process B is removing the 'pathb', and just completed the call to
function dput.
Then the dentry of 'pathb' has been deleted from the dcache, and all ancestors have been deleted also.
The relationship of dentry and inode was deleted through the functionhlist_del_init. The following is the call stack.dentry_iput->hlist_del_init(&dentry->d_u.d_alias)At this time, the inode is still in the dcache.
Step 3: The process A call the function
ocfs2_get_dentry, which get the inode
from dcache. Then the refcount of inode is 1. The following is the call stack. nfsd3_proc_getacl->fh_verify->exportfs_decode_fh->fh_to_dentry(ocfs2_get_dentry)
Step 4: Dirty pages are flushed by bdi threads. So the inode of 'patha' is
evicted, and this directory was deleted.
But the inode of 'pathb' can't be evicted, because the refcount of the inode
was 1.Step 5: The process A keep running, and call the function
reconnect_path(in exportfs_decode_fh),
which call functionocfs2_get_parentof ocfs2. Get the block number of parent
directory(patha) by the name of "..". Then read the data from disk by the block number. Bug this inode has been deleted, so the system panic.Process A Process B
1. innfsd3_proc_getacl|
2. | dput
3.fh_to_dentry(ocfs2_get_dentry)|
4. bdi flush dirty cache |
5.ocfs2_iget|Thanks,
SunnyQuoted 120 lines
Thanks
GangQuoted 116 lines
Thanks,
SunnyQuoted 5 lines
Thanks,
JosephQuoted 2 lines
[283465.545490] Kernel panic - not syncing: OCFS2: (device sdp):panic
forced
Quoted 78 lines
Quoted 78 lines
after error
[283465.546889] CPU: 5 PID: 12416 Comm: nfsd Tainted: G W 4.1.12-124.18.6.el6uek.bug28762940v3.x86_64 #2 [283465.548382] Hardware name: VMware, Inc. VMware Virtual Platform/440BX Desktop Reference Platform, BIOS 6.00 09/21/2015 [283465.549657] 0000000000000000 ffff8800a56fb7b8 ffffffff816e839c ffffffffa0514758 [283465.550392] 000000000008dc20 ffff8800a56fb838 ffffffff816e62d3 0000000000000008 [283465.551056] ffff880000000010 ffff8800a56fb848 ffff8800a56fb7e8 ffff88005df9f000 [283465.551710] Call Trace: [283465.552516] [<ffffffff816e839c>] dump_stack+0x63/0x81 [283465.553291] [<ffffffff816e62d3>] panic+0xcb/0x21b [283465.554037] [<ffffffffa04e66b0>] ocfs2_handle_error+0xf0/0xf0 [ocfs2] [283465.554882] [<ffffffffa04e7737>] __ocfs2_error+0x67/0x70 [ocfs2] [283465.555768] [<ffffffffa049c0f9>] ocfs2_validate_inode_block+0x229/0x230 [ocfs2] [283465.556683] [<ffffffffa047bcbc>] ocfs2_read_blocks+0x46c/0x7b0 [ocfs2] [283465.557408] [<ffffffffa049bed0>] ? ocfs2_inode_cache_io_unlock+0x20/0x20 [ocfs2] [283465.557973] [<ffffffffa049f0eb>] ocfs2_read_inode_block_full+0x3b/0x60 [ocfs2] [283465.558525] [<ffffffffa049f5ba>] ocfs2_iget+0x4aa/0x880 [ocfs2] [283465.559082] [<ffffffffa049146e>] ocfs2_get_parent+0x9e/0x220 [ocfs2] [283465.559622] [<ffffffff81297c05>] reconnect_path+0xb5/0x300 [283465.560156] [<ffffffff81297f46>] exportfs_decode_fh+0xf6/0x2b0 [283465.560708] [<ffffffffa062faf0>] ? nfsd_proc_getattr+0xa0/0xa0 [nfsd] [283465.561262] [<ffffffff810a8196>] ? prepare_creds+0x26/0x110 [283465.561932] [<ffffffffa0630860>] fh_verify+0x350/0x660 [nfsd] [283465.562862] [<ffffffffa0637804>] ? nfsd_cache_lookup+0x44/0x630 [nfsd] [283465.563697] [<ffffffffa063a8b9>] nfsd3_proc_getattr+0x69/0xf0 [nfsd] [283465.564510] [<ffffffffa062cf60>] nfsd_dispatch+0xe0/0x290 [nfsd] [283465.565358] [<ffffffffa05eb892>] ? svc_tcp_adjust_wspace+0x12/0x30 [sunrpc] [283465.566272] [<ffffffffa05ea652>] svc_process_common+0x412/0x6a0 [sunrpc] [283465.567155] [<ffffffffa05eaa03>] svc_process+0x123/0x210 [sunrpc] [283465.568020] [<ffffffffa062c90f>] nfsd+0xff/0x170 [nfsd] [283465.568962] [<ffffffffa062c810>] ? nfsd_destroy+0x80/0x80 [nfsd] [283465.570112] [<ffffffff810a622b>] kthread+0xcb/0xf0 [283465.571099] [<ffffffff810a6160>] ? kthread_create_on_node+0x180/0x180 [283465.572114] [<ffffffff816f11b8>] ret_from_fork+0x58/0x90 [283465.573156] [<ffffffff810a6160>] ? kthread_create_on_node+0x180/0x180 --- fs/ocfs2/inode.c | 22 ++++++++++++++++++++++ 1 files changed, 22 insertions(+), 0 deletions(-)fs/ocfs2/inode.c +6
-0@@ -513,6 +513,16 @@ static int ocfs2_read_locked_inode(structinode *inode, status = -EINVAL ; fe = (struct ocfs2_dinode *) bh->b_data; +/* +* In some cases, this inode has been deleted, but the data of +* inode is read directly. So We should judge whether this inode +* has been deleted. +* */ + if (unlikely(fe->i_dtime != 0)) { + mlog(ML_NOTICE, "The inode %llu has been deleted\n",Quoted 8 lines
Quoted 8 lines
fs/ocfs2/inode.c +3
-0+ le64_to_cpu(fe->i_blkno)); + goto bail; + }/* * This is a code bug. Right now the caller needs to * understand whether it is asking for a system file inode or @@ -1331,6 +1341,18 @@ int ocfs2_validate_inode_block(struct
super_block*sb,
Quoted 9 lines
Quoted 9 lines
BUG_ON(!buffer_uptodate(bh));
+ /*fs/ocfs2/inode.c +7
-0+* In some cases, this inode has been deleted, but the data of +* inode is read directly. This is not a data corruption.So +* We should judge whether this inode has been deleted. +* */ +if (unlikely (di->i_dtime !=0 )) { + rc = -EINVAL ; + mlog(ML_NOTICE, "The inode %llu has been deleted\n",Quoted 8 lines
fs/ocfs2/inode.c
Quoted 8 lines
fs/ocfs2/inode.c +4
-0+ le64_to_cpu(di->i_blkno)); + goto bail; + } +/* * If the ecc fails, we return the error but otherwise * leave the filesystem running. We know any error is _______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel at oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel