Add coverity static analysis to Travis CI config

PATCH In review Steffan Karger 5 participants 8 messages Aug 8, 2017 – Aug 18, 2017

lore

Share & tools

lore

Steffan Karger

author

2017-08-08 15:55 UTC #0 lore raw

PATCH 1/1 Add coverity static analysis to Travis CI config

Enable coverity analysis for the release/2.4 branch.

We can only do a limited number of coverity scans per week with our FOSS account, but since we only occasionally push commits, that should work out fine. But this limit is the reason we don't use the standard travis addon, because that would cause the coverity script to run on all of our matrix builds. That would cause us to reach our limit faster, and waste travis' resources.

Since our FOSS coverity account doesn't handle multiple branches very well, we have to pick one branch to run coverity on. I think it's best to use the most recent stable branch for that (i.e. for now, release/2.4). Though for ease of maintenance, it's probably best to apply the patch to both master and release/2.4.

Signed-off-by Steffan Karger <[email protected]...>

---
 .travis.yml         |  8 +++++++-
 .travis/coverity.sh | 17 +++++++++++++++++
 2 files changed, 24 insertions(+), 1 deletion(-)
 create mode 100755 .travis/coverity.sh

.travis.yml +7 -1

index db90e03..131d002 100644
@@ -21,10 +21,13 @@ env:
     - OPENSSL_VERSION="1.0.2k"
     - OPENSSL_CFLAGS="-I${PREFIX}/include"
     - OPENSSL_LIBS="-L${PREFIX}/lib -lssl -lcrypto"
+    # The next declaration is the encrypted COVERITY_SCAN_TOKEN, created
+    #   via the "travis encrypt" command using the project repo's public key
+    - secure: "l9mSnEW4LJqjxftH5i1NdDaYfGmQB1mPXnSB3DXnsjzkCWZ+yJLfBemfQ0tx/wS7chBYxqUaUIMT0hw4zJVp/LANFJo2vfh//ymTS6h0uApRY1ofg9Pp1BFcV1laG6/u8pwSZ2EBy/GhCd3DS436oE8sYBRaFM9FU62L/oeQBfJ7r4ID/0eB1b8bqlbD4paty9MHui2P8EZJwR+KAD84prtfpZOcrSMxPh9OUhJxzxUvvVoP4s4+lZ5Kgg1bBQ3yzKGDqe8VOgK2BWCEuezqhMMc8oeKmAe7CUkoz5gsGYH++k3I9XzP9Z4xeJKoQnC/82qi4xkJmlaOxdionej9bHIcjfRt7D8j1J0U+wOj4p8VrDy7yHaxuN2fi0K5MGa/CaXQSrkna8dePniCng+xQ2MY/zxuRX2gA6xPNLUyQLU9LqIug7wj4z84Hk9iWib4L20MoPjeEo+vAUNq8FtjOPxMuHNpv4iGGx6kgJm7RXl5vC5hxfK6MprrnYe2U5Mcd8jpzagKBaKHL3zV2FxX9k0jRO9Mccz7M2WnaV0MQ6zcngzTN4+s0kCjhfGKd2F2ANT2Gkhj3Me36eNHfuE0dBbvYCMh4b3Mgd7b/OuXwQWdJ8PjJ1WHXjSOw5sHw1suaV6cEO2Meyz5j1tOkyOi0M9QF+LFenQ9vLH4sBCww8U="
 
 matrix:
   include:
-    - env: SSLLIB="openssl"
+    - env: SSLLIB="openssl" RUN_COVERITY="1"
       os: linux
       compiler: gcc
     - env: SSLLIB="openssl" OPENSSL_VERSION="1.1.0f"

@@ -91,5 +94,8 @@ install:
   - if [ ! -z "${CHOST}" ]; then unset CC; fi
   - .travis/build-deps.sh > build-deps.log 2>&1 || (cat build-deps.log && exit 1)
 
+before_script:
+  - .travis/coverity.sh
+
 script:
   - .travis/build-check.sh

.travis/coverity.sh new file +17 -0

new file mode 100755
index 0000000..8bb40f4
@@ -0,0 +1,17 @@
+#!/bin/sh
+set -eu
+
+RUN_COVERITY="${RUN_COVERITY:-0}"
+
+export COVERITY_SCAN_PROJECT_NAME="OpenVPN/openvpn"
+export COVERITY_SCAN_BRANCH_PATTERN="release\/2.4"
+export COVERITY_SCAN_NOTIFICATION_EMAIL="[email protected]..."
+export COVERITY_SCAN_BUILD_COMMAND_PREPEND="autoreconf -vi && ./configure --enable-iproute2 && make clean"
+export COVERITY_SCAN_BUILD_COMMAND="make"
+
+if [ "${RUN_COVERITY}" = "1" ]; then
+    # Ignore exit code, script exits with 1 if we're not on the right branch
+    curl -s "https://scan.coverity.com/scripts/travisci_build_coverity_scan.sh" | bash || true
+else
+    echo "Skipping coverity scan because \$RUN_COVERITY != \"1\""
+fi

Signature · 1 line

2.7.4

Antonio Quartulli

2017-08-08 22:17 UTC #1 lore raw

Quoted 9 lines · Steffan Karger

Enable coverity analysis for the release/2.4 branch.
We can only do a limited number of coverity scans per week with our FOSS account, but since we only occasionally push commits, that should work out fine. But this limit is the reason we don't use the standard travis addon, because that would cause the coverity script to run on all of our matrix builds. That would cause us to reach our limit faster, and waste travis' resources.

Quoted 7 lines

Since our FOSS coverity account doesn't handle multiple branches very well, we have to pick one branch to run coverity on. I think it's best to use the most recent stable branch for that (i.e. for now, release/2.4). Though for ease of maintenance, it's probably best to apply the patch to both master and release/2.4.
Signed-off-by Steffan Karger <[email protected]...>

ACK. This would allow to run the coverity scan on a periodic base without having to push yet another branch every time.

Signature · 1 line

Antonio Quartulli

Илья Шипицин

2017-08-09 05:41 UTC #2 lore raw

In reply to Steffan Karger

2017-08-08 20:55 GMT+05:00 Steffan Karger <[email protected]...>:

Quoted 9 lines

Enable coverity analysis for the release/2.4 branch.
We can only do a limited number of coverity scans per week with our FOSS account, but since we only occasionally push commits, that should work out fine. But this limit is the reason we don't use the standard travis addon, because that would cause the coverity script to run on all of our matrix builds. That would cause us to reach our limit faster, and waste travis' resources.

Quoted 6 lines

Since our FOSS coverity account doesn't handle multiple branches very well, we have to pick one branch to run coverity on. I think it's best to use the most recent stable branch for that (i.e. for now, release/2.4). Though for ease of maintenance, it's probably best to apply the patch to both master and release/2.4.

I would refactor it like that
https://gist.github.com/chipitsine/8dcae4ff1d59eb43df39f6015c6106fd
however, your is ok as well

Quoted 88 lines

Signed-off-by Steffan Karger <[email protected]...>
---
 .travis.yml         |  8 +++++++-
 .travis/coverity.sh | 17 +++++++++++++++++
 2 files changed, 24 insertions(+), 1 deletion(-)
 create mode 100755 .travis/coverity.sh
.travis.yml +2 -0
index db90e03..131d002 100644
@@ -21,10 +21,13 @@ env:
     - OPENSSL_VERSION="1.0.2k"
     - OPENSSL_CFLAGS="-I${PREFIX}/include"
     - OPENSSL_LIBS="-L${PREFIX}/lib -lssl -lcrypto"
+    # The next declaration is the encrypted COVERITY_SCAN_TOKEN, created
+    #   via the "travis encrypt" command using the project repo's public
key
+ - secure: "l9mSnEW4LJqjxftH5i1NdDaYfGmQB1mPXnSB3DXnsjzkCWZ+
yJLfBemfQ0tx/wS7chBYxqUaUIMT0hw4zJVp/LANFJo2vfh// ymTS6h0uApRY1ofg9Pp1BFcV1laG6/u8pwSZ2EBy/GhCd3DS436oE8sYBRaFM9FU62L/ oeQBfJ7r4ID/0eB1b8bqlbD4paty9MHui2P8EZJwR+KAD84prtfpZOcrSMxPh9OUhJxzxUvv VoP4s4+lZ5Kgg1bBQ3yzKGDqe8VOgK2BWCEuezqhMMc8oeKmAe7CUkoz5gsGYH++ k3I9XzP9Z4xeJKoQnC/82qi4xkJmlaOxdionej9bHIcjfRt7D8j1J0U+ wOj4p8VrDy7yHaxuN2fi0K5MGa/CaXQSrkna8dePniCng+xQ2MY/ zxuRX2gA6xPNLUyQLU9LqIug7wj4z84Hk9iWib4L20MoPjeEo+ vAUNq8FtjOPxMuHNpv4iGGx6kgJm7RXl5vC5hxfK6MprrnYe2U5Mcd8jpzag KBaKHL3zV2FxX9k0jRO9Mccz7M2WnaV0MQ6zcngzTN4+s0kCjhfGKd2F2ANT2Gkhj3Me36eNHf uE0dBbvYCMh4b3Mgd7b/OuXwQWdJ8PjJ1WHXjSOw5sHw1suaV6cEO2Meyz5j1tOkyOi0M9QF+ LFenQ9vLH4sBCww8U="
matrix:
include:
.travis.yml +4 -1
-    - env: SSLLIB="openssl"
+    - env: SSLLIB="openssl" RUN_COVERITY="1"
       os: linux
       compiler: gcc
     - env: SSLLIB="openssl" OPENSSL_VERSION="1.1.0f"
@@ -91,5 +94,8 @@ install:
   - if [ ! -z "${CHOST}" ]; then unset CC; fi
   - .travis/build-deps.sh > build-deps.log 2>&1 || (cat build-deps.log &&
 exit 1)
 
+before_script:
+  - .travis/coverity.sh
+
 script:
- .travis/build-check.sh
.travis/coverity.sh new file +9 -0
new file mode 100755
index 0000000..8bb40f4
@@ -0,0 +1,17 @@
+#!/bin/sh
+set -eu
+
+RUN_COVERITY="${RUN_COVERITY:-0}"
+
+export COVERITY_SCAN_PROJECT_NAME="OpenVPN/openvpn"
+export COVERITY_SCAN_BRANCH_PATTERN="release\/2.4"
+export COVERITY_SCAN_NOTIFICATION_EMAIL="[email protected]..."
+export COVERITY_SCAN_BUILD_COMMAND_PREPEND="autoreconf -vi &&
./configure --enable-iproute2 && make clean"
.travis/coverity.sh new file +4 -0
+export COVERITY_SCAN_BUILD_COMMAND="make"
+
+if [ "${RUN_COVERITY}" = "1" ]; then
+    # Ignore exit code, script exits with 1 if we're not on the right
branch
+ curl -s "https://scan.coverity.com/scripts/travisci_build_
coverity_scan.sh" | bash || true
.travis/coverity.sh new file +3 -1
+else
+    echo "Skipping coverity scan because \$RUN_COVERITY != \"1\""
+fi
--
2.7.4
------------------------------------------------------------
------------------
Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Илья Шипицин

2017-08-09 05:47 UTC #3 lore raw

2017-08-09 10:41 GMT+05:00 Илья Шипицин <[email protected]...>:

Quoted 23 lines

2017-08-08 20:55 GMT+05:00 Steffan Karger <[email protected]...>:
Quoted 10 lines
Enable coverity analysis for the release/2.4 branch.
We can only do a limited number of coverity scans per week with our FOSS account, but since we only occasionally push commits, that should work out fine. But this limit is the reason we don't use the standard travis addon,
because that would cause the coverity script to run on all of our matrix builds. That would cause us to reach our limit faster, and waste travis' resources.
Quoted 7 lines
Since our FOSS coverity account doesn't handle multiple branches very well,
we have to pick one branch to run coverity on. I think it's best to use the most recent stable branch for that (i.e. for now, release/2.4). Though for ease of maintenance, it's probably best to apply the patch to both master and release/2.4.

Quoted 4 lines

I would refactor it like that https://gist.github.com/chipitsine/
8dcae4ff1d59eb43df39f6015c6106fd
however, your is ok as well

maybe, "script" would be better here
https://gist.github.com/chipitsine/8dcae4ff1d59eb43df39f6015c6106fd#file-gistfile1-txt-L74
than "before_script"

Quoted 92 lines

Quoted 90 lines
Signed-off-by Steffan Karger <[email protected]...>
---
 .travis.yml         |  8 +++++++-
 .travis/coverity.sh | 17 +++++++++++++++++
 2 files changed, 24 insertions(+), 1 deletion(-)
 create mode 100755 .travis/coverity.sh
.travis.yml +2 -0
index db90e03..131d002 100644
@@ -21,10 +21,13 @@ env:
     - OPENSSL_VERSION="1.0.2k"
     - OPENSSL_CFLAGS="-I${PREFIX}/include"
     - OPENSSL_LIBS="-L${PREFIX}/lib -lssl -lcrypto"
+    # The next declaration is the encrypted COVERITY_SCAN_TOKEN, created
+    #   via the "travis encrypt" command using the project repo's public
key
+ - secure: "l9mSnEW4LJqjxftH5i1NdDaYfGmQB
1mPXnSB3DXnsjzkCWZ+yJLfBemfQ0tx/wS7chBYxqUaUIMT0hw4zJVp/LANF Jo2vfh//ymTS6h0uApRY1ofg9Pp1BFcV1laG6/u8pwSZ2EBy/GhCd3DS436o E8sYBRaFM9FU62L/oeQBfJ7r4ID/0eB1b8bqlbD4paty9MHui2P8EZJwR+KA D84prtfpZOcrSMxPh9OUhJxzxUvvVoP4s4+lZ5Kgg1bBQ3yzKGDqe8VOgK2B WCEuezqhMMc8oeKmAe7CUkoz5gsGYH++k3I9XzP9Z4xeJKoQnC/82qi4xkJm laOxdionej9bHIcjfRt7D8j1J0U+wOj4p8VrDy7yHaxuN2fi0K5MGa/CaXQS rkna8dePniCng+xQ2MY/zxuRX2gA6xPNLUyQLU9LqIug7wj4z84Hk9iWib4L 20MoPjeEo+vAUNq8FtjOPxMuHNpv4iGGx6kgJm7RXl5vC5hxfK6MprrnYe2U 5Mcd8jpzagKBaKHL3zV2FxX9k0jRO9Mccz7M2WnaV0MQ6zcngzTN4+s0kCjh fGKd2F2ANT2Gkhj3Me36eNHfuE0dBbvYCMh4b3Mgd7b/OuXwQWdJ8PjJ1WHX jSOw5sHw1suaV6cEO2Meyz5j1tOkyOi0M9QF+LFenQ9vLH4sBCww8U="
matrix:
include:
.travis.yml +4 -1
-    - env: SSLLIB="openssl"
+    - env: SSLLIB="openssl" RUN_COVERITY="1"
       os: linux
       compiler: gcc
     - env: SSLLIB="openssl" OPENSSL_VERSION="1.1.0f"
@@ -91,5 +94,8 @@ install:
   - if [ ! -z "${CHOST}" ]; then unset CC; fi
   - .travis/build-deps.sh > build-deps.log 2>&1 || (cat build-deps.log
 && exit 1)
 
+before_script:
+  - .travis/coverity.sh
+
 script:
- .travis/build-check.sh
.travis/coverity.sh new file +9 -0
new file mode 100755
index 0000000..8bb40f4
@@ -0,0 +1,17 @@
+#!/bin/sh
+set -eu
+
+RUN_COVERITY="${RUN_COVERITY:-0}"
+
+export COVERITY_SCAN_PROJECT_NAME="OpenVPN/openvpn"
+export COVERITY_SCAN_BRANCH_PATTERN="release\/2.4"
+export COVERITY_SCAN_NOTIFICATION_EMAIL="[email protected]..."
+export COVERITY_SCAN_BUILD_COMMAND_PREPEND="autoreconf -vi &&
./configure --enable-iproute2 && make clean"
.travis/coverity.sh new file +4 -0
+export COVERITY_SCAN_BUILD_COMMAND="make"
+
+if [ "${RUN_COVERITY}" = "1" ]; then
+    # Ignore exit code, script exits with 1 if we're not on the right
branch
+ curl -s "https://scan.coverity.com/scripts/travisci_build_coverity_
scan.sh" | bash || true
.travis/coverity.sh new file +3 -1
+else
+    echo "Skipping coverity scan because \$RUN_COVERITY != \"1\""
+fi
--
2.7.4
------------------------------------------------------------
------------------
Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Илья Шипицин

2017-08-09 06:12 UTC #4 lore raw

2017-08-09 10:47 GMT+05:00 Илья Шипицин <[email protected]...>:

Quoted 34 lines

2017-08-09 10:41 GMT+05:00 Илья Шипицин <[email protected]...>:
Quoted 24 lines
2017-08-08 20:55 GMT+05:00 Steffan Karger <[email protected]...>:
Quoted 11 lines
Enable coverity analysis for the release/2.4 branch.
We can only do a limited number of coverity scans per week with our FOSS account, but since we only occasionally push commits, that should work out
fine. But this limit is the reason we don't use the standard travis addon,
because that would cause the coverity script to run on all of our matrix builds. That would cause us to reach our limit faster, and waste travis' resources.
Quoted 7 lines
Since our FOSS coverity account doesn't handle multiple branches very well,
we have to pick one branch to run coverity on. I think it's best to use the most recent stable branch for that (i.e. for now, release/2.4). Though for ease of maintenance, it's probably best to apply the patch to both master and release/2.4.
Quoted 4 lines
I would refactor it like that https://gist.github.com/chipit
sine/8dcae4ff1d59eb43df39f6015c6106fd
however, your is ok as well

Quoted 4 lines

maybe, "script" would be better here https://gist.github.com/chipitsine/
8dcae4ff1d59eb43df39f6015c6106fd#file-gistfile1-txt-L74 than "before_script"

oops, travis does not support braches within matrix

https://gist.github.com/chipitsine/8dcae4ff1d59eb43df39f6015c6106fd#file-gistfile1-txt-L70-L72

sorry for that

Quoted 95 lines

Quoted 94 lines
Quoted 92 lines
Signed-off-by Steffan Karger <[email protected]...>
---
 .travis.yml         |  8 +++++++-
 .travis/coverity.sh | 17 +++++++++++++++++
 2 files changed, 24 insertions(+), 1 deletion(-)
 create mode 100755 .travis/coverity.sh
.travis.yml +2 -0
index db90e03..131d002 100644
@@ -21,10 +21,13 @@ env:
     - OPENSSL_VERSION="1.0.2k"
     - OPENSSL_CFLAGS="-I${PREFIX}/include"
     - OPENSSL_LIBS="-L${PREFIX}/lib -lssl -lcrypto"
+    # The next declaration is the encrypted COVERITY_SCAN_TOKEN, created
+    #   via the "travis encrypt" command using the project repo's
public key
+ - secure: "l9mSnEW4LJqjxftH5i1NdDaYfGmQB
1mPXnSB3DXnsjzkCWZ+yJLfBemfQ0tx/wS7chBYxqUaUIMT0hw4zJVp/LANF Jo2vfh//ymTS6h0uApRY1ofg9Pp1BFcV1laG6/u8pwSZ2EBy/GhCd3DS436o E8sYBRaFM9FU62L/oeQBfJ7r4ID/0eB1b8bqlbD4paty9MHui2P8EZJwR+KA D84prtfpZOcrSMxPh9OUhJxzxUvvVoP4s4+lZ5Kgg1bBQ3yzKGDqe8VOgK2B WCEuezqhMMc8oeKmAe7CUkoz5gsGYH++k3I9XzP9Z4xeJKoQnC/82qi4xkJm laOxdionej9bHIcjfRt7D8j1J0U+wOj4p8VrDy7yHaxuN2fi0K5MGa/CaXQS rkna8dePniCng+xQ2MY/zxuRX2gA6xPNLUyQLU9LqIug7wj4z84Hk9iWib4L 20MoPjeEo+vAUNq8FtjOPxMuHNpv4iGGx6kgJm7RXl5vC5hxfK6MprrnYe2U 5Mcd8jpzagKBaKHL3zV2FxX9k0jRO9Mccz7M2WnaV0MQ6zcngzTN4+s0kCjh fGKd2F2ANT2Gkhj3Me36eNHfuE0dBbvYCMh4b3Mgd7b/OuXwQWdJ8PjJ1WHX jSOw5sHw1suaV6cEO2Meyz5j1tOkyOi0M9QF+LFenQ9vLH4sBCww8U="
matrix:
include:
.travis.yml +4 -1
-    - env: SSLLIB="openssl"
+    - env: SSLLIB="openssl" RUN_COVERITY="1"
       os: linux
       compiler: gcc
     - env: SSLLIB="openssl" OPENSSL_VERSION="1.1.0f"
@@ -91,5 +94,8 @@ install:
   - if [ ! -z "${CHOST}" ]; then unset CC; fi
   - .travis/build-deps.sh > build-deps.log 2>&1 || (cat build-deps.log
 && exit 1)
 
+before_script:
+  - .travis/coverity.sh
+
 script:
- .travis/build-check.sh
.travis/coverity.sh new file +9 -0
new file mode 100755
index 0000000..8bb40f4
@@ -0,0 +1,17 @@
+#!/bin/sh
+set -eu
+
+RUN_COVERITY="${RUN_COVERITY:-0}"
+
+export COVERITY_SCAN_PROJECT_NAME="OpenVPN/openvpn"
+export COVERITY_SCAN_BRANCH_PATTERN="release\/2.4"
+export COVERITY_SCAN_NOTIFICATION_EMAIL="[email protected]..."
+export COVERITY_SCAN_BUILD_COMMAND_PREPEND="autoreconf -vi &&
./configure --enable-iproute2 && make clean"
.travis/coverity.sh new file +4 -0
+export COVERITY_SCAN_BUILD_COMMAND="make"
+
+if [ "${RUN_COVERITY}" = "1" ]; then
+    # Ignore exit code, script exits with 1 if we're not on the right
branch
+ curl -s "https://scan.coverity.com/scr
ipts/travisci_build_coverity_scan.sh" | bash || true
.travis/coverity.sh new file +3 -1
+else
+    echo "Skipping coverity scan because \$RUN_COVERITY != \"1\""
+fi
--
2.7.4
------------------------------------------------------------
------------------
Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Steffan Karger

2017-08-09 20:09 UTC #5 lore raw

Hi,

Quoted 41 lines · Илья Шипицин

2017-08-09 10:47 GMT+05:00 Илья Шипицин <[email protected]... <mailto:[email protected]...>>:
2017-08-09 10:41 GMT+05:00 Илья Шипицин <[email protected]... <mailto:[email protected]...>>:
2017-08-08 20:55 GMT+05:00 Steffan Karger <[email protected]... <mailto:[email protected]...>>:
Enable coverity analysis for the release/2.4 branch.
We can only do a limited number of coverity scans per week with our FOSS
account, but since we only occasionally push commits, that should work out
fine. But this limit is the reason we don't use the standard travis addon,
because that would cause the coverity script to run on all of our matrix
builds. That would cause us to reach our limit faster, and waste travis'
resources.
Since our FOSS coverity account doesn't handle multiple branches very well,
we have to pick one branch to run coverity on. I think it's best to use
the most recent stable branch for that (i.e. for now, release/2.4).
Though for ease of maintenance, it's probably best to apply the patch to
both master and release/2.4.
I would refactor it like that
https://gist.github.com/chipitsine/8dcae4ff1d59eb43df39f6015c6106fd
<https://gist.github.com/chipitsine/8dcae4ff1d59eb43df39f6015c6106fd>
however, your is ok as well
maybe, "script" would be better here
https://gist.github.com/chipitsine/8dcae4ff1d59eb43df39f6015c6106fd#file-gistfile1-txt-L74
<https://gist.github.com/chipitsine/8dcae4ff1d59eb43df39f6015c6106fd#file-gistfile1-txt-L74>
than "before_script"

Quoted 5 lines

oops, travis does not support braches within matrix
https://gist.github.com/chipitsine/8dcae4ff1d59eb43df39f6015c6106fd#file-gistfile1-txt-L70-L72
sorry for that

I like your idea, and toyed with it a bit. But in the end, it needs too much fiddling to get right. So I prefer my own suggested approach.

-Steffan

Илья Шипицин

2017-08-10 05:48 UTC #6 lore raw

2017-08-10 1:09 GMT+05:00 Steffan Karger <[email protected]...>:

Quoted 50 lines

Hi,
Quoted 31 lines · Илья Шипицин
2017-08-09 10:47 GMT+05:00 Илья Шипицин <[email protected]... <mailto:[email protected]...>>:
2017-08-09 10:41 GMT+05:00 Илья Шипицин <[email protected]... <mailto:[email protected]...>>:
2017-08-08 20:55 GMT+05:00 Steffan Karger <[email protected]... <mailto:[email protected]...>>:
Enable coverity analysis for the release/2.4 branch.
We can only do a limited number of coverity scans per week with our FOSS
account, but since we only occasionally push commits, that should work out
fine. But this limit is the reason we don't use the standard travis addon,
because that would cause the coverity script to run on all of our matrix
builds. That would cause us to reach our limit faster, and waste travis'
resources.
Since our FOSS coverity account doesn't handle multiple branches very well,
we have to pick one branch to run coverity on. I think it's best to use
the most recent stable branch for that (i.e. for now, release/2.4).
Though for ease of maintenance, it's probably best to apply the patch to
both master and release/2.4.
Quoted 2 lines
I would refactor it like that
https://gist.github.com/chipitsine/
8dcae4ff1d59eb43df39f6015c6106fd
Quoted 1 line
<https://gist.github.com/chipitsine/
8dcae4ff1d59eb43df39f6015c6106fd>
Quoted 4 lines
however, your is ok as well
maybe, "script" would be better here
https://gist.github.com/chipitsine/8dcae4ff1d59eb43df39f6015c6106
fd#file-gistfile1-txt-L74
Quoted 1 line
    <https://gist.github.com/chipitsine/8dcae4ff1d59eb43df39f6015c6106
fd#file-gistfile1-txt-L74>
Quoted 4 lines
than "before_script"
oops, travis does not support braches within matrix

Quoted 8 lines

Quoted 1 line
https://gist.github.com/chipitsine/8dcae4ff1d59eb43df39f6015c6106
fd#file-gistfile1-txt-L70-L72
Quoted 2 lines
sorry for that
I like your idea, and toyed with it a bit. But in the end, it needs too much fiddling to get right. So I prefer my own suggested approach.

nevermind :)

Quoted 12 lines

-Steffan
------------------------------------------------------------
------------------
Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

David Sommerseth

2017-08-18 17:56 UTC #7 lore raw

In reply to Steffan Karger

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Your patch has been applied to the following branches

commit 4a05f15c9aafe314ae4d3642813ebf234c09276e (master) commit e12d5e35d56103357301d28e3f9ee0468e306bb1 (release/2.4)

Author: Steffan Karger
Date:   Tue Aug 8 17:55:41 2017 +0200

     Add coverity static analysis to Travis CI config

     Signed-off-by: Steffan Karger <[email protected]...>
     Acked-by: Antonio Quartulli <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg15176.html
     Signed-off-by: David Sommerseth <[email protected]...>

- --
kind regards,

David Sommerseth

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iQIcBAEBCgAGBQJZlypjAAoJEIbPlEyWcf3yuQEP/jOPlCPbSsgCDLWUHkNgLhOM CQ32K1dbYuOrPo7pmjewyebF0NdkB6dbUVAMBvy5vWtyPawAz+65KwtKVwORKcf/ INkJwerRG5W9gymd0OeFAydmvQ/OvgI40u8jrLAeGIFlqTsoqg4SmmyNgCnxL7zP u5p3J1j5RcWUBGaOGcUYyJsHGGkMSxlp3CcrDpXevqp65Pb8CvAHuxtOZHxKOrw4 Xm8SfdXaSm2NU0gUeKibQdPqkSq9bU1W1LH22EbxFFJLJVOKtpMvVF3bzbG4xR2c Zw8yFwqLxgwuT7a0/8dIGEgNLapkGKC5NFX+MlVAdG+EjX1cFaLoyeapvBANYqEB 8YjrJZjJPSEUmaejFcnIgMhWIIbsFGg+qzrXfRC601JuxYEEdANknIIlwIo5hXfq NmRD3ViqnBiKCTuW2cs1iMQvsWfyijgKUHkzPZlzllAUlEjKit8KGxbqtmZg5VDI UPOS+gvqQtqK0VRm1IJyKyHLQGIYYmV35rEEBZpA/Yf0sfohaRhzDOVIi1Lq/xQ4 mPyCU978f8plD1Q7QO+x5TGvFYsQaPoYwpd7uApDwDQN5wttMnBebnuHyej0a9Iv w19Brl8N8pypYHM44gkGG40jZaevE+7/qxxNScp5MbbEsJlyCZYCjwyEwUvMZ3ym WVjUZ3xdckzOjQDD0YiG
=M2pE
-----END PGP SIGNATURE-----