KVM: Using macros instead of magic values
PATCH 1/1 KVM: Using macros instead of magic values
From: Haiwei Li <[email protected]>
Instead of using magic values, use macros.
Signed-off-by Haiwei Li <[email protected]>
--- arch/x86/kvm/lapic.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
arch/x86/kvm/lapic.c +2 -1
@@ -2083,7 +2083,8 @@ int kvm_lapic_reg_write(struct kvm_lapic *apic, u32 reg, u32 val)case APIC_SELF_IPI :if (apic_x2apic_mode (apic)) { -kvm_lapic_reg_write (apic,APIC_ICR ,0x40000 | (val &0xff )); +kvm_lapic_reg_write (apic,APIC_ICR , +APIC_DEST_SELF | (val &APIC_VECTOR_MASK )); }else ret =1 ;break ;
--
1.8.3.1
Quoted 23 lines · Haiwei Li
From: Haiwei Li <[email protected]>
Instead of using magic values, use macros.
Signed-off-by Haiwei Li <[email protected]>--- arch/x86/kvm/lapic.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)arch/x86/kvm/lapic.c +2
-1@@ -2083,7 +2083,8 @@ int kvm_lapic_reg_write(struct kvm_lapic *apic, u32 reg, u32 val)case APIC_SELF_IPI :if (apic_x2apic_mode (apic)) { -kvm_lapic_reg_write (apic,APIC_ICR ,0x40000 | (val &0xff )); +kvm_lapic_reg_write (apic,APIC_ICR , +APIC_DEST_SELF | (val &APIC_VECTOR_MASK )); }else ret =1 ;
Quoted 4 lines
break;
--
1.8.3.1
Reviewed-by Vitaly Kuznetsov <[email protected]>
Signature · 1 line
Vitaly
Quoted 16 lines · Haiwei Li
From: Haiwei Li <[email protected]>
Instead of using magic values, use macros.
Signed-off-by Haiwei Li <[email protected]>---
arch/x86/kvm/lapic.c | 3 ++-1 file changed, 2 insertions(+), 1 deletion(-)arch/x86/kvm/lapic.c +0
-0@@ -2083,7 +2083,8 @@ int kvm_lapic_reg_write(struct kvm_lapic *apic, u32 reg, u32 val)
Quoted 11 lines
case
APIC_SELF_IPI:
if (apic_x2apic_mode(apic)) {
-kvm_lapic_reg_write(apic, APIC_ICR, 0x40000 | (val & 0xff)); + kvm_lapic_reg_write(apic,APIC_ICR,
+APIC_DEST_SELF| (val &APIC_VECTOR_MASK)); } else
ret = 1;
break;Signature · 1 line
1.8.3.1
Queued, thanks.
Paolo