Skip to contentSkip to conversation

KVM: Using macros instead of magic values

PATCH Applied Haiwei Li 3 participants 3 messages Jul 21, 2020 – Jul 27, 2020

Subsystems (3)
lore
Share & tools
lore

Haiwei Li

author
#0 lore raw

PATCH 1/1 KVM: Using macros instead of magic values

From: Haiwei Li <[email protected]>

Instead of using magic values, use macros.

---
 arch/x86/kvm/lapic.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/x86/kvm/lapic.c +2 -1
index 47801a4..d5fb2ea 100644
@@ -2083,7 +2083,8 @@ int kvm_lapic_reg_write(struct kvm_lapic *apic, u32 reg, u32 val)
 
 	case APIC_SELF_IPI:
 		if (apic_x2apic_mode(apic)) {
-			kvm_lapic_reg_write(apic, APIC_ICR, 0x40000 | (val & 0xff));
+			kvm_lapic_reg_write(apic, APIC_ICR,
+					    APIC_DEST_SELF | (val & APIC_VECTOR_MASK));
 		} else
 			ret = 1;
 		break;

--
1.8.3.1

Reviewed-by on v1 1/1
#1 lore raw
Quoted 23 lines · Haiwei Li

From: Haiwei Li <[email protected]>

Instead of using magic values, use macros.

---
  arch/x86/kvm/lapic.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
arch/x86/kvm/lapic.c +2 -1
index 47801a4..d5fb2ea 100644
@@ -2083,7 +2083,8 @@ int kvm_lapic_reg_write(struct kvm_lapic *apic, 
 u32 reg, u32 val)
 
  	case APIC_SELF_IPI:
  		if (apic_x2apic_mode(apic)) {
-			kvm_lapic_reg_write(apic, APIC_ICR, 0x40000 | (val & 0xff));
+			kvm_lapic_reg_write(apic, APIC_ICR,
+					    APIC_DEST_SELF | (val & APIC_VECTOR_MASK));
  		} else
  			ret = 1;
Quoted 4 lines

break;
--
1.8.3.1

Signature · 1 line
Vitaly
maintainer Applied
#2 lore raw
In reply to Haiwei Li
Quoted 16 lines · Haiwei Li

From: Haiwei Li <[email protected]>

Instead of using magic values, use macros.

---
 arch/x86/kvm/lapic.c | 3 ++-

 1 file changed, 2 insertions(+), 1 deletion(-)
arch/x86/kvm/lapic.c +0 -0
index 47801a4..d5fb2ea 100644
@@ -2083,7 +2083,8 @@ int kvm_lapic_reg_write(struct kvm_lapic *apic,
 u32 reg, u32 val)
 
Quoted 11 lines

     case APIC_SELF_IPI:
         if (apic_x2apic_mode(apic)) {
-            kvm_lapic_reg_write(apic, APIC_ICR, 0x40000 | (val & 0xff)); +            kvm_lapic_reg_write(apic, APIC_ICR,
+                        APIC_DEST_SELF | (val & APIC_VECTOR_MASK)); } else
             ret = 1;
         break;

Signature · 1 line
1.8.3.1

Queued, thanks.

Paolo