Skip to contentSkip to conversation

OMAP2: OMAPFB: Fix invalid bpp for PAL and NTSC modes

PATCH Applied Maurus Cuelenaere 2 participants 2 messages Jul 21, 2010 – Jul 26, 2010 Framebuffer layer

lore
Share & tools
lore

Maurus Cuelenaere

author
#0 lore raw

PATCH 1/1 OMAP2: OMAPFB: Fix invalid bpp for PAL and NTSC modes

omapfb_mode_to_timings() sets the bpp to 0 when bootarg omapfb.mode is set to either "pal" or "ntsc". This patch corrects this by setting the bpp to 24, as would be done if omapdss_default_get_recommended_bpp() would be called

Signed-off-by Maurus Cuelenaere <[email protected]>
---
 drivers/video/omap2/omapfb/omapfb-main.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/video/omap2/omapfb/omapfb-main.c +2 -2
index 4b4506d..500458e 100644
@@ -1968,11 +1968,11 @@ static int omapfb_mode_to_timings(const char *mode_str,
 #ifdef CONFIG_OMAP2_DSS_VENC
 	if (strcmp(mode_str, "pal") = 0) {
 		*timings = omap_dss_pal_timings;
-		*bpp = 0;
+		*bpp = 24;
 		return 0;
 	} else if (strcmp(mode_str, "ntsc") = 0) {
 		*timings = omap_dss_ntsc_timings;
-		*bpp = 0;
+		*bpp = 24;
 		return 0;
 	}
 #endif
Signature · 1 line
1.7.0.4
Applied
#1 lore raw
Quoted 3 lines · ext Maurus Cuelenaere

omapfb_mode_to_timings() sets the bpp to 0 when bootarg omapfb.mode is set to either "pal" or "ntsc". This patch corrects this by setting the bpp to 24, as would be done if omapdss_default_get_recommended_bpp() would be called

Thanks, applied to my tree.

Tomi