Skip to contentSkip to conversation

Document PolarFire SoC can controller

PATCH In review Conor Dooley 3 participants 11 messages Jun 7, 2022 – Jun 13, 2022

Subsystems (6)
lore
Share & tools
lore

Conor Dooley

author maintainer
#0 lore raw

cover Document PolarFire SoC can controller

Hey,
When adding the dts for PolarFire SoC, the can controllers were omitted, so here they are...

Thanks,
Conor.

Conor Dooley (2):
dt-bindings: can: mpfs: document the mpfs can controller
riscv: dts: microchip: add mpfs's can controllers

 .../bindings/net/can/microchip,mpfs-can.yaml  | 45 +++++++++++++++++++
 .../boot/dts/microchip/microchip-mpfs.dtsi    | 18 ++++++++
 2 files changed, 63 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml
Signature · 1 line
2.36.1
author maintainer
#1 lore raw

PATCH 1/2 dt-bindings: can: mpfs: document the mpfs can controller

Add a binding for the can controller on PolarFire SoC (MPFS).

---
 .../bindings/net/can/microchip,mpfs-can.yaml  | 45 +++++++++++++++++++
 1 file changed, 45 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml
Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml new file +45 -0
new file mode 100644
index 000000000000..45aa3de7cf01
@@ -0,0 +1,45 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/can/microchip,mpfs-can.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title:
+  Microchip PolarFire SoC (MPFS) can controller
+
+maintainers:
+  - Conor Dooley <[email protected]>
+
+allOf:
+  - $ref: can-controller.yaml#
+
+properties:
+  compatible:
+    const: microchip,mpfs-can
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - clocks
+
+additionalProperties: false
+
+examples:
+  - |
+    can@2010c000 {
+        compatible = "microchip,mpfs-can";
+        reg = <0x2010c000 0x1000>;
+        clocks = <&clkcfg 17>;
+        interrupt-parent = <&plic>;
+        interrupts = <56>;
+    };
Signature · 1 line
2.36.1
maintainer Reviewed-by on v1 1/2
#2 lore raw

Re: [PATCH net-next 1/2] dt-bindings: can: mpfs: document the mpfs can controller

Quoted 8 lines · Conor Dooley

Add a binding for the can controller on PolarFire SoC (MPFS).

---
 .../bindings/net/can/microchip,mpfs-can.yaml  | 45 +++++++++++++++++++
 1 file changed, 45 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml
author maintainer
#3 lore raw

PATCH 2/2 riscv: dts: microchip: add mpfs's can controllers

In reply to Conor Dooley

PolarFire SoC has a pair of can controllers, but as they were undocumented there were omitted from the device tree. Add them.

---
 .../boot/dts/microchip/microchip-mpfs.dtsi     | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi +18 -0
index cf2f55e1dcb6..059a671314bf 100644
@@ -326,6 +326,24 @@ i2c1: i2c@2010b000 {
 			status = "disabled";
 		};
 
+		can0: can@2010c000 {
+			compatible = "microchip,mpfs-can";
+			reg = <0x0 0x2010c000 0x0 0x1000>;
+			clocks = <&clkcfg CLK_CAN0>;
+			interrupt-parent = <&plic>;
+			interrupts = <56>;
+			status = "disabled";
+		};
+
+		can1: can@2010d000 {
+			compatible = "microchip,mpfs-can";
+			reg = <0x0 0x2010d000 0x0 0x1000>;
+			clocks = <&clkcfg CLK_CAN1>;
+			interrupt-parent = <&plic>;
+			interrupts = <57>;
+			status = "disabled";
+		};
+
 		mac0: ethernet@20110000 {
 			compatible = "cdns,macb";
 			reg = <0x0 0x20110000 0x0 0x2000>;
Signature · 1 line
2.36.1
#4 lore raw
In reply to Conor Dooley
Quoted 1 line · Conor Dooley

When adding the dts for PolarFire SoC, the can controllers were

                                             ^^^
Quoted 1 line

omitted, so here they are...

Nitpick:
Consider writing "CAN" in capital letters to avoid confusion for the not informed reader.

Is the documentation for the CAN controller openly available? Is there a driver somewhere?

Marc

Signature · 4 lines
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |
author maintainer
#5 lore raw
Quoted 8 lines · Marc Kleine-Budde
Quoted 1 line · Conor Dooley

When adding the dts for PolarFire SoC, the can controllers were

                                              ^^^
Quoted 1 line

omitted, so here they are...

Nitpick:
Consider writing "CAN" in capital letters to avoid confusion for the not informed reader.

Yeah, sure. I'll try to get over my fear of capital letters ;)

Quoted 3 lines

Is the documentation for the CAN controller openly available? Is there a driver somewhere?

There is a driver /but/ for now only a UIO one so I didn't send it. There's an online doc & if the horrible link doesn't drop you there directly, its section 6.12.3:
https://onlinedocs.microchip.com/pr/GUID-0E320577-28E6-4365-9BB8-9E1416A0A6E4-en-US-3/index.html?GUID-A362DC3C-83B7-4441-BECB-B19F9AD48B66

And a PDF direct download here, see section 4.12.3 (page 72):
https://www.microsemi.com/document-portal/doc_download/1245725-polarfire-soc-fpga-mss-technical-reference-manual

Thanks,
Conor.

#6 lore raw
Quoted 11 lines · On 07.06.2022 07:52:30, [email protected] wrote:
Quoted 8 lines · Marc Kleine-Budde
Quoted 1 line · Conor Dooley

When adding the dts for PolarFire SoC, the can controllers were

                                            ^^^
Quoted 1 line

omitted, so here they are...

Nitpick:
Consider writing "CAN" in capital letters to avoid confusion for the not informed reader.

Yeah, sure. I'll try to get over my fear of capital letters ;)

:)

Quoted 4 lines
Quoted 2 lines

Is the documentation for the CAN controller openly available? Is there a driver somewhere?

There is a driver /but/ for now only a UIO one so I didn't send it.

Brrrrr...

Quoted 6 lines

There's an online doc & if the horrible link doesn't drop you there directly, its section 6.12.3:
https://onlinedocs.microchip.com/pr/GUID-0E320577-28E6-4365-9BB8-9E1416A0A6E4-en-US-3/index.html?GUID-A362DC3C-83B7-4441-BECB-B19F9AD48B66

And a PDF direct download here, see section 4.12.3 (page 72):
https://www.microsemi.com/document-portal/doc_download/1245725-polarfire-soc-fpga-mss-technical-reference-manual

Thanks. The documentation is quite sparse, is there a more detailed one? The register map cannot be downloaded directly anymore. For reference:

http://web.archive.org/web/20220403030214/https://www.microsemi.com/document-portal/doc_download/1244581-polarfire-soc-register-map

regards,
Marc

Signature · 4 lines
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |
author maintainer
#7 lore raw
Quoted 13 lines · Marc Kleine-Budde
Quoted 11 lines · On 07.06.2022 07:52:30, [email protected] wrote:
Quoted 8 lines · Marc Kleine-Budde
Quoted 1 line · Conor Dooley

When adding the dts for PolarFire SoC, the can controllers were

                                             ^^^
Quoted 1 line

omitted, so here they are...

Nitpick:
Consider writing "CAN" in capital letters to avoid confusion for the not informed reader.

Yeah, sure. I'll try to get over my fear of capital letters ;)

Quoted 8 lines

:)

Quoted 4 lines
Quoted 2 lines

Is the documentation for the CAN controller openly available? Is there a driver somewhere?

There is a driver /but/ for now only a UIO one so I didn't send it.

Brrrrr...

Yeah, I know..

Quoted 9 lines
Quoted 7 lines

There's an online doc & if the horrible link doesn't drop you there directly, its section 6.12.3:
https://onlinedocs.microchip.com/pr/GUID-0E320577-28E6-4365-9BB8-9E1416A0A6E4-en-US-3/index.html?GUID-A362DC3C-83B7-4441-BECB-B19F9AD48B66

And a PDF direct download here, see section 4.12.3 (page 72):
https://www.microsemi.com/document-portal/doc_download/1245725-polarfire-soc-fpga-mss-technical-reference-manual

Thanks. The documentation is quite sparse, is there a more detailed one?

Nope, that's all I've got...

Quoted 3 lines

The register map cannot be downloaded directly anymore. For reference:

http://web.archive.org/web/20220403030214/https://www.microsemi.com/document-portal/doc_download/1244581-polarfire-soc-register-map

Oh that sucks. I know we have had some website issues over the weekend which might be the problem there. I'll try to bring it up and find out.

Quoted 4 lines

regards,
Marc

author maintainer
#8 lore raw
Quoted 35 lines · On 07/06/2022 09:54, [email protected] wrote:
Quoted 13 lines · Marc Kleine-Budde
Quoted 11 lines · On 07.06.2022 07:52:30, [email protected] wrote:
Quoted 8 lines · Marc Kleine-Budde
Quoted 1 line · Conor Dooley

When adding the dts for PolarFire SoC, the can controllers were

                                              ^^^
Quoted 1 line

omitted, so here they are...

Nitpick:
Consider writing "CAN" in capital letters to avoid confusion for the not informed reader.

Yeah, sure. I'll try to get over my fear of capital letters ;)

Quoted 8 lines

:)

Quoted 4 lines
Quoted 2 lines

Is the documentation for the CAN controller openly available? Is there a driver somewhere?

There is a driver /but/ for now only a UIO one so I didn't send it.

Brrrrr...

Yeah, I know..

Quoted 9 lines
Quoted 7 lines

There's an online doc & if the horrible link doesn't drop you there directly, its section 6.12.3:
https://onlinedocs.microchip.com/pr/GUID-0E320577-28E6-4365-9BB8-9E1416A0A6E4-en-US-3/index.html?GUID-A362DC3C-83B7-4441-BECB-B19F9AD48B66

And a PDF direct download here, see section 4.12.3 (page 72):
https://www.microsemi.com/document-portal/doc_download/1245725-polarfire-soc-fpga-mss-technical-reference-manual

Thanks. The documentation is quite sparse, is there a more detailed one?

Quoted 9 lines

Nope, that's all I've got...

Quoted 3 lines

The register map cannot be downloaded directly anymore. For reference:

http://web.archive.org/web/20220403030214/https://www.microsemi.com/document-portal/doc_download/1244581-polarfire-soc-register-map

Oh that sucks. I know we have had some website issues over the weekend which might be the problem there. I'll try to bring it up and find out.

Hey Marc,
Doc is still not available but should be getting fixed.
What do I need to do for this binding? Are you happy to accept it without a driver if I add links to the documentation and a working link to the register map?
Thanks,
Conor.
_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv

#9 lore raw
Quoted 10 lines · On 13.06.2022 12:52:00, [email protected] wrote:
Quoted 7 lines
Quoted 3 lines

The register map cannot be downloaded directly anymore. For reference:

http://web.archive.org/web/20220403030214/https://www.microsemi.com/document-portal/doc_download/1244581-polarfire-soc-register-map

Oh that sucks. I know we have had some website issues over the weekend which might be the problem there. I'll try to bring it up and find out.

Hey Marc,
Doc is still not available but should be getting fixed.

Thanks.

Quoted 3 lines

What do I need to do for this binding? Are you happy to accept it without a driver if I add links to the documentation and a working link to the register map?

I'm taking both patches and change the CAN into capital letters while applying, I'll also add a link to the datasheets.

regards,
Marc

Signature · 4 lines
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv

author maintainer
#10 lore raw
Quoted 12 lines · Marc Kleine-Budde
Quoted 10 lines · On 13.06.2022 12:52:00, [email protected] wrote:
Quoted 7 lines
Quoted 3 lines

The register map cannot be downloaded directly anymore. For reference:

http://web.archive.org/web/20220403030214/https://www.microsemi.com/document-portal/doc_download/1244581-polarfire-soc-register-map

Oh that sucks. I know we have had some website issues over the weekend which might be the problem there. I'll try to bring it up and find out.

Hey Marc,
Doc is still not available but should be getting fixed.

Quoted 8 lines

Thanks.

Quoted 3 lines

What do I need to do for this binding? Are you happy to accept it without a driver if I add links to the documentation and a working link to the register map?

I'm taking both patches and change the CAN into capital letters while applying, I'll also add a link to the datasheets.

Cool, SGTM.
Thanks,
Conor.
_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv