Skip to contentSkip to conversation

Minor VXHS fixups

PATCH In review Jeff Cody 2 participants 5 messages May 4, 2017 – May 8, 2017 Block layer

lore
Share & tools
lore

Jeff Cody

author
#0 lore raw

cover Minor VXHS fixups

This fixes a couple of small issues with VXHS; modularization, and improved error messaging.

Jeff Cody (2):
block/vxhs: Allow VXHS to be built as a module
block/vxhs: set errp on iio_init() failure

 block/vxhs.c | 1 +
 configure    | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
Signature · 1 line
2.9.3
author
#1 lore raw

PATCH 1/2 block/vxhs: Allow VXHS to be built as a module

In 88d8879, protocol drivers had modularization enabled. As VXHS is a protocol, make sure it is able to be built as a module as well.

Signed-off-by Jeff Cody <[email protected]>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configure +1 -1
index 48a9370..eada141 100755
@@ -5859,7 +5859,7 @@ if test "$pthread_setname_np" = "yes" ; then
 fi
 
 if test "$vxhs" = "yes" ; then
-  echo "CONFIG_VXHS=y" >> $config_host_mak
+  echo "CONFIG_VXHS=m" >> $config_host_mak
   echo "VXHS_LIBS=$vxhs_libs" >> $config_host_mak
 fi
Signature · 1 line
2.9.3
#2 lore raw

Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] block/vxhs: Allow VXHS to be built as a module

Quoted 14 lines · Jeff Cody

In 88d8879, protocol drivers had modularization enabled. As VXHS is a protocol, make sure it is able to be built as a module as well.

Signed-off-by Jeff Cody <[email protected]>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configure +0 -0
index 48a9370..eada141 100755

configure if test "$pthread_setname_np" = "yes" ; then · line 5865

Quoted 8 lines
configure +1 -1
@@ -5859,7 +5859,7 @@ if test "$pthread_setname_np" = "yes" ; then
 fi
 
 if test "$vxhs" = "yes" ; then
-  echo "CONFIG_VXHS=y" >> $config_host_mak
+  echo "CONFIG_VXHS=m" >> $config_host_mak
   echo "VXHS_LIBS=$vxhs_libs" >> $config_host_mak
 fi

ERROR: User requested feature vxhs block device
configure was not able to find it.
Install libvxhs See github

wow gee, thanks configure file. I'll go "see github."

Not actually that easy to find; separate patch, but could this be touched up?

author
#3 lore raw

Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] block/vxhs: Allow VXHS to be built as a module

Quoted 30 lines · John Snow
Quoted 14 lines · Jeff Cody

In 88d8879, protocol drivers had modularization enabled. As VXHS is a protocol, make sure it is able to be built as a module as well.

Signed-off-by Jeff Cody <[email protected]>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configure +0 -0
index 48a9370..eada141 100755

configure if test "$pthread_setname_np" = "yes" ; then · line 5865

Quoted 8 lines
configure +1 -1
@@ -5859,7 +5859,7 @@ if test "$pthread_setname_np" = "yes" ; then
 fi
 
 if test "$vxhs" = "yes" ; then
-  echo "CONFIG_VXHS=y" >> $config_host_mak
+  echo "CONFIG_VXHS=m" >> $config_host_mak
   echo "VXHS_LIBS=$vxhs_libs" >> $config_host_mak
 fi

ERROR: User requested feature vxhs block device
configure was not able to find it.
Install libvxhs See github

Quoted 4 lines

wow gee, thanks configure file. I'll go "see github."

Not actually that easy to find; separate patch, but could this be touched up?

Sure, that is an easy touch up. I'll add it as a v2 to this patch.

author
#4 lore raw

PATCH 2/2 block/vxhs: set errp on iio_init() failure

In reply to Jeff Cody
Signed-off-by Jeff Cody <[email protected]>
---
 block/vxhs.c | 1 +
 1 file changed, 1 insertion(+)
block/vxhs.c +1 -0
index 9ffe9d3..1f1e5db 100644
@@ -301,6 +301,7 @@ static int vxhs_open(BlockDriverState *bs, QDict *options,
 
     ret = vxhs_init_and_ref();
     if (ret < 0) {
+        error_setg(&local_err, "libvxhs iio_init() failed");
         ret = -EINVAL;
         goto out;
     }
Signature · 1 line
2.9.3