Skip to contentSkip to conversation

ARM: SAMSUNG: Fix warning 's3c_pm_show_resume_irqs' defined but not used

PATCH In review Maurus Cuelenaere 2 participants 2 messages Oct 5, 2010 – Apr 2, 2011

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: SAMSUNG: Fix warning 's3c_pm_show_resume_irqs' defined but not used

s3c_pm_show_resume_irqs() is used by some s3c_pm_arch_show_resume_irqs() implementations, which get included through mach/pm-core.h. Add __maybe_unused to silence warnings when it isn't used (e.g. on S3C64XX platforms).

---
 arch/arm/plat-samsung/pm.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
arch/arm/plat-samsung/pm.c +3 -2
index 27cfca5..ad6dd63 100644
@@ -214,8 +214,9 @@ void s3c_pm_do_restore_core(struct sleep_save *ptr, int count)
  *
  * print any IRQs asserted at resume time (ie, we woke from)
 */
-static void s3c_pm_show_resume_irqs(int start, unsigned long which,
-				    unsigned long mask)
+static void __maybe_unused s3c_pm_show_resume_irqs(int start,
+						   unsigned long which,
+						   unsigned long mask)
 {
 	int i;
 
Signature · 1 line
1.7.2.3
#1 lore raw

arch/arm/plat-samsung/pm.c void s3c_pm_do_restore_core(struct sleep_save *ptr,

Quoted 16 lines · Maurus Cuelenaere

s3c_pm_show_resume_irqs() is used by some s3c_pm_arch_show_resume_irqs() implementations, which get included through mach/pm-core.h. Add __maybe_unused
to silence warnings when it isn't used (e.g. on S3C64XX platforms).

---
 arch/arm/plat-samsung/pm.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
arch/arm/plat-samsung/pm.c +0 -0
index 27cfca5..ad6dd63 100644
@@ -214,8 +214,9 @@ void s3c_pm_do_restore_core(struct sleep_save *ptr,

int

arch/arm/plat-samsung/pm.c void s3c_pm_do_restore_core(struct sleep_save *ptr, int count)

Quoted 13 lines
arch/arm/plat-samsung/pm.c +3 -3
 count)
  *
  * print any IRQs asserted at resume time (ie, we woke from)
 */
-static void s3c_pm_show_resume_irqs(int start, unsigned long which,
-				    unsigned long mask)
+static void __maybe_unused s3c_pm_show_resume_irqs(int start,
+						   unsigned long which,
+						   unsigned long mask)
 {
 	int i;
 
--

Missed for a long time :(

Abhilash, thanks for your reminder.

Ok, will apply.
Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.