Skip to contentSkip to conversation

persistent store (version 2) (part 2 of 2)

RFC In review Luck, Tony 2 participants 2 messages Dec 1, 2010 – Dec 2, 2010

Subsystems (4)
lore
Share & tools
lore

Luck, Tony

author reviewer
#0 lore raw

RFC 1/1 persistent store (version 2) (part 2 of 2)

Here are the changes to ERST to use the persistent store.

-Tony

---

drivers/acpi/apei/Kconfig +1 -0
index fca34cc..e91680c 100644
@@ -1,5 +1,6 @@
 config ACPI_APEI
 	bool "ACPI Platform Error Interface (APEI)"
+	select PSTORE
 	depends on X86
 	help
 	  APEI allows to report errors (for example from the chipset)
drivers/acpi/apei/erst.c +110 -0

128 lines not on this page · raw message

#1 lore raw

Hi, Tony,

Quoted 30 lines · Tony

Here are the changes to ERST to use the persistent store.

(quoted diff) +0 -2
-Tony
 
---
drivers/acpi/apei/Kconfig +1 -0
index fca34cc..e91680c 100644
@@ -1,5 +1,6 @@
 config ACPI_APEI
 	bool "ACPI Platform Error Interface (APEI)"
+	select PSTORE
 	depends on X86
 	help
 	  APEI allows to report errors (for example from the chipset)
drivers/acpi/apei/erst.c +1 -0
index 1211c03..2a49015 100644
@@ -34,6 +34,7 @@
 #include <linux/cper.h>
 #include <linux/nmi.h>
 #include <linux/hardirq.h>
+#include <linux/pstore.h>
 #include <acpi/apei.h>
 
 #include "apei-internal.h"

drivers/acpi/apei/erst.c static int erst_check_table(struct acpi_table_erst *erst_tab) · line 787

Quoted 6 lines
drivers/acpi/apei/erst.c +3 -0
@@ -781,6 +782,111 @@ static int erst_check_table(struct acpi_table_erst *erst_tab)
 	return 0;
 }
 
+#define CPER_CREATOR_MCE						\
+	UUID_LE(0x75a574e3, 0x5052, 0x4b29, 0x8a, 0x8e, 0xbe, 0x2c,	\
+		0x64, 0x90, 0xb8, 0x9d)

How about rename this to CPER_CREATOR_LINUX or CPER_CREATOR_PSTORE?

drivers/acpi/apei/erst.c static int erst_check_table(struct acpi_table_erst *erst_tab) · line 799

Quoted 12 lines
drivers/acpi/apei/erst.c +12 -0
+#define CPER_SECTION_TYPE_DMESG						\
+	UUID_LE(0xc197e04e, 0xd545, 0x4a70, 0x9c, 0x17, 0xa5, 0x54,	\
+		0x94, 0x19, 0xeb, 0x12)
+#define CPER_SECTION_TYPE_MCE						\
+	UUID_LE(0xfe08ffbe, 0x95e4, 0x4be7, 0xbc, 0x73, 0x40, 0x96,	\
+		0x04, 0x4a, 0x38, 0xfc)
+
+struct cper_mce_record {
+	struct cper_record_header hdr;
+	struct cper_section_descriptor sec_hdr;
+	char data[];
+} __packed;

Renamed to cper_pstore_record?

[...]

Best Regards,
Huang Ying