Skip to contentSkip to conversation

process_madvise.2: SYNOPSIS: Fix prototype parameter type

PATCH In review Alejandro Colomar 2 participants 2 messages Feb 11, 2021 – Feb 13, 2021 Man-pages: manual pages for Linux -- Sections 2, 3, 4, 5, and 7

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 process_madvise.2: SYNOPSIS: Fix prototype parameter type

The type of vlen is 'size_t', and not 'unsigned int'. Fix it.

......

$ grep_syscall process_madvise
mm/madvise.c:1161:
SYSCALL_DEFINE5(process_madvise, int, pidfd, const struct iovec __user *, vec,
		size_t, vlen, int, behavior, unsigned int, flags)
include/linux/syscalls.h:887:
asmlinkage long sys_process_madvise(int pidfd, const struct iovec __user *vec,
			size_t vlen, int behavior, unsigned int flags);

function grep_syscall()

{
	if ! [ -v 1 ]; then
		>&2 echo "Usage: ${FUNCNAME[0]} <syscall>";
		return ${EX_USAGE};
	fi

	find * -type f \
	|grep '\.c$' \
	|sort -V \
	|xargs pcregrep -Mn "(?s)^\w*SYSCALL_DEFINE.\(${1},.*?\)" \
	|sed -E 's/^[^:]+:[0-9]+:/&\n/';

	find * -type f \
	|grep '\.[ch]$' \
	|sort -V \
	|xargs pcregrep -Mn "(?s)^asmlinkage\s+[\w\s]+\**sys_${1}\s*\(.*?\)" \
	|sed -E 's/^[^:]+:[0-9]+:/&\n/';
}
---
 man2/process_madvise.2 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
man2/process_madvise.2 +1 -1
index 9dc90ced1..b00ceb6fc 100644
@@ -33,7 +33,7 @@ process_madvise \- give advice about use of memory to a process
 .B #include <sys/uio.h>
 .PP
 .BI "ssize_t process_madvise(int " pidfd ", const struct iovec *" iovec ,
-.BI "                        unsigned long " vlen ", int " advice ,
+.BI "                        size_t " vlen ", int " advice ,
 .BI "                        unsigned int " flags ");"
 .fi
 .PP
Signature · 1 line
2.30.0
#1 lore raw

Hi Alex,

Quoted 32 lines · Alejandro Colomar

The type of vlen is 'size_t', and not 'unsigned int'. Fix it.

......

$ grep_syscall process_madvise
mm/madvise.c:1161:
SYSCALL_DEFINE5(process_madvise, int, pidfd, const struct iovec __user *, vec,
		size_t, vlen, int, behavior, unsigned int, flags)
include/linux/syscalls.h:887:
asmlinkage long sys_process_madvise(int pidfd, const struct iovec __user *vec,
			size_t vlen, int behavior, unsigned int flags);

function grep_syscall()

{
	if ! [ -v 1 ]; then
		>&2 echo "Usage: ${FUNCNAME[0]} <syscall>";
		return ${EX_USAGE};
	fi

	find * -type f \
	|grep '\.c$' \
	|sort -V \
	|xargs pcregrep -Mn "(?s)^\w*SYSCALL_DEFINE.\(${1},.*?\)" \
	|sed -E 's/^[^:]+:[0-9]+:/&\n/';

	find * -type f \
	|grep '\.[ch]$' \
	|sort -V \
	|xargs pcregrep -Mn "(?s)^asmlinkage\s+[\w\s]+\**sys_${1}\s*\(.*?\)" \
	|sed -E 's/^[^:]+:[0-9]+:/&\n/';
}
Quoted 1 line

Thanks. Patch applied.

Cheers,

Michael

Quoted 18 lines
---
 man2/process_madvise.2 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
man2/process_madvise.2 +1 -1
index 9dc90ced1..b00ceb6fc 100644
@@ -33,7 +33,7 @@ process_madvise \- give advice about use of memory to a process
 .B #include <sys/uio.h>
 .PP
 .BI "ssize_t process_madvise(int " pidfd ", const struct iovec *" iovec ,
-.BI "                        unsigned long " vlen ", int " advice ,
+.BI "                        size_t " vlen ", int " advice ,
 .BI "                        unsigned int " flags ");"
 .fi
 .PP
Signature · 3 lines
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/