target/ppc/cpu-models: Remove the "default" CPU alias
PATCH 1/1 target/ppc/cpu-models: Remove the "default" CPU alias
QEMU emulates a *lot* of PowerPC-based machines - having a CPU that is named "default" and cannot be used with most of those machines sounds just wrong. Thus let's remove this old and confusing alias now.
--- target/ppc/cpu-models.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
target/ppc/cpu-models.c +1 -1
@@ -918,6 +918,6 @@ PowerPCCPUAlias ppc_cpu_aliases[] = {#endif { "ppc32", "604" }, { "ppc", "604" }, - { "default", "604" }, + { NULL, NULL } };
Signature · 1 line
2.31.1
Quoted 7 lines · On Tue, 5 Jul 2022 17:10:30 +0200 Thomas Huth <[email protected]> wrote:
QEMU emulates a *lot* of PowerPC-based machines - having a CPU that is named "default" and cannot be used with most of those machines sounds just wrong. Thus let's remove this old and confusing alias now.
Signed-off-by Thomas Huth <[email protected]>---
Good riddance !
Quoted 15 lines
target/ppc/cpu-models.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)target/ppc/cpu-models.c +1
-1@@ -918,6 +918,6 @@ PowerPCCPUAlias ppc_cpu_aliases[] = {#endif { "ppc32", "604" }, { "ppc", "604" }, - { "default", "604" }, + { NULL, NULL } };
Quoted 15 lines · Thomas Huth
QEMU emulates a *lot* of PowerPC-based machines - having a CPU that is named "default" and cannot be used with most of those machines sounds just wrong. Thus let's remove this old and confusing alias now.
Signed-off-by Thomas Huth <[email protected]>--- target/ppc/cpu-models.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)target/ppc/cpu-models.c +0
-0
target/ppc/cpu-models.c PowerPCCPUAlias ppc_cpu_aliases[] = { · line 923
Quoted 7 lines
target/ppc/cpu-models.c +1
-1@@ -918,6 +918,6 @@ PowerPCCPUAlias ppc_cpu_aliases[] = {#endif { "ppc32", "604" }, { "ppc", "604" }, - { "default", "604" }, + { NULL, NULL } };
A default CPU introduced in 1994. Time to change !
Thanks,
C.
Quoted 10 lines · Thomas Huth
QEMU emulates a *lot* of PowerPC-based machines - having a CPU that is named "default" and cannot be used with most of those machines sounds just wrong. Thus let's remove this old and confusing alias now.
Signed-off-by Thomas Huth <[email protected]>--- target/ppc/cpu-models.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Do we need to document this in removed-features.rst ?
-- PMM
Quoted 7 lines · Peter Maydell
Quoted 6 lines · Thomas Huth
QEMU emulates a *lot* of PowerPC-based machines - having a CPU that is named "default" and cannot be used with most of those machines sounds just wrong. Thus let's remove this old and confusing alias now.
Quoted 6 lines
Quoted 4 lines
Signed-off-by Thomas Huth <[email protected]>--- target/ppc/cpu-models.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Do we need to document this in
removed-features.rst?
Honestly, I don't think that anybody ever really used this in the past 15 years. It was likely used with the "prep" machine, but we removed that one a couple of years already. The only machine that is still using this class of PowerPC CPUs is its successor, the 40p machine, but it has a 604 by default anyway, and I've never seen anybody using "-cpu default" with that machine. So IMHO it's not necessary to document this - but if people here have a different feeling, then I can also respin the patch, just let me know.
Thomas
Quoted 8 lines · Thomas Huth
Quoted 7 lines · Peter Maydell
Quoted 6 lines · Thomas Huth
QEMU emulates a *lot* of PowerPC-based machines - having a CPU that is named "default" and cannot be used with most of those machines sounds just wrong. Thus let's remove this old and confusing alias now.
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Signed-off-by Thomas Huth <[email protected]>---
target/ppc/cpu-models.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)Do we need to document this in
removed-features.rst?Honestly, I don't think that anybody ever really used this in the past 15 years. It was likely used with the "prep" machine, but we removed that one a couple of years already. The only machine that is still using this class of PowerPC CPUs is its successor, the 40p machine, but it has a 604 by default anyway, and I've never seen anybody using "-cpu default" with that machine. So IMHO it's not necessary to document this - but if people here have a different feeling, then I can also respin the patch, just let me know.
I'll queue this up as is, don't worry about it.
You can send an extra patch for removed-features.rst if we really think it's needed. I don't mind the extra documentation, but NGL this is the first time I've ever heard of '-cpu default'.
Thanks,
Daniel
Quoted 3 lines
Thomas