stv0367: Fix potential divide error

PATCH In review Igor M. Liplianin 1 participant 1 message Dec 31, 2010 Media (V4L/DVB)

lore

Share & tools

lore

Igor M. Liplianin

author

2010-12-31 05:32 UTC #0 lore raw

PATCH 9/18 stv0367: Fix potential divide error

Signed-off-by Igor M. Liplianin <[email protected]>

---
 drivers/media/dvb/frontends/stv0367.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

drivers/media/dvb/frontends/stv0367.c +3 -1

index 0575741..e6bee7f 100644
@@ -3275,12 +3275,14 @@ static int stv0367cab_read_snr(struct dvb_frontend *fe, u16 *snr)
 		power = 1;
 		break;
 	}
+
 	for (i = 0; i < 10; i++) {
 		regval += (stv0367_readbits(state, F367CAB_SNR_LO)
 			+ 256 * stv0367_readbits(state, F367CAB_SNR_HI));
 	}
+
+	regval /= 10; /*for average over 10 times in for loop above*/
 	if (regval != 0) {
-		regval /= 10; /*for average over 10 times in for loop above*/
 		temp = power
 			* (1 << (3 + stv0367_readbits(state, F367CAB_SNR_PER)));
 		temp /= regval;

Signature · 1 line

1.7.1